)]}'
{"oslo_messaging/_executors/impl_pooledexecutor.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"24fb222569438fc197dbfa0eb5cadce61bae8d3a","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def start(self, override_pool_size\u003dNone):"},{"line_number":108,"context_line":"        if self._executor is None:"},{"line_number":109,"context_line":"            self._executor \u003d self._executor_cls("},{"line_number":110,"context_line":"                override_pool_size if override_pool_size else"},{"line_number":111,"context_line":"                self.conf.executor_thread_pool_size)"},{"line_number":112,"context_line":"        self._tombstone.clear()"},{"line_number":113,"context_line":"        if self._poller is None or not self._poller.is_alive():"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_68f5db81","line":110,"updated":"2016-02-02 23:54:05.000000000","message":"Probably a good idea to check the min of this value, and ensure its greater than some min right. Maybe 1? or are more needed...","commit_id":"a6905b7516629e18525d871ace163bf681b46d9e"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"fba7a8f59d96ae6282c44c7caaf38cf6b9c65bd4","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def start(self, override_pool_size\u003dNone):"},{"line_number":108,"context_line":"        if self._executor is None:"},{"line_number":109,"context_line":"            self._executor \u003d self._executor_cls("},{"line_number":110,"context_line":"                override_pool_size if override_pool_size else"},{"line_number":111,"context_line":"                self.conf.executor_thread_pool_size)"},{"line_number":112,"context_line":"        self._tombstone.clear()"},{"line_number":113,"context_line":"        if self._poller is None or not self._poller.is_alive():"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_66dbb11c","line":110,"in_reply_to":"5a5ae5dd_68f5db81","updated":"2016-02-03 13:46:56.000000000","message":"will do","commit_id":"a6905b7516629e18525d871ace163bf681b46d9e"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"6da2c59f2b472fadd7fb5bd2d18a82f8d5614a35","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def start(self, override_pool_size\u003dNone):"},{"line_number":108,"context_line":"        if self._executor is None:"},{"line_number":109,"context_line":"            try:"},{"line_number":110,"context_line":"                if int(override_pool_size) \u003c 1:"},{"line_number":111,"context_line":"                    override_pool_size \u003d None"},{"line_number":112,"context_line":"            except Exception:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a5ae5dd_1c124063","line":109,"updated":"2016-02-03 17:33:30.000000000","message":"Hmmm, how about raise a value error instead of silently dropping the bad value, that seems to make sense to raise that imho since if a user of this is actually providing a override and they provide a bad value, then seems like they should get an exception saying \u0027u provided a bad value\u0027 vs no exception at all.","commit_id":"9ceb4b44332c738f9c8091e4448d4ea5d730910c"}]}