)]}'
{"oslo_messaging/_drivers/zmq_driver/client/publishers/dealer/zmq_dealer_call_publisher.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"41b95932b0be6bf1f2a3816783fe2b9c5ece8fd3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            socket.send(b\u0027\u0027, zmq.SNDMORE)"},{"line_number":52,"context_line":"            socket.send_pyobj(request)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"            LOG.debug(\"Sending message_id %(message)s to a target %(target)s\","},{"line_number":55,"context_line":"                      {\"message\": request.message_id,"},{"line_number":56,"context_line":"                       \"target\": request.target})"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_e4c56f0a","line":54,"updated":"2016-02-09 01:58:46.000000000","message":"Nit, u probably mean \u0027sent\u0027 instead of \u0027sending\u0027 at this point right?","commit_id":"9f8baeb54a1a2498d535a8166e51e04bd3a04224"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"aa4ced37dfc56632aed5ab8459cca4fdc45f74e2","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            socket.send(b\u0027\u0027, zmq.SNDMORE)"},{"line_number":52,"context_line":"            socket.send_pyobj(request)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"            LOG.debug(\"Sending message_id %(message)s to a target %(target)s\","},{"line_number":55,"context_line":"                      {\"message\": request.message_id,"},{"line_number":56,"context_line":"                       \"target\": request.target})"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_89991d22","line":54,"in_reply_to":"5a5ae5dd_e4c56f0a","updated":"2016-02-09 11:32:30.000000000","message":"Done","commit_id":"9f8baeb54a1a2498d535a8166e51e04bd3a04224"}],"oslo_messaging/_drivers/zmq_driver/client/publishers/zmq_publisher_base.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"41b95932b0be6bf1f2a3816783fe2b9c5ece8fd3","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        self._do_send_request \u003d _do_send_request"},{"line_number":156,"context_line":"        self.queue, self.empty_except \u003d zmq_async.get_queue()"},{"line_number":157,"context_line":"        self.executor \u003d zmq_async.get_executor(self.run_loop)"},{"line_number":158,"context_line":"        self.executor.execute()"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def send_request(self, request):"},{"line_number":161,"context_line":"        self.queue.put(request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_e4932fff","line":158,"updated":"2016-02-09 01:58:46.000000000","message":"Is this like executor.start (but oddly named execute?)","commit_id":"9f8baeb54a1a2498d535a8166e51e04bd3a04224"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"96d2341336dcbe8164f5b4499c5814332022a4b0","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        self._do_send_request \u003d _do_send_request"},{"line_number":156,"context_line":"        self.queue, self.empty_except \u003d zmq_async.get_queue()"},{"line_number":157,"context_line":"        self.executor \u003d zmq_async.get_executor(self.run_loop)"},{"line_number":158,"context_line":"        self.executor.execute()"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def send_request(self, request):"},{"line_number":161,"context_line":"        self.queue.put(request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_6cb94fec","line":158,"in_reply_to":"5a5ae5dd_ccb5e331","updated":"2016-02-09 11:36:49.000000000","message":"If you notice some other odd names or so please also point on them and we\u0027ll do all these changes in a single patch.","commit_id":"9f8baeb54a1a2498d535a8166e51e04bd3a04224"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"aa4ced37dfc56632aed5ab8459cca4fdc45f74e2","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        self._do_send_request \u003d _do_send_request"},{"line_number":156,"context_line":"        self.queue, self.empty_except \u003d zmq_async.get_queue()"},{"line_number":157,"context_line":"        self.executor \u003d zmq_async.get_executor(self.run_loop)"},{"line_number":158,"context_line":"        self.executor.execute()"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    def send_request(self, request):"},{"line_number":161,"context_line":"        self.queue.put(request)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_ccb5e331","line":158,"in_reply_to":"5a5ae5dd_e4932fff","updated":"2016-02-09 11:32:30.000000000","message":"Yes, do you propose to rename it to start? I\u0027m going to prepare a patch with some renames over the driver, so we can include this change into it.","commit_id":"9f8baeb54a1a2498d535a8166e51e04bd3a04224"}]}
