)]}'
{"oslo_messaging/_drivers/zmq_driver/client/zmq_request.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"1e028f3d406dbb040148f2b3fa9123b02e9b8c9b","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self.timeout \u003d kwargs.pop(\"timeout\")"},{"line_number":95,"context_line":"        if self.msg_type \u003d\u003d zmq_names.CALL_TYPE:"},{"line_number":96,"context_line":"            assert self.timeout is not None, \"Timeout should be specified!\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        if not isinstance(self.timeout, int) and self.timeout is not None:"},{"line_number":99,"context_line":"            raise ValueError("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_44b2ea95","line":96,"updated":"2016-02-11 09:19:08.000000000","message":"This is useless check the code below already raise ValueError in that case.","commit_id":"f7ac5ff9e6521ea88f4ce11cb60a6e4fcd5351e4"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"c19a0ded3f0be6ec058e98de980c037679eaaf63","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self.timeout \u003d kwargs.pop(\"timeout\")"},{"line_number":95,"context_line":"        if self.msg_type \u003d\u003d zmq_names.CALL_TYPE:"},{"line_number":96,"context_line":"            assert self.timeout is not None, \"Timeout should be specified!\""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        if not isinstance(self.timeout, int) and self.timeout is not None:"},{"line_number":99,"context_line":"            raise ValueError("}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_fa4a8aab","line":96,"in_reply_to":"3a57f1b5_44b2ea95","updated":"2016-02-11 10:46:38.000000000","message":"It does not seem this is useless: if the timeout is None, the code below will not raise ValueError(It just allows a int or None), but if it\u0027s a rpc call the timeout must not be None.\n\nHere I have doubt whether it is necessary to use \"assert\"(not sure why not use \"raise\").","commit_id":"f7ac5ff9e6521ea88f4ce11cb60a6e4fcd5351e4"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"246ffdc5b638d824297804c0cc6722f5e107d5ea","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            LOG.error(_LE(\"No method specified for RPC call\"))"},{"line_number":92,"context_line":"            raise KeyError(errmsg)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self.timeout \u003d kwargs.pop(\"timeout\")"},{"line_number":95,"context_line":"        if self.msg_type \u003d\u003d zmq_names.CALL_TYPE and self.timeout is None:"},{"line_number":96,"context_line":"            raise ValueError(\"Timeout should be specified for a RPC call!\")"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_c61462ea","line":94,"updated":"2016-02-18 10:08:05.000000000","message":"Please move this to CallRequest so we don\u0027t need to check it here at all.","commit_id":"b63d3c9fac48bb120c7f485b4642f4153aac2b8a"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"31bec55f9520f15b7fb5f38505a7f3e5b9886b16","unresolved":false,"context_lines":[{"line_number":91,"context_line":"            LOG.error(_LE(\"No method specified for RPC call\"))"},{"line_number":92,"context_line":"            raise KeyError(errmsg)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        self.timeout \u003d kwargs.pop(\"timeout\")"},{"line_number":95,"context_line":"        if self.msg_type \u003d\u003d zmq_names.CALL_TYPE and self.timeout is None:"},{"line_number":96,"context_line":"            raise ValueError(\"Timeout should be specified for a RPC call!\")"},{"line_number":97,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dae33548_437f9fdf","line":94,"in_reply_to":"dae33548_c61462ea","updated":"2016-02-18 11:15:10.000000000","message":"Done","commit_id":"b63d3c9fac48bb120c7f485b4642f4153aac2b8a"}]}