)]}'
{"oslo_messaging/_drivers/zmq_driver/client/publishers/dealer/zmq_dealer_publisher.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"9f25c994b18d4eea0f211f2802a6e9e96758cf5e","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            envelope \u003d request.create_envelope()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            socket.send(b\u0027\u0027, zmq.SNDMORE)"},{"line_number":74,"context_line":"            socket.send_pyobj(envelope.to_dict(), zmq.SNDMORE)"},{"line_number":75,"context_line":"            socket.send_pyobj(request)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            LOG.debug(\"-\u003e[proxy:%(addr)s] Sending message_id %(message)s to \""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_16cc5c88","line":74,"updated":"2016-02-26 11:23:47.000000000","message":"I suppose we can send envelope object without conversion to dict, pickle will do all things for us.","commit_id":"2399f7ae1cfcfecdf8d579c0c958d003207a04ff"},{"author":{"_account_id":15424,"name":"javeme","email":"javaloveme@gmail.com","username":"javeme"},"change_message_id":"f111815c9d42e2d05b82bbac4f9a89141076272d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            envelope \u003d request.create_envelope()"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            socket.send(b\u0027\u0027, zmq.SNDMORE)"},{"line_number":74,"context_line":"            socket.send_pyobj(envelope.to_dict(), zmq.SNDMORE)"},{"line_number":75,"context_line":"            socket.send_pyobj(request)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"            LOG.debug(\"-\u003e[proxy:%(addr)s] Sending message_id %(message)s to \""}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_fccef758","line":74,"in_reply_to":"9aed3d3a_16cc5c88","updated":"2016-02-26 12:12:29.000000000","message":"Done","commit_id":"2399f7ae1cfcfecdf8d579c0c958d003207a04ff"}],"oslo_messaging/_drivers/zmq_driver/zmq_message.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"029c2d262b8322c3926225e1b6f08fdf417ce72b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_messaging._drivers.zmq_driver import zmq_names"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"class ZmqMessage(object):"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"    def __init__(self, orig_data\u003dNone, id\u003dNone, type\u003dNone,"},{"line_number":21,"context_line":"                 message_id\u003dNone, msg_type\u003dNone, target\u003dNone,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_017bfa8c","line":18,"updated":"2016-02-23 15:43:48.000000000","message":"I\u0027m not happy with the name because we have too many entities called \u0027message\u0027 in the driver (there are message(means data), incoming message, request etc). I also don\u0027t like the common wrapper to access fields of any object (we use it for reply and for request envelope as well). My proposal is to implement Response class similar to the Request we have already. Response will be used for CALL pattern only. Now we send dict. The most fields accessed by the wrapper will go to that Response. The other part relates to Envelope we use for passing request via ZmqProxy. Envelope is generated from request with method create_envelope() and contains enough information for proxy not to deserialize request on a proxy side so we keep high performance and avoid deserialization problems of unknown types etc. Currently we also have envelope as a dict object. I propose to make a class for it.\n\nSummary:\nInstead of making wrappers lets implement Response and RequestEnvelope classes and reduce dicts in our messages.","commit_id":"fe1049b9d8c477962cfc27f175f634cc899f727a"}]}