)]}'
{"oslo_messaging/_drivers/impl_kafka.py":[{"author":{"_account_id":16871,"name":"Sanjana","email":"sanjana@hitachi.co.in","username":"sanjana_93"},"change_message_id":"6df987f7be517908d3c5ec18c542d0c24c5c7896","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        \"\"\"receive messages as many as max_fetch_messages."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        In this functions, there are no while loop to subscribe."},{"line_number":150,"context_line":"        This would be helpful when we wants to control the velocity of"},{"line_number":151,"context_line":"        subscription."},{"line_number":152,"context_line":"        \"\"\""},{"line_number":153,"context_line":"        duration \u003d (self.consumer_timeout if timeout is None else timeout)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_1147e44b","line":150,"range":{"start_line":150,"start_character":35,"end_line":150,"end_character":43},"updated":"2016-02-23 06:23:20.000000000","message":"*we want.\nSince this is a trivial fix, I guess you can even include this as a part of your fix.","commit_id":"7f9d4dfda70db0bde8a4f27f8690fb5a1c41b67b"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"d6286fe709e839484df67b49af29d1c54bd8bb12","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        \"\"\"Receive up to \u0027max_fetch_messages\u0027 messages."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        A while loop to subscribe would help to control the velocity of"},{"line_number":150,"context_line":"        subscription."},{"line_number":151,"context_line":"        \"\"\""},{"line_number":152,"context_line":"        duration \u003d (self.consumer_timeout if timeout is None else timeout)"},{"line_number":153,"context_line":"        timer \u003d driver_common.DecayingTimer(duration\u003dduration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_583348f6","line":150,"updated":"2016-02-23 09:55:56.000000000","message":"I\u0027ve applied standard transformations to fix the English, but this makes no sense to me. There is a while loop, so presumably the author wants another one? How should the loops interface? What does \u0027to subscribe\u0027 mean, consume a message?\n\nI\u0027d be happier if the bit about the while loop was deleted entirely.","commit_id":"970e689e1550d18127d12273d11d565e48f7d98a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"71f7a94f324d303c4f793bc88125fe5fedef9ee5","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        \"\"\"Receive up to \u0027max_fetch_messages\u0027 messages."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        A while loop to subscribe would help to control the velocity of"},{"line_number":150,"context_line":"        subscription."},{"line_number":151,"context_line":"        \"\"\""},{"line_number":152,"context_line":"        duration \u003d (self.consumer_timeout if timeout is None else timeout)"},{"line_number":153,"context_line":"        timer \u003d driver_common.DecayingTimer(duration\u003dduration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_a1efb8e7","line":150,"in_reply_to":"bae84128_583348f6","updated":"2016-02-23 13:15:54.000000000","message":"or we can leave the message as is and someone can track down author who added it[1]. considering this doesn\u0027t really relate to original spelling patch, it\u0027s best we leave it.\n\n[1]https://github.com/openstack/oslo.messaging/commit/67c63031f5cb1a675686fc2648ce27f6e36ee254","commit_id":"970e689e1550d18127d12273d11d565e48f7d98a"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"9764a60c190e4774a7b0c7e4582b9da0edc4d697","unresolved":false,"context_lines":[{"line_number":146,"context_line":"    def consume(self, timeout\u003dNone):"},{"line_number":147,"context_line":"        \"\"\"Receive up to \u0027max_fetch_messages\u0027 messages."},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        :param timeout: String of the topic"},{"line_number":150,"context_line":"        \"\"\""},{"line_number":151,"context_line":"        duration \u003d (self.consumer_timeout if timeout is None else timeout)"},{"line_number":152,"context_line":"        timer \u003d driver_common.DecayingTimer(duration\u003dduration)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_f8c203e8","line":149,"updated":"2016-02-23 17:19:23.000000000","message":"Uh, of the topic? Of the timeout surely? Do you know the format please, EG \"120\", \"120s\", ...","commit_id":"e784b7108759a977898f6dcd897ee916ca0db79e"}]}
