)]}'
{"oslo_messaging/notify/notifier.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"1df0a0dc4e74233a5ef10b8d645790af0ba6eb89","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        notifier.info(ctxt, event_type, payload)"},{"line_number":144,"context_line":"    \"\"\""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @renames.renamed_kwarg(\u0027topic\u0027, \u0027topics\u0027,"},{"line_number":147,"context_line":"                           message\u003d\"Please use topics instead of topic\")"},{"line_number":148,"context_line":"    def __init__(self, transport, publisher_id\u003dNone,"},{"line_number":149,"context_line":"                 driver\u003dNone, topic\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_e7b851eb","line":146,"updated":"2016-02-24 19:43:46.000000000","message":"Use replace\u003dTrue?\n\nhttps://github.com/openstack/debtcollector/blob/master/debtcollector/renames.py#L36","commit_id":"3234ee544768c5ede48f1e55bb7979a9687804dd"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"b8c9c544cc6ded7ec0e58c00724048290098431d","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        notifier.info(ctxt, event_type, payload)"},{"line_number":144,"context_line":"    \"\"\""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @renames.renamed_kwarg(\u0027topic\u0027, \u0027topics\u0027,"},{"line_number":147,"context_line":"                           message\u003d\"Please use topics instead of topic\")"},{"line_number":148,"context_line":"    def __init__(self, transport, publisher_id\u003dNone,"},{"line_number":149,"context_line":"                 driver\u003dNone, topic\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_3b81b0fc","line":146,"in_reply_to":"bae84128_e7b851eb","updated":"2016-02-24 20:56:21.000000000","message":"Don\u0027t want to do a replace as topic is a string and topics is a list","commit_id":"3234ee544768c5ede48f1e55bb7979a9687804dd"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"31d0dc2a7681bad2623e1c87d50c315efbc8da65","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        notifier.info(ctxt, event_type, payload)"},{"line_number":144,"context_line":"    \"\"\""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @renames.renamed_kwarg(\u0027topic\u0027, \u0027topics\u0027,"},{"line_number":147,"context_line":"                           message\u003d\"Please use topics instead of topic\")"},{"line_number":148,"context_line":"    def __init__(self, transport, publisher_id\u003dNone,"},{"line_number":149,"context_line":"                 driver\u003dNone, topic\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_a7764904","line":146,"in_reply_to":"bae84128_e7b851eb","updated":"2016-02-24 19:50:48.000000000","message":"as I know next to nothing about debtcollector, replace seems imply the same datatype.  topic is string, topics is list.","commit_id":"3234ee544768c5ede48f1e55bb7979a9687804dd"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"a109542c9b6f16df5774fc3479d22762dc271417","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    \"\"\""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @renames.renamed_kwarg(\u0027topic\u0027, \u0027topics\u0027,"},{"line_number":147,"context_line":"                           message\u003d\"Please use topics instead of topic\")"},{"line_number":148,"context_line":"    def __init__(self, transport, publisher_id\u003dNone,"},{"line_number":149,"context_line":"                 driver\u003dNone, topic\u003dNone,"},{"line_number":150,"context_line":"                 serializer\u003dNone, retry\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_a76be984","line":147,"updated":"2016-02-24 19:48:09.000000000","message":"suggest you add version\u003d and removal_version\u003d so we can know when to potentially remove topic.","commit_id":"3234ee544768c5ede48f1e55bb7979a9687804dd"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"b8c9c544cc6ded7ec0e58c00724048290098431d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    \"\"\""},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @renames.renamed_kwarg(\u0027topic\u0027, \u0027topics\u0027,"},{"line_number":147,"context_line":"                           message\u003d\"Please use topics instead of topic\")"},{"line_number":148,"context_line":"    def __init__(self, transport, publisher_id\u003dNone,"},{"line_number":149,"context_line":"                 driver\u003dNone, topic\u003dNone,"},{"line_number":150,"context_line":"                 serializer\u003dNone, retry\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_9b727c48","line":147,"in_reply_to":"bae84128_a76be984","updated":"2016-02-24 20:56:21.000000000","message":"Done","commit_id":"3234ee544768c5ede48f1e55bb7979a9687804dd"},{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"a109542c9b6f16df5774fc3479d22762dc271417","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        :type publisher_id: str"},{"line_number":159,"context_line":"        :param driver: a driver to lookup from oslo_messaging.notify.drivers"},{"line_number":160,"context_line":"        :type driver: str"},{"line_number":161,"context_line":"        :param topic: the topic which to send messages on"},{"line_number":162,"context_line":"        :type topic: str"},{"line_number":163,"context_line":"        :param serializer: an optional entity serializer"},{"line_number":164,"context_line":"        :type serializer: Serializer"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_87c4e55f","line":161,"updated":"2016-02-24 19:48:09.000000000","message":"should you indicate something here also?","commit_id":"3234ee544768c5ede48f1e55bb7979a9687804dd"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"b8c9c544cc6ded7ec0e58c00724048290098431d","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        :type publisher_id: str"},{"line_number":159,"context_line":"        :param driver: a driver to lookup from oslo_messaging.notify.drivers"},{"line_number":160,"context_line":"        :type driver: str"},{"line_number":161,"context_line":"        :param topic: the topic which to send messages on"},{"line_number":162,"context_line":"        :type topic: str"},{"line_number":163,"context_line":"        :param serializer: an optional entity serializer"},{"line_number":164,"context_line":"        :type serializer: Serializer"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_5bc6344a","line":161,"in_reply_to":"bae84128_87c4e55f","updated":"2016-02-24 20:56:21.000000000","message":"since we have the decorator and the definition for topics below. we should be ok","commit_id":"3234ee544768c5ede48f1e55bb7979a9687804dd"}],"oslo_messaging/tests/notify/test_notifier.py":[{"author":{"_account_id":16051,"name":"Ronald Bradford","email":"ronald.bradford@gmail.com","username":"ronaldbradford"},"change_message_id":"a109542c9b6f16df5774fc3479d22762dc271417","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        transport \u003d _FakeTransport(self.conf)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        notifier \u003d oslo_messaging.Notifier(transport, \u0027test.localhost\u0027,"},{"line_number":287,"context_line":"                                           topic\u003d\u0027topic1\u0027)"},{"line_number":288,"context_line":"        self.assertEqual([\u0027topic1\u0027], notifier._topics)"},{"line_number":289,"context_line":"        notifier \u003d oslo_messaging.Notifier(transport, \u0027test.localhost\u0027,"},{"line_number":290,"context_line":"                                           topics\u003d[\u0027topic1\u0027, \u0027topic2\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_07b455cf","line":287,"updated":"2016-02-24 19:48:09.000000000","message":"Is there merit in mocking renames.renamed_kwarg and ensuring a count of 1 here?","commit_id":"3234ee544768c5ede48f1e55bb7979a9687804dd"},{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"b8c9c544cc6ded7ec0e58c00724048290098431d","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        transport \u003d _FakeTransport(self.conf)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        notifier \u003d oslo_messaging.Notifier(transport, \u0027test.localhost\u0027,"},{"line_number":287,"context_line":"                                           topic\u003d\u0027topic1\u0027)"},{"line_number":288,"context_line":"        self.assertEqual([\u0027topic1\u0027], notifier._topics)"},{"line_number":289,"context_line":"        notifier \u003d oslo_messaging.Notifier(transport, \u0027test.localhost\u0027,"},{"line_number":290,"context_line":"                                           topics\u003d[\u0027topic1\u0027, \u0027topic2\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_3be6d0e8","line":287,"in_reply_to":"bae84128_07b455cf","updated":"2016-02-24 20:56:21.000000000","message":"not worth the effort we are not testing renames here.","commit_id":"3234ee544768c5ede48f1e55bb7979a9687804dd"}]}
