)]}'
{"oslo_messaging/_drivers/pika_driver/pika_engine.py":[{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"6e29452d3fbc7b5e3df78d64c1613b420eb0262e","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        queue_parts \u003d [\"no_ack\" if no_ack else \"with_ack\", topic]"},{"line_number":445,"context_line":"        if server is not None:"},{"line_number":446,"context_line":"            queue_parts.append(server)"},{"line_number":447,"context_line":"        if fanout:"},{"line_number":448,"context_line":"            queue_parts.append(\"fanout\")"},{"line_number":449,"context_line":"            queue_parts.append(uuid.uuid4().hex)"},{"line_number":450,"context_line":"        queue \u003d \u0027.\u0027.join(queue_parts)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_be703141","line":447,"range":{"start_line":447,"start_character":11,"end_line":447,"end_character":17},"updated":"2016-03-10 18:10:25.000000000","message":"Queue can not be fanout. It is just a queue. It is queue which is consumed by single worker only. So it would be reasonable to have three kind of queues: \"\u003ctopic\u003e\", \"\u003ctopic\u003e.\u003cserver\u003e\" and \"\u003ctopic\u003e.\u003cserver\u003e.\u003cworker\u003e\". Routing depends on bindings not on queue","commit_id":"a91a60ae03a8a23e73c0ca80470670a12f2ba5f8"}],"oslo_messaging/_drivers/pika_driver/pika_poller.py":[{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"6e29452d3fbc7b5e3df78d64c1613b420eb0262e","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                     \"consumer_tag\": None}"},{"line_number":329,"context_line":"                )"},{"line_number":330,"context_line":""},{"line_number":331,"context_line":"                fanout_server_queue \u003d self._pika_engine.get_rpc_queue_name("},{"line_number":332,"context_line":"                    self._target.topic, self._target.server, no_ack, True"},{"line_number":333,"context_line":"                )"},{"line_number":334,"context_line":"                all_servers_routing_key \u003d self._pika_engine.get_rpc_queue_name("}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_e82ddafe","line":331,"range":{"start_line":331,"start_character":16,"end_line":331,"end_character":35},"updated":"2016-03-10 18:10:25.000000000","message":"worker_queue, not fanout","commit_id":"a91a60ae03a8a23e73c0ca80470670a12f2ba5f8"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"6e29452d3fbc7b5e3df78d64c1613b420eb0262e","unresolved":false,"context_lines":[{"line_number":331,"context_line":"                fanout_server_queue \u003d self._pika_engine.get_rpc_queue_name("},{"line_number":332,"context_line":"                    self._target.topic, self._target.server, no_ack, True"},{"line_number":333,"context_line":"                )"},{"line_number":334,"context_line":"                all_servers_routing_key \u003d self._pika_engine.get_rpc_queue_name("},{"line_number":335,"context_line":"                    self._target.topic, \"all_servers\", no_ack"},{"line_number":336,"context_line":"                )"},{"line_number":337,"context_line":"                self._pika_engine.declare_queue_binding_by_channel("}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_48d96ef2","line":334,"range":{"start_line":334,"start_character":16,"end_line":334,"end_character":39},"updated":"2016-03-10 18:10:25.000000000","message":"routing key should be \u003ctopic\u003e.all_workers, not all_servers","commit_id":"a91a60ae03a8a23e73c0ca80470670a12f2ba5f8"}]}