)]}'
{"oslo_messaging/_drivers/protocols/amqp/controller.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"0db4b910eed0f04a34883a0df17f7379227b224a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self._link \u003d None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def send(self, message, callback):"},{"line_number":80,"context_line":"        # send message out the link, invoke callback when acked"},{"line_number":81,"context_line":"        self._link.send(message, delivery_callback\u003dcallback)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def sender_remote_closed(self, sender_link, pn_condition):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_af1ed860","line":80,"updated":"2016-03-30 05:25:14.000000000","message":"Does there need to be checks here to see if self._link is none (send before attach?), or is the safety of that not needed?","commit_id":"f42d88617c8acfb751f5f0538bdba0d158d3a363"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"85b407708b8c45ba51c45bd6bd56b7a72f28e0f6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self._link \u003d None"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def send(self, message, callback):"},{"line_number":80,"context_line":"        # send message out the link, invoke callback when acked"},{"line_number":81,"context_line":"        self._link.send(message, delivery_callback\u003dcallback)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def sender_remote_closed(self, sender_link, pn_condition):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a061dce_a67c8121","line":80,"in_reply_to":"ba0121b8_af1ed860","updated":"2016-04-04 15:58:31.000000000","message":"Sorry for the late reply - thanks for taking a look at this.\n\nThe _link member is set (via calling attach()) when the Sender object is constructed.  It is reset to None when the Sender is destroyed.  This method is only called via the protocol processing thread (not the app\u0027s thread) - so it isn\u0027t possible to hit that failure unless there is a bug in the driver itself.  \n\nHaving said that it might make sense to merge the attach() into the Sender constructor.  I don\u0027t want to do that currently because I have a follow-up patch in-progress that will need to control when the attach() is done.  That patch will have to be careful to check the _link\u0027s validity when sending.","commit_id":"f42d88617c8acfb751f5f0538bdba0d158d3a363"}]}
