)]}'
{"oslo_messaging/_drivers/amqpdriver.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"cae04091ce50d428d6f9fd53f97b0acceddb19b2","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            if self._reply_q is not None:"},{"line_number":379,"context_line":"                return self._reply_q"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"            if hasattr(target, \u0027server\u0027) and target.server:"},{"line_number":382,"context_line":"                reply_q \u003d \u0027reply_%s_%s\u0027 % (target.server, uuid.uuid4().hex)"},{"line_number":383,"context_line":"            else:"},{"line_number":384,"context_line":"                reply_q \u003d \u0027reply_\u0027 + uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_897322b1","line":381,"updated":"2016-12-01 21:39:35.000000000","message":"Won\u0027t this simply use the first _reply_q created, regardless of subsequent calls with different target.server values?\n\nThe AMQPDriverBase only supports a single reply queue for all send requests, regardless of target.","commit_id":"c1aca5deaefb9d16b13a0d171a63f25c86740bc8"},{"author":{"_account_id":2218,"name":"Adam Young","email":"adam@younglogic.com","username":"ayoung"},"change_message_id":"fff1c109e6fa544476b17470af0e86416c90e582","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            if self._reply_q is not None:"},{"line_number":379,"context_line":"                return self._reply_q"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"            if hasattr(target, \u0027server\u0027) and target.server:"},{"line_number":382,"context_line":"                reply_q \u003d \u0027reply_%s_%s\u0027 % (target.server, uuid.uuid4().hex)"},{"line_number":383,"context_line":"            else:"},{"line_number":384,"context_line":"                reply_q \u003d \u0027reply_\u0027 + uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_ca46de22","line":381,"in_reply_to":"3a71b18c_897322b1","updated":"2016-12-02 04:39:24.000000000","message":"Has the behavior of this changed since I wrote it?  That was not the case a while back.","commit_id":"c1aca5deaefb9d16b13a0d171a63f25c86740bc8"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"fc44826d8a02d9ee9f83947352e2ea99dcb4e076","unresolved":false,"context_lines":[{"line_number":378,"context_line":"            if self._reply_q is not None:"},{"line_number":379,"context_line":"                return self._reply_q"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"            if hasattr(target, \u0027server\u0027) and target.server:"},{"line_number":382,"context_line":"                reply_q \u003d \u0027reply_%s_%s\u0027 % (target.server, uuid.uuid4().hex)"},{"line_number":383,"context_line":"            else:"},{"line_number":384,"context_line":"                reply_q \u003d \u0027reply_\u0027 + uuid.uuid4().hex"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a71b18c_89e694b2","line":381,"in_reply_to":"3a71b18c_ca46de22","updated":"2016-12-02 16:21:23.000000000","message":"When did you write it?\n\nAFAIKT - this class - AMQPDriverBase - only has a single reply queue (self._reply_q), which is created when the first RPC call is issued.\n\nMany RPC callers share this class.  They all can be sending to different targets (servers).  With this patch the first caller will create the queue based on its target, which may be completely different from the later RPC callers.\n\nUnless I\u0027m missing something (adding the other oslo.messaging-devs).\n\nRegardless - this patch introduces a feature/capability to only one of the possible backends, which violates the abstraction that is the purpose of the oslo.messaging API.\n\nCan you elaborate on exactly what it is you are trying to achieve here?  Perhaps there\u0027s a solution that can be common to all backends?","commit_id":"c1aca5deaefb9d16b13a0d171a63f25c86740bc8"}]}
