)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"b2192ee8b29cdd94b4d2abd92824876cdf711be1","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Also we have to set TCP_USER_TIMEOUT to ensure our timeouts are"},{"line_number":13,"context_line":"respected. socket.settimeout() of python relies on select() that can"},{"line_number":14,"context_line":"be blocked because kernel doesn\u0027t return during a recv() because of"},{"line_number":15,"context_line":"TCP connection breakage."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This change fixes that by always setting TCP_USER_TIMEOUT and python"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa0719c6_733f6dd6","line":14,"range":{"start_line":14,"start_character":31,"end_line":14,"end_character":32},"updated":"2016-03-22 23:29:41.000000000","message":"I don\u0027t know details of kombu driver heartbeats implementation but as far as I know we can use sync socket API (send, recv and settimeout for these operation) or use async API - settimeout(0) to enable non blocking recv and send and use select() to retrieve status of pending operations. if we need timeout for select, it has parameter select(..., timeout\u003d...). It is not clear how tcp_user_timeout will help. it is timeout for transmit of tcp packet. So if we don\u0027t receive tcp ack for some packet during this time - exception is raised. But is we sent heartbeat correctly, it is not guaranteed that RabbitMQ will send us response in specified heartbeat_interval and we need to use select(timeout\u003d...) anyway. In my opinion tcp_user_timeout it is rather network configuration option and should not depend on heartbeat functionality. Am I missing something?","commit_id":"98bc5fc2fadce089b6f47421929651606e5e9ab6"}]}
