)]}'
{"oslo_messaging/rpc/dispatcher.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"735dc9aa106d87f455879d64f86bb5d3abc0d3c2","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"@functools.total_ordering"},{"line_number":201,"context_line":"class _SortableWorkItem(_utils.WorkItem):"},{"line_number":202,"context_line":"    def __init__(self, sort_index, future, fn, *args, **kwargs):"},{"line_number":203,"context_line":"        super(_SortableWorkItem, self).__init__(future, fn, *args, **kwargs)"},{"line_number":204,"context_line":"        # This should be an int or tuple. Using a tuple with an incrementing"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_f2287235","line":201,"updated":"2016-03-17 20:21:56.000000000","message":"Probably should land it futurist lib, but ya, seems to make sense.","commit_id":"2986564dae3dc91d7e2daf430e1cfa27f75e9c00"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"e59c72cc369e689ea6f2bec8ad49235aa7dc961c","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"@functools.total_ordering"},{"line_number":201,"context_line":"class _SortableWorkItem(_utils.WorkItem):"},{"line_number":202,"context_line":"    def __init__(self, sort_index, future, fn, *args, **kwargs):"},{"line_number":203,"context_line":"        super(_SortableWorkItem, self).__init__(future, fn, *args, **kwargs)"},{"line_number":204,"context_line":"        # This should be an int or tuple. Using a tuple with an incrementing"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_f694b98b","line":201,"in_reply_to":"1af94dfe_bbd33ad4","updated":"2016-03-18 15:38:03.000000000","message":"Yup, agreed, just something to do in the future.","commit_id":"2986564dae3dc91d7e2daf430e1cfa27f75e9c00"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"97ba0b85beb9097733a1ee4515427a01878de456","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"@functools.total_ordering"},{"line_number":201,"context_line":"class _SortableWorkItem(_utils.WorkItem):"},{"line_number":202,"context_line":"    def __init__(self, sort_index, future, fn, *args, **kwargs):"},{"line_number":203,"context_line":"        super(_SortableWorkItem, self).__init__(future, fn, *args, **kwargs)"},{"line_number":204,"context_line":"        # This should be an int or tuple. Using a tuple with an incrementing"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_bbd33ad4","line":201,"in_reply_to":"1af94dfe_f2287235","updated":"2016-03-18 15:32:06.000000000","message":"Agreed that this and the class below more properly belong in the futurist lib.\n\nI mostly wanted to get this up to use in conversations about this idea to help keep it focused. And to provide an idea on what actually needs to change to accomplish it. If there\u0027s not harsh resistance I will start to split this out, test it, and push proper patches.","commit_id":"2986564dae3dc91d7e2daf430e1cfa27f75e9c00"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"735dc9aa106d87f455879d64f86bb5d3abc0d3c2","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        return self.sort_index \u003c other.sort_index"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"class PriorityGreenThreadPoolExecutor(_futures.GreenThreadPoolExecutor):"},{"line_number":217,"context_line":"    def __init__(self, max_workers\u003d1000, check_and_reject\u003dNone):"},{"line_number":218,"context_line":"        super(PriorityGreenThreadPoolExecutor, self).__init__(max_workers,"},{"line_number":219,"context_line":"                check_and_reject)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_52dfa668","line":216,"updated":"2016-03-17 20:21:56.000000000","message":"Interesting and/or neat...\n\nProbably should land it futurist lib, but ya, seems to make sense.","commit_id":"2986564dae3dc91d7e2daf430e1cfa27f75e9c00"}],"oslo_messaging/rpc/server.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"a9856269b2c4511ce977c4fa2f2f6b80ffd3080a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        method \u003d getattr(self.endpoint, method_name)"},{"line_number":130,"context_line":"        future_job \u003d self.executor.submit(method, ctxt, *args, **kwargs)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        def job_complete(fut):"},{"line_number":133,"context_line":"            reply_callback(serializer.serialize_entity(ctxt, fut.result()))"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        future_job.add_done_callback(job_complete)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_18809df6","line":132,"updated":"2016-03-17 21:10:55.000000000","message":"So just fyi,\n\nWhen u access fut.result() if there was an exception in that future it will raise at this point, so u might want to handle that raising its contained exception (if it has one) here.","commit_id":"2986564dae3dc91d7e2daf430e1cfa27f75e9c00"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"97ba0b85beb9097733a1ee4515427a01878de456","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        method \u003d getattr(self.endpoint, method_name)"},{"line_number":130,"context_line":"        future_job \u003d self.executor.submit(method, ctxt, *args, **kwargs)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"        def job_complete(fut):"},{"line_number":133,"context_line":"            reply_callback(serializer.serialize_entity(ctxt, fut.result()))"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        future_job.add_done_callback(job_complete)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_1b06ae51","line":132,"in_reply_to":"1af94dfe_18809df6","updated":"2016-03-18 15:32:06.000000000","message":"I hadn\u0027t considered that yet, thanks.","commit_id":"2986564dae3dc91d7e2daf430e1cfa27f75e9c00"}]}
