)]}'
{"oslo_messaging/_drivers/amqpdriver.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"de9f7de8dc9c799e2607a4b3c5dd81a66c21efb9","unresolved":false,"context_lines":[{"line_number":487,"context_line":"                                    callback\u003dlistener)"},{"line_number":488,"context_line":"        conn.declare_fanout_consumer(target.topic, listener)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        return base.PollStyleListenerAdapter(listener, on_incoming_callback,"},{"line_number":491,"context_line":"                                             batch_size, batch_timeout)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def listen_for_notifications(self, targets_and_priorities, pool,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba0121b8_99e3a533","line":490,"updated":"2016-04-05 12:30:55.000000000","message":"This new class looks useless, the Listener and PollStyleListenerAdapter should be merged from my point of view.\n\nI guess you are waiting that all drivers move to the new interface for this ?","commit_id":"d5a3d2bc7982c52b90fe9bbea45053871c7ba7f6"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"d4234db4c220f7599e2af6d601b1be81eeba737f","unresolved":false,"context_lines":[{"line_number":487,"context_line":"                                    callback\u003dlistener)"},{"line_number":488,"context_line":"        conn.declare_fanout_consumer(target.topic, listener)"},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"        return base.PollStyleListenerAdapter(listener, on_incoming_callback,"},{"line_number":491,"context_line":"                                             batch_size, batch_timeout)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def listen_for_notifications(self, targets_and_priorities, pool,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_f15a7e29","line":490,"in_reply_to":"ba0121b8_99e3a533","updated":"2016-04-05 13:43:45.000000000","message":"I\u0027m not sure that all drivers should be moved to new interface. If some driver\u0027s listener has polling nature it will require its own implementation of poller thread. So PollStyleAdapter is a class-helper for such listeners and implements polling thread.\n\nBut the drivers which has event loop nature should be moved to new Listener interface to reduce not needed thread count and amount of other allocated resources","commit_id":"d5a3d2bc7982c52b90fe9bbea45053871c7ba7f6"}]}