)]}'
{"oslo_messaging/_drivers/impl_pika.py":[{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"9147ae34b233f2c0669e741729560c32bb2275cc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"message_opts \u003d ["},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027default_serializer_type\u0027, default\u003d\u0027json\u0027,"},{"line_number":55,"context_line":"               help\u003d\"Default serialization mechanism for \""},{"line_number":56,"context_line":"                    \"serializing/deserializing outgoing/incoming messages\")"},{"line_number":57,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab6814e_d56dca33","line":54,"updated":"2016-05-18 16:15:17.000000000","message":"let default be msg_pack","commit_id":"fc1e9855bc8d1df2e35fa92a8ca188e3ae416497"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"aac72cd72a1ac98827fd8e318bd9a52c76eb910d","unresolved":false,"context_lines":[{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"message_opts \u003d ["},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027default_serializer_type\u0027, default\u003d\u0027json\u0027,"},{"line_number":55,"context_line":"               help\u003d\"Default serialization mechanism for \""},{"line_number":56,"context_line":"                    \"serializing/deserializing outgoing/incoming messages\")"},{"line_number":57,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":15,"id":"bab6814e_e4ee2d8a","line":54,"in_reply_to":"bab6814e_d56dca33","updated":"2016-05-19 11:32:33.000000000","message":"Done","commit_id":"fc1e9855bc8d1df2e35fa92a8ca188e3ae416497"},{"author":{"_account_id":19520,"name":"Kirill Bespalov","email":"kbespalov@mirantis.com","username":"k.bespalov"},"change_message_id":"072edeead64bb2948b7ea4bbacb3f0bc90db5acc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"message_opts \u003d ["},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027default_serializer_type\u0027, default\u003d\u0027json\u0027,"},{"line_number":55,"context_line":"               help\u003d\"Default serialization mechanism for \""},{"line_number":56,"context_line":"                    \"serializing/deserializing outgoing/incoming messages\")"},{"line_number":57,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_e3eca994","line":54,"range":{"start_line":54,"start_character":15,"end_line":54,"end_character":56},"updated":"2016-08-02 15:02:00.000000000","message":"I think you can declare here choices\u003d[\u0027json\u0027,\u0027msgpack\u0027] for clarity.","commit_id":"32d4767f37c8ca28ef8e4fd13438c2823613d2e2"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"109e8fb3560d6cbe3243577aa3d0f92bba8caa65","unresolved":false,"context_lines":[{"line_number":51,"context_line":"]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"message_opts \u003d ["},{"line_number":54,"context_line":"    cfg.StrOpt(\u0027default_serializer_type\u0027, default\u003d\u0027json\u0027,"},{"line_number":55,"context_line":"               help\u003d\"Default serialization mechanism for \""},{"line_number":56,"context_line":"                    \"serializing/deserializing outgoing/incoming messages\")"},{"line_number":57,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":19,"id":"bacf61ea_635d5948","line":54,"range":{"start_line":54,"start_character":15,"end_line":54,"end_character":56},"in_reply_to":"bacf61ea_e3eca994","updated":"2016-08-02 15:04:29.000000000","message":"Done","commit_id":"32d4767f37c8ca28ef8e4fd13438c2823613d2e2"}],"oslo_messaging/_drivers/pika_driver/pika_engine.py":[{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"73304384a79ded95612c0465314d5f4ad152aa62","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        )"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        try:"},{"line_number":231,"context_line":"            mgr \u003d extension.ExtensionManager(\u0027oslo.serialization.serializers\u0027,"},{"line_number":232,"context_line":"                                             invoke_on_load\u003dTrue)"},{"line_number":233,"context_line":"        except RuntimeError:"},{"line_number":234,"context_line":"            raise pika_drv_exc.ExtensionLoadFailure("}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_42e4fadf","line":231,"updated":"2016-04-14 10:57:42.000000000","message":"it should be done once during PikaEngine initialization. Why do you do it in _create_select_poller_connection_impl?","commit_id":"5bf3b167380af99eb3d3490e82f8cdcb1ef51845"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"0f33a54dd65effebb67ce23b06ed9c0f640a5790","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        )"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        try:"},{"line_number":231,"context_line":"            mgr \u003d extension.ExtensionManager(\u0027oslo.serialization.serializers\u0027,"},{"line_number":232,"context_line":"                                             invoke_on_load\u003dTrue)"},{"line_number":233,"context_line":"        except RuntimeError:"},{"line_number":234,"context_line":"            raise pika_drv_exc.ExtensionLoadFailure("}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_fc120a56","line":231,"in_reply_to":"5a18252c_42e4fadf","updated":"2016-04-14 11:44:25.000000000","message":"It is done in the __init__ method of the PikaEngine class. May be you forgot to expand common lines :)","commit_id":"5bf3b167380af99eb3d3490e82f8cdcb1ef51845"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"2cb9027d6d7f63def0edfc87d20921da9c5ee3e3","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        )"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        try:"},{"line_number":231,"context_line":"            mgr \u003d extension.ExtensionManager(\u0027oslo.serialization.serializers\u0027,"},{"line_number":232,"context_line":"                                             invoke_on_load\u003dTrue)"},{"line_number":233,"context_line":"        except RuntimeError:"},{"line_number":234,"context_line":"            raise pika_drv_exc.ExtensionLoadFailure("}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_d25577fa","line":231,"in_reply_to":"5a18252c_fc120a56","updated":"2016-04-14 11:51:30.000000000","message":"ah, sure.","commit_id":"5bf3b167380af99eb3d3490e82f8cdcb1ef51845"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"72f2e682395c97db4f69e88585da8b1f03579883","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            \u0027application/\u0027 + conf.oslo_messaging_pika.default_serializer_type"},{"line_number":142,"context_line":"        )"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if self.default_content_type not in pika_drv_cmns.MESSAGE_SERIALIZERS:"},{"line_number":145,"context_line":"            raise ValueError(\"default_serializer_type is unknown\")"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _init_if_needed(self):"},{"line_number":148,"context_line":"        cur_pid \u003d os.getpid()"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a89bdaa_b472d1e1","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":66},"updated":"2016-09-10 09:35:09.000000000","message":"this can be removed, due to conf.oslo_messaging_pika.default_serializer_type only accepts two values:json and msgpack, other value will lead ValueError in Line 141.","commit_id":"3cb4214147a084d9e24ef3059c5f3cc6a4f67ede"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"b39dcbb62f8c26163856adb17e15acc3a26a6c02","unresolved":false,"context_lines":[{"line_number":141,"context_line":"            \u0027application/\u0027 + conf.oslo_messaging_pika.default_serializer_type"},{"line_number":142,"context_line":"        )"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        if self.default_content_type not in pika_drv_cmns.MESSAGE_SERIALIZERS:"},{"line_number":145,"context_line":"            raise ValueError(\"default_serializer_type is unknown\")"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _init_if_needed(self):"},{"line_number":148,"context_line":"        cur_pid \u003d os.getpid()"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a89bdaa_af68bc22","line":145,"range":{"start_line":144,"start_character":0,"end_line":145,"end_character":66},"in_reply_to":"9a89bdaa_b472d1e1","updated":"2016-09-10 12:29:25.000000000","message":"Yes, of course. Thank you for the remark. Done.","commit_id":"3cb4214147a084d9e24ef3059c5f3cc6a4f67ede"}],"oslo_messaging/_drivers/pika_driver/pika_exceptions.py":[{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"73304384a79ded95612c0465314d5f4ad152aa62","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    pass"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class ExtensionLoadFailure(exceptions.MessagingException):"},{"line_number":72,"context_line":"    \"\"\"Is raised when extensions can\u0027t be loaded\"\"\""},{"line_number":73,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_4d2d4b94","line":71,"updated":"2016-04-14 10:57:42.000000000","message":"It is not MessagingException. MessagingExeption raised if some problems during message delivery or processing problem. It is error on initialization stage.","commit_id":"5bf3b167380af99eb3d3490e82f8cdcb1ef51845"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"0f33a54dd65effebb67ce23b06ed9c0f640a5790","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    pass"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class ExtensionLoadFailure(exceptions.MessagingException):"},{"line_number":72,"context_line":"    \"\"\"Is raised when extensions can\u0027t be loaded\"\"\""},{"line_number":73,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_df9d800b","line":71,"in_reply_to":"5a18252c_4d2d4b94","updated":"2016-04-14 11:44:25.000000000","message":"I can\u0027t find any appropriate base class for this exception in the oslo_messaging\u0027s exceptions. May we just use RuntimeError as a base class or it is better to make some new base class for initialization exceptions?","commit_id":"5bf3b167380af99eb3d3490e82f8cdcb1ef51845"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"2cb9027d6d7f63def0edfc87d20921da9c5ee3e3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"    pass"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"class ExtensionLoadFailure(exceptions.MessagingException):"},{"line_number":72,"context_line":"    \"\"\"Is raised when extensions can\u0027t be loaded\"\"\""},{"line_number":73,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_f2dcf374","line":71,"in_reply_to":"5a18252c_df9d800b","updated":"2016-04-14 11:51:30.000000000","message":"just change base class from MessagingException to Exception. I think it would be enough for now","commit_id":"5bf3b167380af99eb3d3490e82f8cdcb1ef51845"}],"oslo_messaging/_drivers/pika_driver/pika_message.py":[{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"7de1732ff37772d929405ab937a9c514878e9a77","unresolved":false,"context_lines":[{"line_number":323,"context_line":"        self._content_encoding \u003d content_encoding"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        try:"},{"line_number":326,"context_line":"            mgr \u003d driver.DriverManager(\u0027oslo.serialization.serializers\u0027,"},{"line_number":327,"context_line":"                                       self._content_type.split(\u0027/\u0027, 1)[1],"},{"line_number":328,"context_line":"                                       invoke_on_load\u003dTrue)"},{"line_number":329,"context_line":"        except RuntimeError:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_8db995ec","line":326,"range":{"start_line":326,"start_character":25,"end_line":326,"end_character":38},"updated":"2016-04-12 14:21:38.000000000","message":"please do it during PikaEngine __init__","commit_id":"f1dd6f261eccd5cda9971b7c5184c6078c9ef21e"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"7de1732ff37772d929405ab937a9c514878e9a77","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"        try:"},{"line_number":326,"context_line":"            mgr \u003d driver.DriverManager(\u0027oslo.serialization.serializers\u0027,"},{"line_number":327,"context_line":"                                       self._content_type.split(\u0027/\u0027, 1)[1],"},{"line_number":328,"context_line":"                                       invoke_on_load\u003dTrue)"},{"line_number":329,"context_line":"        except RuntimeError:"},{"line_number":330,"context_line":"            raise NotImplementedError("}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_4d7e5de5","line":327,"range":{"start_line":327,"start_character":58,"end_line":327,"end_character":63},"updated":"2016-04-12 14:21:38.000000000","message":"we need to have dict(content_type to serializer) in pika_engine object. Does stevedore allows to get all pissible options?","commit_id":"f1dd6f261eccd5cda9971b7c5184c6078c9ef21e"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"73304384a79ded95612c0465314d5f4ad152aa62","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    \"\"\""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def __init__(self, pika_engine, message, context,"},{"line_number":305,"context_line":"                 content_type\u003d\"application/json\", content_encoding\u003d\"utf-8\"):"},{"line_number":306,"context_line":"        \"\"\"Parse RabbitMQ message"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        :param pika_engine: PikaEngine, shared object with configuration and"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_8d9c835e","line":305,"updated":"2016-04-14 10:57:42.000000000","message":"hm we forgot about content_encoding... I think we could just remove it for now. Also we need some config option to choose serialiser type for message sending","commit_id":"5bf3b167380af99eb3d3490e82f8cdcb1ef51845"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"823d7f1c46099c3c0c9981509a0be172e6b733b7","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    \"\"\""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def __init__(self, pika_engine, message, context,"},{"line_number":305,"context_line":"                 content_type\u003d\"application/json\", content_encoding\u003d\"utf-8\"):"},{"line_number":306,"context_line":"        \"\"\"Parse RabbitMQ message"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        :param pika_engine: PikaEngine, shared object with configuration and"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_6b546afe","line":305,"in_reply_to":"5a18252c_127fef15","updated":"2016-04-14 12:29:36.000000000","message":"Do you mean that we always use json now?","commit_id":"5bf3b167380af99eb3d3490e82f8cdcb1ef51845"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"0a1d2b117bfc5aa72a387bf97d5fa2deef29bff6","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    \"\"\""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def __init__(self, pika_engine, message, context,"},{"line_number":305,"context_line":"                 content_type\u003d\"application/json\", content_encoding\u003d\"utf-8\"):"},{"line_number":306,"context_line":"        \"\"\"Parse RabbitMQ message"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        :param pika_engine: PikaEngine, shared object with configuration and"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_b6efefe7","line":305,"in_reply_to":"5a18252c_6b546afe","updated":"2016-04-14 19:56:23.000000000","message":"yes","commit_id":"5bf3b167380af99eb3d3490e82f8cdcb1ef51845"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"0f33a54dd65effebb67ce23b06ed9c0f640a5790","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    \"\"\""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def __init__(self, pika_engine, message, context,"},{"line_number":305,"context_line":"                 content_type\u003d\"application/json\", content_encoding\u003d\"utf-8\"):"},{"line_number":306,"context_line":"        \"\"\"Parse RabbitMQ message"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        :param pika_engine: PikaEngine, shared object with configuration and"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_bfe084fb","line":305,"in_reply_to":"5a18252c_8d9c835e","updated":"2016-04-14 11:44:25.000000000","message":"But we can choose serializer type depending on content_type, can\u0027t we?","commit_id":"5bf3b167380af99eb3d3490e82f8cdcb1ef51845"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"2cb9027d6d7f63def0edfc87d20921da9c5ee3e3","unresolved":false,"context_lines":[{"line_number":302,"context_line":"    \"\"\""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"    def __init__(self, pika_engine, message, context,"},{"line_number":305,"context_line":"                 content_type\u003d\"application/json\", content_encoding\u003d\"utf-8\"):"},{"line_number":306,"context_line":"        \"\"\"Parse RabbitMQ message"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"        :param pika_engine: PikaEngine, shared object with configuration and"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_127fef15","line":305,"in_reply_to":"5a18252c_bfe084fb","updated":"2016-04-14 11:51:30.000000000","message":"here it is ok, but conent_type paramenter is never used now by code which call PikaOutgoingMessage.send","commit_id":"5bf3b167380af99eb3d3490e82f8cdcb1ef51845"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"73304384a79ded95612c0465314d5f4ad152aa62","unresolved":false,"context_lines":[{"line_number":320,"context_line":"        self._content_encoding \u003d content_encoding"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"        try:"},{"line_number":323,"context_line":"            serializer \u003d self._pika_engine.serializers["},{"line_number":324,"context_line":"                self._content_type"},{"line_number":325,"context_line":"            ]"},{"line_number":326,"context_line":"        except KeyError:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a18252c_adf17f03","line":323,"updated":"2016-04-14 10:57:42.000000000","message":"just self._serializer \u003d here","commit_id":"5bf3b167380af99eb3d3490e82f8cdcb1ef51845"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"52cfb91ae9a977d30136db45aaf5da09b55d017d","unresolved":false,"context_lines":[{"line_number":558,"context_line":"            Should be None if RPC request was successfully processed."},{"line_number":559,"context_line":"        :param content_type: String, content-type header, defines serialization"},{"line_number":560,"context_line":"            mechanism, if None default content-type from pika_engine is used"},{"line_number":561,"context_line":"        \"\"\""},{"line_number":562,"context_line":"        self.msg_id \u003d msg_id"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        if failure_info is not None:"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a89bdaa_64460925","line":561,"updated":"2016-09-05 03:34:27.000000000","message":"Why did we drop the encoding? (just curious)","commit_id":"3cb4214147a084d9e24ef3059c5f3cc6a4f67ede"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"8e9d30394d106d102e5f4fd6b0c78e7fc6a2480a","unresolved":false,"context_lines":[{"line_number":558,"context_line":"            Should be None if RPC request was successfully processed."},{"line_number":559,"context_line":"        :param content_type: String, content-type header, defines serialization"},{"line_number":560,"context_line":"            mechanism, if None default content-type from pika_engine is used"},{"line_number":561,"context_line":"        \"\"\""},{"line_number":562,"context_line":"        self.msg_id \u003d msg_id"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"        if failure_info is not None:"}],"source_content_type":"text/x-python","patch_set":22,"id":"9a89bdaa_c8e0e3cf","line":561,"in_reply_to":"9a89bdaa_64460925","updated":"2016-09-08 21:24:43.000000000","message":"Since after introducing the _serializer attribute, the encoding isn\u0027t used and needed anymore.","commit_id":"3cb4214147a084d9e24ef3059c5f3cc6a4f67ede"}],"setup.cfg":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"35ec153a661cb25d1f5070149aea52bd377c3772","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"oslo.serialization.serializers \u003d"},{"line_number":82,"context_line":"    json \u003d oslo_serialization.serializer.json_serializer:JSONSerializer"},{"line_number":83,"context_line":"    msgpack \u003d oslo_serialization.serializer.msgpack_serializer:MessagePackSerializer"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"[build_sphinx]"},{"line_number":86,"context_line":"source-dir \u003d doc/source"}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"dab17558_9d65fd1e","line":83,"updated":"2016-05-13 13:52:42.000000000","message":"I\u0027m not super fan of this, I known this is sexy to use stevedore to put fancy name for a long classpath (I love that too :p ).\n\nBut keep in mind that a stevedore entry_point is public API. So this add the new API to oslo.messaging by allowing people to write custom serializers.\n\nAlso you pick a section name outside of the lib, this is not a good idea. All stevedore section loaded by oslo.msg must start by oslo.messaging.\n\nHonestly, I would prefer to have this static dict that don\u0027t really need to be extended outside of the lib in the code directly.","commit_id":"37e95e4a99dfeaf471f94475555db120334c7f63"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"b0970fecfa68d2a99344b001aab3092b1f6b4686","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"oslo.serialization.serializers \u003d"},{"line_number":82,"context_line":"    json \u003d oslo_serialization.serializer.json_serializer:JSONSerializer"},{"line_number":83,"context_line":"    msgpack \u003d oslo_serialization.serializer.msgpack_serializer:MessagePackSerializer"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"[build_sphinx]"},{"line_number":86,"context_line":"source-dir \u003d doc/source"}],"source_content_type":"text/x-ttcn-cfg","patch_set":12,"id":"dab17558_efad2fea","line":83,"in_reply_to":"dab17558_9d65fd1e","updated":"2016-05-16 09:14:02.000000000","message":"Why not? If someone has better or more suitable serializers for some tasks, then it will be possible to use them via the pika driver (of course if these serializers have compatible API with the BaseSerializer from oslo.serialization).","commit_id":"37e95e4a99dfeaf471f94475555db120334c7f63"}]}