)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"40aadb52b1b65bda5074a8b2d0d31361c26a0338","unresolved":false,"context_lines":[{"line_number":16,"context_line":"connection pool doesn\u0027t have limitation for connections of this"},{"line_number":17,"context_line":"type, only for SEND purporses."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Many openstack projects like neutron want to listen many targets."},{"line_number":20,"context_line":"For example, it does in the ovs neutron agent, which has 8 targets"},{"line_number":21,"context_line":"(consumers) and for each target will be created its own RPCServer"},{"line_number":22,"context_line":"with only one endpoint - OVSNeutronAgent. Similar situation in the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a18252c_863673e5","line":19,"updated":"2016-04-13 07:20:26.000000000","message":"I don\u0027t think they are many, that looks like a neutron usage of oslo.messaging.","commit_id":"b941e0ca62dcdbf4d2521714b122da8750469ede"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"40aadb52b1b65bda5074a8b2d0d31361c26a0338","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"I think it leads to large overhead for a amqp broker if we have hundreds"},{"line_number":31,"context_line":"of compute nodes.I don\u0027t see any real reasons for creating a dedicated"},{"line_number":32,"context_line":"connection for each target."},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"So, I\u0027m reimplement the NotificationServer approach for RPCServer and"},{"line_number":35,"context_line":"want to use it at first for neutron rpc."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a18252c_0686e364","line":32,"updated":"2016-04-13 07:20:26.000000000","message":"I don\u0027t really see any reason to create many RPCServers into one process.\n\nIndeed using many targets will reduce the number of TCP connections, but it will not change the number of consumers and queues that the rabbitmq server have to handle.\n\nWhy using only one RPCservers per process will reduce both number of TCP Connection and queues/consumers to handle on server side.\n\nAdding such new API, will add a way to easy load the rabbitmq cluster. While the best usage of oslo.messaging RPC API is to creates only one RCPServer per process.\n\nSo the really question is why Neutron have to use many targets per process ? While most (I would said all other but I don\u0027t review rpc code of all applications) openstack application uses only one per process.","commit_id":"b941e0ca62dcdbf4d2521714b122da8750469ede"}]}