)]}'
{"oslo_messaging/_drivers/amqpdriver.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"70ffe80f3bf47739c3cdbbbac1908de8611453df","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        unique_id \u003d self.msg_id_cache.check_duplicate_message(message)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        LOG.debug(\"received message msg_id: %(msg_id)s reply to %(queue)s\", {"},{"line_number":201,"context_line":"            \u0027queue\u0027: ctxt.reply_q, \u0027msg_id\u0027: ctxt.msg_id})"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        self.incoming.append(AMQPIncomingMessage(self,"},{"line_number":204,"context_line":"                                                 ctxt.to_dict(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_04f17b95","side":"PARENT","line":201,"updated":"2016-04-14 07:59:04.000000000","message":"I would prefer to have a symmetry between the log here and the one in def _send(...).\n\nSo I would said that we should keep this message if ctxt.msg_id is not None and use your new message when msg_id is None.\n\nOtherwise we lost the tractability for rpc.call()","commit_id":"0b286754e22760b4589fd2a33e1ebad2318d2bce"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"57d011664802720ea8c3e2157225221d4e6d94dc","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        unique_id \u003d self.msg_id_cache.check_duplicate_message(message)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        LOG.debug(\"received message msg_id: %(msg_id)s reply to %(queue)s\", {"},{"line_number":201,"context_line":"            \u0027queue\u0027: ctxt.reply_q, \u0027msg_id\u0027: ctxt.msg_id})"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        self.incoming.append(AMQPIncomingMessage(self,"},{"line_number":204,"context_line":"                                                 ctxt.to_dict(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_de50390d","side":"PARENT","line":201,"in_reply_to":"1a122d0e_1ee8fbe1","updated":"2016-04-18 09:05:18.000000000","message":"I guess it\u0027s relic of the past. But now msg_id and unique_id are part of the wire protocol contract. That would be hard to change without breaking rolling upgrade.","commit_id":"0b286754e22760b4589fd2a33e1ebad2318d2bce"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"1e9394a1e151332dcecf77079a02c8bf49f523b6","unresolved":false,"context_lines":[{"line_number":198,"context_line":"        unique_id \u003d self.msg_id_cache.check_duplicate_message(message)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        LOG.debug(\"received message msg_id: %(msg_id)s reply to %(queue)s\", {"},{"line_number":201,"context_line":"            \u0027queue\u0027: ctxt.reply_q, \u0027msg_id\u0027: ctxt.msg_id})"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        self.incoming.append(AMQPIncomingMessage(self,"},{"line_number":204,"context_line":"                                                 ctxt.to_dict(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_1ee8fbe1","side":"PARENT","line":201,"in_reply_to":"5a18252c_04f17b95","updated":"2016-04-18 01:49:40.000000000","message":"Hi, sileht, sorry for reply lately, yes, it is my fault, will do it. btw, I have a stupid question :), why we need both an unique_id and a msg_id, it seems they both are generated when sending a message, can we use only one of them ?","commit_id":"0b286754e22760b4589fd2a33e1ebad2318d2bce"}]}