)]}'
{"oslo_messaging/_drivers/impl_kafka.py":[{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"7e0c7140cd2061cdac93ee1432fab79ab28d35e4","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        for host in self.url.hosts:"},{"line_number":104,"context_line":"            try:"},{"line_number":105,"context_line":"                self.hostaddrs.append(\"%s:%s\" % ("},{"line_number":106,"context_line":"                    host.hostname,"},{"line_number":107,"context_line":"                    host.port or driver_conf.kafka_default_port))"},{"line_number":108,"context_line":"            except (AttributeError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_33ba0dc1","line":105,"updated":"2016-04-19 09:32:02.000000000","message":"How I understand we could have a situation when host.hostname is None and add a next string to the hostaddrs \"None:9092\", isn\u0027t it? In this case we couldn\u0027t connect to the kafka I think. Maybe it will be better to skip host if it hasn\u0027t hostname? \n\nIs it possible what host will have not hostname in this code?\nI think it\u0027s redundant to catch any errors this code.","commit_id":"67677bba02af75a1bdce57f5e69e99a93114a81a"},{"author":{"_account_id":21356,"name":"Ildar Svetlov","email":"isvetlov@mirantis.com","username":"isvetlov"},"change_message_id":"8a23eaa622316be3c3923ef43026f3987ea842c9","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        for host in self.url.hosts:"},{"line_number":104,"context_line":"            try:"},{"line_number":105,"context_line":"                self.hostaddrs.append(\"%s:%s\" % ("},{"line_number":106,"context_line":"                    host.hostname,"},{"line_number":107,"context_line":"                    host.port or driver_conf.kafka_default_port))"},{"line_number":108,"context_line":"            except (AttributeError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_ce73307f","line":105,"in_reply_to":"1a122d0e_33ba0dc1","updated":"2016-04-19 09:51:16.000000000","message":"Yes, It is possible. I`ll add this fix in next patch.","commit_id":"67677bba02af75a1bdce57f5e69e99a93114a81a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"7e0c7140cd2061cdac93ee1432fab79ab28d35e4","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            self.kafka_client.ensure_topic_exists(topic)"},{"line_number":227,"context_line":"        self.consumer \u003d kafka.KafkaConsumer("},{"line_number":228,"context_line":"            *topics, group_id\u003dgroup,"},{"line_number":229,"context_line":"            bootstrap_servers\u003d[self.hostaddrs],"},{"line_number":230,"context_line":"            fetch_message_max_bytes\u003dself.fetch_messages_max_bytes)"},{"line_number":231,"context_line":"        self._consume_loop_stopped \u003d False"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_93ffa166","line":229,"updated":"2016-04-19 09:32:02.000000000","message":"Your hostaddrs is already list, i think it\u0027s not right to wrap it via another list again, it\u0027s right to use it directly how in line 217.\n\nDo you test your code on real environment?","commit_id":"67677bba02af75a1bdce57f5e69e99a93114a81a"},{"author":{"_account_id":21356,"name":"Ildar Svetlov","email":"isvetlov@mirantis.com","username":"isvetlov"},"change_message_id":"8a23eaa622316be3c3923ef43026f3987ea842c9","unresolved":false,"context_lines":[{"line_number":226,"context_line":"            self.kafka_client.ensure_topic_exists(topic)"},{"line_number":227,"context_line":"        self.consumer \u003d kafka.KafkaConsumer("},{"line_number":228,"context_line":"            *topics, group_id\u003dgroup,"},{"line_number":229,"context_line":"            bootstrap_servers\u003d[self.hostaddrs],"},{"line_number":230,"context_line":"            fetch_message_max_bytes\u003dself.fetch_messages_max_bytes)"},{"line_number":231,"context_line":"        self._consume_loop_stopped \u003d False"},{"line_number":232,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_eed70ceb","line":229,"in_reply_to":"1a122d0e_93ffa166","updated":"2016-04-19 09:51:16.000000000","message":"Done","commit_id":"67677bba02af75a1bdce57f5e69e99a93114a81a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"44211bd78c9e32810338007d480165c8fe8848b2","unresolved":false,"context_lines":[{"line_number":107,"context_line":"                    self.hostaddrs.append(\"%s:%s\" % ("},{"line_number":108,"context_line":"                        host.hostname,"},{"line_number":109,"context_line":"                        host.port or driver_conf.kafka_default_port))"},{"line_number":110,"context_line":"            except (AttributeError):"},{"line_number":111,"context_line":"                continue"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"        if not self.hostaddrs:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_718b981f","line":110,"updated":"2016-04-20 12:15:19.000000000","message":"Is it possible what attribute error will be raise here?\nI think attribute error catching is not needed here.","commit_id":"d95250e1f59d0680c7ca63ea043a14fbadd80efc"}],"oslo_messaging/tests/drivers/test_impl_kafka.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"d51ec11bc2bb91b7f14b58c330897cf654f5d73d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        (\u0027port\u0027, dict(url\u003d\u0027kafka://localhost:1234\u0027,"},{"line_number":66,"context_line":"                      expected\u003d[dict(hostaddrs\u003d[\u0027localhost:1234\u0027])])),"},{"line_number":67,"context_line":"        (\u0027two\u0027, dict(url\u003d\u0027kafka://localhost:1234,localhost2:1234\u0027,"},{"line_number":68,"context_line":"                     expected\u003d[dict(hostaddrs\u003d[\u0027localhost:1234\u0027,"},{"line_number":69,"context_line":"                                               \u0027localhost2:1234\u0027])])),"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_d43b499a","line":68,"updated":"2016-05-17 16:18:49.000000000","message":"why do we use expected variable as `list` if it only has only one `dict` inclusion. We could simplify to `dict` only.","commit_id":"d982ab18d8e661a053da76641bd065cbd60854f6"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"a142c71007cb4d3a66c94d19ba822b5b1ab319d2","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        driver \u003d transport._driver"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        conn \u003d driver._get_connection(kafka_driver.PURPOSE_SEND)"},{"line_number":83,"context_line":"        self.assertEqual(self.expected[0][\u0027hostaddrs\u0027], conn.hostaddrs)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class TestKafkaDriver(test_utils.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bab6814e_e3ae3184","line":83,"range":{"start_line":83,"start_character":38,"end_line":83,"end_character":41},"updated":"2016-05-19 08:01:12.000000000","message":"Ever since you\u0027ve changed `expected` to dict type, getting by index has become redundant.","commit_id":"fbfb8edf80eac1b726d45f5d5a9fed6677ac9d80"}]}