)]}'
{"oslo_messaging/notify/listener.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ebcae1b6013487b420fa4f87f2d1775ab3f0cd8","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        except Exception:"},{"line_number":153,"context_line":"            LOG.exception(_LE(\u0027Exception during handling message: %s:\u0027),"},{"line_number":154,"context_line":"                          message)"},{"line_number":155,"context_line":"            res \u003d notify_dispatcher.NotificationResult.REQUEUE"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"        try:"},{"line_number":158,"context_line":"            if (res \u003d\u003d notify_dispatcher.NotificationResult.REQUEUE and"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_600cc942","line":155,"range":{"start_line":155,"start_character":12,"end_line":155,"end_character":62},"updated":"2016-04-24 00:16:50.000000000","message":"this greatly change previous behavior, not sure if it is ok to mix in this patch","commit_id":"c1f88fab9ff43e46a45fe4a25574361687270cb2"}],"oslo_messaging/rpc/server.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ebcae1b6013487b420fa4f87f2d1775ab3f0cd8","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        try:"},{"line_number":126,"context_line":"            message.acknowledge()"},{"line_number":127,"context_line":"        except Exception:"},{"line_number":128,"context_line":"            LOG.exception(\"Can not acknowledge message: %s. Skip processing\","},{"line_number":129,"context_line":"                          message)"},{"line_number":130,"context_line":"            return"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_e030d909","line":128,"range":{"start_line":128,"start_character":26,"end_line":128,"end_character":76},"updated":"2016-04-24 00:16:50.000000000","message":"_LE","commit_id":"c1f88fab9ff43e46a45fe4a25574361687270cb2"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"6b1fc22a6809a74b71d95105e20025d36b05c1b6","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        try:"},{"line_number":126,"context_line":"            message.acknowledge()"},{"line_number":127,"context_line":"        except Exception:"},{"line_number":128,"context_line":"            LOG.exception(\"Can not acknowledge message: %s. Skip processing\","},{"line_number":129,"context_line":"                          message)"},{"line_number":130,"context_line":"            return"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_dfa5b704","line":128,"range":{"start_line":128,"start_character":26,"end_line":128,"end_character":76},"in_reply_to":"1a122d0e_e030d909","updated":"2016-04-24 04:35:03.000000000","message":"Done","commit_id":"c1f88fab9ff43e46a45fe4a25574361687270cb2"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ebcae1b6013487b420fa4f87f2d1775ab3f0cd8","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            else:"},{"line_number":151,"context_line":"                message.reply(failure\u003dfailure)"},{"line_number":152,"context_line":"        except Exception:"},{"line_number":153,"context_line":"            LOG.exception(\"Can not send reply for message %s\", message)"},{"line_number":154,"context_line":"        finally:"},{"line_number":155,"context_line":"                # NOTE(dhellmann): Remove circular object reference"},{"line_number":156,"context_line":"                # between the current stack frame and the traceback in"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_2012d162","line":153,"range":{"start_line":153,"start_character":26,"end_line":153,"end_character":61},"updated":"2016-04-24 00:16:50.000000000","message":"_LE","commit_id":"c1f88fab9ff43e46a45fe4a25574361687270cb2"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"6b1fc22a6809a74b71d95105e20025d36b05c1b6","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            else:"},{"line_number":151,"context_line":"                message.reply(failure\u003dfailure)"},{"line_number":152,"context_line":"        except Exception:"},{"line_number":153,"context_line":"            LOG.exception(\"Can not send reply for message %s\", message)"},{"line_number":154,"context_line":"        finally:"},{"line_number":155,"context_line":"                # NOTE(dhellmann): Remove circular object reference"},{"line_number":156,"context_line":"                # between the current stack frame and the traceback in"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_bf5a7b28","line":153,"range":{"start_line":153,"start_character":26,"end_line":153,"end_character":61},"in_reply_to":"1a122d0e_2012d162","updated":"2016-04-24 04:35:03.000000000","message":"Done","commit_id":"c1f88fab9ff43e46a45fe4a25574361687270cb2"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"2ebcae1b6013487b420fa4f87f2d1775ab3f0cd8","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                message.reply(failure\u003dfailure)"},{"line_number":152,"context_line":"        except Exception:"},{"line_number":153,"context_line":"            LOG.exception(\"Can not send reply for message %s\", message)"},{"line_number":154,"context_line":"        finally:"},{"line_number":155,"context_line":"                # NOTE(dhellmann): Remove circular object reference"},{"line_number":156,"context_line":"                # between the current stack frame and the traceback in"},{"line_number":157,"context_line":"                # exc_info."},{"line_number":158,"context_line":"                del failure"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"def get_rpc_server(transport, target, endpoints,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_e0173952","line":158,"range":{"start_line":154,"start_character":8,"end_line":158,"end_character":27},"updated":"2016-04-24 00:16:50.000000000","message":"no need to delete a local var","commit_id":"c1f88fab9ff43e46a45fe4a25574361687270cb2"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"6b1fc22a6809a74b71d95105e20025d36b05c1b6","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                message.reply(failure\u003dfailure)"},{"line_number":152,"context_line":"        except Exception:"},{"line_number":153,"context_line":"            LOG.exception(\"Can not send reply for message %s\", message)"},{"line_number":154,"context_line":"        finally:"},{"line_number":155,"context_line":"                # NOTE(dhellmann): Remove circular object reference"},{"line_number":156,"context_line":"                # between the current stack frame and the traceback in"},{"line_number":157,"context_line":"                # exc_info."},{"line_number":158,"context_line":"                del failure"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"def get_rpc_server(transport, target, endpoints,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_9f9b3fc9","line":158,"range":{"start_line":154,"start_character":8,"end_line":158,"end_character":27},"in_reply_to":"1a122d0e_e0173952","updated":"2016-04-24 04:35:03.000000000","message":"I just kept previous behavior. As far as I understood it is not necessary but removing circular reference makes easier garbage collection at least","commit_id":"c1f88fab9ff43e46a45fe4a25574361687270cb2"}]}