)]}'
{"oslo_messaging/rpc/client.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"380aa4201d1cae8d3d31097853abc5a29b8de8cd","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        if self.timeout is None:"},{"line_number":151,"context_line":"            timeout \u003d self.conf.rpc_response_timeout"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        version \u003d msg.get(\u0027version\u0027)"},{"line_number":154,"context_line":"        if self.version_cap and version:"},{"line_number":155,"context_line":"            self._check_version_cap(version)"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_82c38dec","line":153,"updated":"2016-05-10 14:06:31.000000000","message":"If self.version_cap is set we have to check the version.\n\nAnd if the version is None, we have to raise RPCVersionCapError() because we can\u0027t known if this is safe or not to send the msg.\n\nSo for me only utils.version_is_compatible() needs to be fixed to return False when version is None.","commit_id":"18f42c12c73ce0fd43c3de473f0cc0783505abe5"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"6ca0eaea659aca44422379f31a52369af8d3ca20","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        if self.timeout is None:"},{"line_number":151,"context_line":"            timeout \u003d self.conf.rpc_response_timeout"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        version \u003d msg.get(\u0027version\u0027)"},{"line_number":154,"context_line":"        if self.version_cap and version:"},{"line_number":155,"context_line":"            self._check_version_cap(version)"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_a39172f3","line":153,"in_reply_to":"dab17558_82c38dec","updated":"2016-05-10 15:03:01.000000000","message":"Done. Also I think adding the case when imp_version is None in utils.version_is_compatible will simplify the code a little bit, because it will allow us to eliminate all checks whether version_cap is None.","commit_id":"18f42c12c73ce0fd43c3de473f0cc0783505abe5"}]}