)]}'
{"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":19520,"name":"Kirill Bespalov","email":"kbespalov@mirantis.com","username":"k.bespalov"},"change_message_id":"df32a2dcc3c92758a05198421666be24348c1d99","unresolved":false,"context_lines":[{"line_number":878,"context_line":"                    # pass floating-point numbers here"},{"line_number":879,"context_line":"                    sock.setsockopt(socket.IPPROTO_TCP,"},{"line_number":880,"context_line":"                                    TCP_USER_TIMEOUT,"},{"line_number":881,"context_line":"                                    str(timeout))"},{"line_number":882,"context_line":"                except socket.error as error:"},{"line_number":883,"context_line":"                    code \u003d error[0]"},{"line_number":884,"context_line":"                    # TCP_USER_TIMEOUT not defined on kernels \u003c2.6.37"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_6e7994fc","line":881,"range":{"start_line":881,"start_character":35,"end_line":881,"end_character":49},"updated":"2016-05-07 09:43:21.000000000","message":"TCP_USER_TIMEOUT allows only integer values, not float.\nSee linux docs here:\nhttp://man7.org/linux/man-pages/man7/tcp.7.html","commit_id":"51b1d4e453bea53b20ee7001f7e6fcd3cd4fe9c4"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"980f94ee37d28ee0721a3dccbada7f4d1d65565d","unresolved":false,"context_lines":[{"line_number":878,"context_line":"                    # pass floating-point numbers here"},{"line_number":879,"context_line":"                    sock.setsockopt(socket.IPPROTO_TCP,"},{"line_number":880,"context_line":"                                    TCP_USER_TIMEOUT,"},{"line_number":881,"context_line":"                                    str(timeout))"},{"line_number":882,"context_line":"                except socket.error as error:"},{"line_number":883,"context_line":"                    code \u003d error[0]"},{"line_number":884,"context_line":"                    # TCP_USER_TIMEOUT not defined on kernels \u003c2.6.37"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_4a429c3f","line":881,"range":{"start_line":881,"start_character":35,"end_line":881,"end_character":49},"in_reply_to":"dab17558_29102501","updated":"2016-05-09 12:56:00.000000000","message":"If float are not allowed then we have to always ceil/round-up to ensure we do not break the connection before the expect timeout. If this is str or int, I prefer to see int here. Because other code already expected float and int, not str.","commit_id":"51b1d4e453bea53b20ee7001f7e6fcd3cd4fe9c4"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"17e1e16daaa34dbeed0290580ef362aa545700d9","unresolved":false,"context_lines":[{"line_number":878,"context_line":"                    # pass floating-point numbers here"},{"line_number":879,"context_line":"                    sock.setsockopt(socket.IPPROTO_TCP,"},{"line_number":880,"context_line":"                                    TCP_USER_TIMEOUT,"},{"line_number":881,"context_line":"                                    str(timeout))"},{"line_number":882,"context_line":"                except socket.error as error:"},{"line_number":883,"context_line":"                    code \u003d error[0]"},{"line_number":884,"context_line":"                    # TCP_USER_TIMEOUT not defined on kernels \u003c2.6.37"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_af47a775","line":881,"range":{"start_line":881,"start_character":35,"end_line":881,"end_character":49},"in_reply_to":"dab17558_4a429c3f","updated":"2016-05-10 09:48:18.000000000","message":"Done","commit_id":"51b1d4e453bea53b20ee7001f7e6fcd3cd4fe9c4"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"7c9b01e8974c60cef7792b65fc70f78e08ca175f","unresolved":false,"context_lines":[{"line_number":878,"context_line":"                    # pass floating-point numbers here"},{"line_number":879,"context_line":"                    sock.setsockopt(socket.IPPROTO_TCP,"},{"line_number":880,"context_line":"                                    TCP_USER_TIMEOUT,"},{"line_number":881,"context_line":"                                    str(timeout))"},{"line_number":882,"context_line":"                except socket.error as error:"},{"line_number":883,"context_line":"                    code \u003d error[0]"},{"line_number":884,"context_line":"                    # TCP_USER_TIMEOUT not defined on kernels \u003c2.6.37"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_29102501","line":881,"range":{"start_line":881,"start_character":35,"end_line":881,"end_character":49},"in_reply_to":"dab17558_6e7994fc","updated":"2016-05-07 13:45:23.000000000","message":"I mean that setsockopt method allows only integers and strings as options\u0027 values. I think that then each option handles its values individually, so in the case of TCP_USER_TIMEOUT I guess that fractional parts of timeouts are just ignored. But I agree that your comment is worth noticing here.","commit_id":"51b1d4e453bea53b20ee7001f7e6fcd3cd4fe9c4"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"299c8de3cd25aa3f8e97774313e63ecfda2e8281","unresolved":false,"context_lines":[{"line_number":878,"context_line":"                    # can take only integer values"},{"line_number":879,"context_line":"                    sock.setsockopt(socket.IPPROTO_TCP,"},{"line_number":880,"context_line":"                                    TCP_USER_TIMEOUT,"},{"line_number":881,"context_line":"                                    int(timeout))"},{"line_number":882,"context_line":"                except socket.error as error:"},{"line_number":883,"context_line":"                    code \u003d error[0]"},{"line_number":884,"context_line":"                    # TCP_USER_TIMEOUT not defined on kernels \u003c2.6.37"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_aa77c89d","line":881,"updated":"2016-05-09 12:56:22.000000000","message":"See my comment on previous patchset.","commit_id":"ead2e91e8905fb33412cd7fac8bbc11952d4b6fb"}]}
