)]}'
{"oslo_messaging/_drivers/common.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"bb0f04f69ea0cc9a120bcf1b4e13dff69b5faff7","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    failure \u003d failure_info[1]"},{"line_number":174,"context_line":"    if log_failure:"},{"line_number":175,"context_line":"        if isinstance(failure, rpc_dispatcher.ExpectedException):"},{"line_number":176,"context_line":"            LOG.warning(_LE(\"Returning expected exception %s to caller\"),"},{"line_number":177,"context_line":"                        six.text_type(failure))"},{"line_number":178,"context_line":"            LOG.warning(tb)"},{"line_number":179,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_970cbf43","line":176,"updated":"2016-05-13 12:50:57.000000000","message":"_LW ?","commit_id":"dbf338819649d6ee0ef4618034462268bc4fb4ea"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"77f5635c53ac529334a3aa2f9b0674e0a5e3fa50","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    failure \u003d failure_info[1]"},{"line_number":174,"context_line":"    if log_failure:"},{"line_number":175,"context_line":"        if isinstance(failure, rpc_dispatcher.ExpectedException):"},{"line_number":176,"context_line":"            LOG.warning(_LE(\"Returning expected exception %s to caller\"),"},{"line_number":177,"context_line":"                        six.text_type(failure))"},{"line_number":178,"context_line":"            LOG.warning(tb)"},{"line_number":179,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_575096d4","line":176,"in_reply_to":"dab17558_970cbf43","updated":"2016-05-13 12:55:10.000000000","message":"Done","commit_id":"dbf338819649d6ee0ef4618034462268bc4fb4ea"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"df48e3fa31f47556138561aceae5945ea1d8781a","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    \"\"\""},{"line_number":172,"context_line":"    failure \u003d failure_info[1]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    if log_failure:"},{"line_number":175,"context_line":"        if isinstance(failure, rpc_dispatcher.ExpectedException):"},{"line_number":176,"context_line":"            LOG.debug(_(\"Returning expected exception to caller: %s\"),"},{"line_number":177,"context_line":"                      six.text_type(failure), exc_info\u003dfailure_info)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dab17558_66d5a11a","line":174,"range":{"start_line":174,"start_character":4,"end_line":174,"end_character":6},"updated":"2016-05-17 12:21:06.000000000","message":"Log exceptions with pretty formatted tracebacks instead of tracebacks in the form of raw python lists.","commit_id":"bc8555c701d1245dddadefd25abbb481101b4091"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"b890f99c5eae40263ea90a2430dc3b182fd471a4","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    \"\"\""},{"line_number":172,"context_line":"    failure \u003d failure_info[1]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    if log_failure:"},{"line_number":175,"context_line":"        if isinstance(failure, rpc_dispatcher.ExpectedException):"},{"line_number":176,"context_line":"            LOG.debug(\"Returning expected exception to caller: %s\","},{"line_number":177,"context_line":"                      six.text_type(failure), exc_info\u003dfailure_info)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_7031a5ec","line":174,"updated":"2016-05-18 08:09:53.000000000","message":"I prefer to remove this logging at all because we already log this exception in RPCServer:\nhttps://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/rpc/server.py#L135","commit_id":"2ad73ddefd1691c16149cff12acf192a8ff8a365"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7030660b6d90c9fb7993b7b6f38277ec9b6e676b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    \"\"\""},{"line_number":172,"context_line":"    failure \u003d failure_info[1]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    if log_failure:"},{"line_number":175,"context_line":"        if isinstance(failure, rpc_dispatcher.ExpectedException):"},{"line_number":176,"context_line":"            LOG.debug(\"Returning expected exception to caller: %s\","},{"line_number":177,"context_line":"                      six.text_type(failure), exc_info\u003dfailure_info)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_d07851fb","line":174,"in_reply_to":"bab6814e_7031a5ec","updated":"2016-05-18 08:26:53.000000000","message":"At first sight log_failure is never used and the exception always printed. \n\nNotificationListener already log all exceptions correctly too: https://github.com/openstack/oslo.messaging/blob/master/oslo_messaging/notify/listener.py#L153.\n\nRemove all of this log_failure stuff make sense to me.\n\nThx for the cleanup.","commit_id":"2ad73ddefd1691c16149cff12acf192a8ff8a365"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"0a3bbad71ab0f0c405731925cfeae978686f4a55","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    \"\"\""},{"line_number":172,"context_line":"    failure \u003d failure_info[1]"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    if log_failure:"},{"line_number":175,"context_line":"        if isinstance(failure, rpc_dispatcher.ExpectedException):"},{"line_number":176,"context_line":"            LOG.debug(\"Returning expected exception to caller: %s\","},{"line_number":177,"context_line":"                      six.text_type(failure), exc_info\u003dfailure_info)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_5caf5ae3","line":174,"in_reply_to":"bab6814e_d07851fb","updated":"2016-05-18 09:10:54.000000000","message":"I thought that removing logging and therefore log_failure argument would break the public API. But now I see that serialize_remote_exception with explicit log_failure\u003dFalse is used only here: http://git.openstack.org/cgit/openstack/nova/tree/nova/cells/messaging.py (lines 1840 and 1871), but even in this case an identical local copy of serialize_remote_exception is used.\nSo I will remove all these loggings.","commit_id":"2ad73ddefd1691c16149cff12acf192a8ff8a365"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"122b70ff7d22df3ce8f52a3c59722ea69eb335e0","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from oslo_messaging._i18n import _"},{"line_number":29,"context_line":"from oslo_messaging._i18n import _LE"},{"line_number":30,"context_line":"from oslo_messaging import _utils as utils"},{"line_number":31,"context_line":"from oslo_messaging.rpc import dispatcher as rpc_dispatcher"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_8e7cda21","line":31,"updated":"2016-05-18 13:18:01.000000000","message":"why we need rpc_dispatcher here?","commit_id":"680f262d63e0b8dd62a9466ea8e06b268e412d69"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"4fad52b61baa35ca4bcbfc5e9095985af788cddf","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from oslo_messaging._i18n import _"},{"line_number":29,"context_line":"from oslo_messaging._i18n import _LE"},{"line_number":30,"context_line":"from oslo_messaging import _utils as utils"},{"line_number":31,"context_line":"from oslo_messaging.rpc import dispatcher as rpc_dispatcher"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_acc1e782","line":31,"in_reply_to":"bab6814e_8e7cda21","updated":"2016-05-18 13:23:11.000000000","message":"We don\u0027t need it anymore. Fixed in Patch Set 12.","commit_id":"680f262d63e0b8dd62a9466ea8e06b268e412d69"}],"oslo_messaging/notify/listener.py":[{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"b54ef6661a7194b6f236525dd886be63013b23de","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        except Exception as e:"},{"line_number":174,"context_line":"            not_processed_messages \u003d set(incoming)"},{"line_number":175,"context_line":"            LOG.exception(_LE(\u0027Exception during message handling: %s.\u0027),"},{"line_number":176,"context_line":"                          six.text_type(e), exc_info\u003dTrue)"},{"line_number":177,"context_line":"        for m in incoming:"},{"line_number":178,"context_line":"            try:"},{"line_number":179,"context_line":"                if m in not_processed_messages and self._allow_requeue:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_825b1154","line":176,"range":{"start_line":176,"start_character":30,"end_line":176,"end_character":39},"updated":"2016-05-18 12:34:10.000000000","message":"It is not needed to add exception message  in log string. LOG.exception writes all exception info itself","commit_id":"5054f3fe15e03608d8cc5a796fb4fd3d7ec6aa4b"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"122b70ff7d22df3ce8f52a3c59722ea69eb335e0","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        except Exception:"},{"line_number":153,"context_line":"            LOG.exception(_LE(\u0027Exception during message handling.\u0027))"},{"line_number":154,"context_line":"            res \u003d notify_dispatcher.NotificationResult.REQUEUE"},{"line_number":155,"context_line":"        try:"},{"line_number":156,"context_line":"            if (res \u003d\u003d notify_dispatcher.NotificationResult.REQUEUE and"},{"line_number":157,"context_line":"                    self._allow_requeue):"},{"line_number":158,"context_line":"                message.requeue()"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_4e35d244","line":155,"updated":"2016-05-18 13:18:01.000000000","message":"some not necessary change","commit_id":"680f262d63e0b8dd62a9466ea8e06b268e412d69"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"4fad52b61baa35ca4bcbfc5e9095985af788cddf","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        except Exception:"},{"line_number":153,"context_line":"            LOG.exception(_LE(\u0027Exception during message handling.\u0027))"},{"line_number":154,"context_line":"            res \u003d notify_dispatcher.NotificationResult.REQUEUE"},{"line_number":155,"context_line":"        try:"},{"line_number":156,"context_line":"            if (res \u003d\u003d notify_dispatcher.NotificationResult.REQUEUE and"},{"line_number":157,"context_line":"                    self._allow_requeue):"},{"line_number":158,"context_line":"                message.requeue()"}],"source_content_type":"text/x-python","patch_set":11,"id":"bab6814e_0cc91379","line":155,"in_reply_to":"bab6814e_4e35d244","updated":"2016-05-18 13:23:11.000000000","message":"Reverted in Patch Set 13.","commit_id":"680f262d63e0b8dd62a9466ea8e06b268e412d69"}],"oslo_messaging/rpc/server.py":[{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"b54ef6661a7194b6f236525dd886be63013b23de","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        except rpc_dispatcher.ExpectedException as e:"},{"line_number":136,"context_line":"            failure \u003d e.exc_info"},{"line_number":137,"context_line":"            LOG.debug(u\u0027Expected exception during message handling: %s\u0027,"},{"line_number":138,"context_line":"                      six.text_type(e), exc_info\u003dfailure)"},{"line_number":139,"context_line":"        except Exception as e:"},{"line_number":140,"context_line":"            # current sys.exc_info() content can be overriden"},{"line_number":141,"context_line":"            # by another exception raise by a log handler during"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_dd033ab7","line":138,"range":{"start_line":138,"start_character":26,"end_line":138,"end_character":35},"updated":"2016-05-18 12:34:10.000000000","message":"here it is not heeded to use six.text_type, it is executing during exception to string formatting (because you use \u0027%s\u0027)\n\nexc_info parameter adds trace printing. I\u0027m not sure that it is desired for expected exception, but for DEBUG level it is ok","commit_id":"5054f3fe15e03608d8cc5a796fb4fd3d7ec6aa4b"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"b54ef6661a7194b6f236525dd886be63013b23de","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            # current sys.exc_info() content can be overriden"},{"line_number":141,"context_line":"            # by another exception raise by a log handler during"},{"line_number":142,"context_line":"            # LOG.exception(). So keep a copy and delete it later."},{"line_number":143,"context_line":"            failure \u003d sys.exc_info()"},{"line_number":144,"context_line":"            LOG.exception(_LE(\u0027Exception during message handling: %s\u0027),"},{"line_number":145,"context_line":"                          six.text_type(e), exc_info\u003dfailure)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_fd16fea5","line":143,"range":{"start_line":143,"start_character":26,"end_line":143,"end_character":34},"updated":"2016-05-18 12:34:10.000000000","message":"prabably it is possible to use e.exc_info[1] instead of sys.exc_info()","commit_id":"5054f3fe15e03608d8cc5a796fb4fd3d7ec6aa4b"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"fb0e7555df2986f02ad47ac5fa77f5c3d577d093","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            # current sys.exc_info() content can be overriden"},{"line_number":141,"context_line":"            # by another exception raise by a log handler during"},{"line_number":142,"context_line":"            # LOG.exception(). So keep a copy and delete it later."},{"line_number":143,"context_line":"            failure \u003d sys.exc_info()"},{"line_number":144,"context_line":"            LOG.exception(_LE(\u0027Exception during message handling: %s\u0027),"},{"line_number":145,"context_line":"                          six.text_type(e), exc_info\u003dfailure)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_ee62c6ac","line":143,"range":{"start_line":143,"start_character":26,"end_line":143,"end_character":34},"in_reply_to":"bab6814e_b3e4a53b","updated":"2016-05-18 13:08:22.000000000","message":"right","commit_id":"5054f3fe15e03608d8cc5a796fb4fd3d7ec6aa4b"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"9a8cb3df9b16fe568aa96ff2aa98859fc553cf4e","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            # current sys.exc_info() content can be overriden"},{"line_number":141,"context_line":"            # by another exception raise by a log handler during"},{"line_number":142,"context_line":"            # LOG.exception(). So keep a copy and delete it later."},{"line_number":143,"context_line":"            failure \u003d sys.exc_info()"},{"line_number":144,"context_line":"            LOG.exception(_LE(\u0027Exception during message handling: %s\u0027),"},{"line_number":145,"context_line":"                          six.text_type(e), exc_info\u003dfailure)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_b3e4a53b","line":143,"range":{"start_line":143,"start_character":26,"end_line":143,"end_character":34},"in_reply_to":"bab6814e_fd16fea5","updated":"2016-05-18 12:59:46.000000000","message":"I guess it is not possible, because only instances of ExpectedException have exc_info attribute.","commit_id":"5054f3fe15e03608d8cc5a796fb4fd3d7ec6aa4b"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"b54ef6661a7194b6f236525dd886be63013b23de","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            # LOG.exception(). So keep a copy and delete it later."},{"line_number":143,"context_line":"            failure \u003d sys.exc_info()"},{"line_number":144,"context_line":"            LOG.exception(_LE(\u0027Exception during message handling: %s\u0027),"},{"line_number":145,"context_line":"                          six.text_type(e), exc_info\u003dfailure)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        try:"},{"line_number":148,"context_line":"            if failure is None:"}],"source_content_type":"text/x-python","patch_set":8,"id":"bab6814e_1dc78213","line":145,"updated":"2016-05-18 12:34:10.000000000","message":"again, it is not needed to change LOG.exception","commit_id":"5054f3fe15e03608d8cc5a796fb4fd3d7ec6aa4b"}]}
