)]}'
{"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"460ce22606866a686cdcd953e76f1a9e6283aff7","unresolved":false,"context_lines":[{"line_number":884,"context_line":"                timeout \u003d min(heartbeat_timeout, timeout)"},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"        # NOTE(bogdando) will always unblock socket, if timeout is missing"},{"line_number":887,"context_line":"        timeout \u003d 0 if timeout is None"},{"line_number":888,"context_line":""},{"line_number":889,"context_line":"        try:"},{"line_number":890,"context_line":"            sock \u003d self.channel.connection.sock"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_6b684888","line":887,"updated":"2016-05-19 12:39:39.000000000","message":"this is an expression - you need to provide the else part","commit_id":"fe96316bbbe5ec57a01acc22e318d489d3aee6ce"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"51e2df9c071828920e330e413f9473039ec444b2","unresolved":false,"context_lines":[{"line_number":884,"context_line":"                timeout \u003d min(heartbeat_timeout, timeout)"},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"        # NOTE(bogdando) will always unblock socket, if timeout is missing"},{"line_number":887,"context_line":"        if timeout is None:"},{"line_number":888,"context_line":"            timeout \u003d 0"},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_73c036e1","line":887,"updated":"2016-05-19 14:28:15.000000000","message":"This if can be elif because when heartbeat is enabled this case is already handled.","commit_id":"02125f5886294efdc451d6d49dbb959fd6bbae42"},{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"3f21dbc2e0991a7c5ab6e00b04256d90afc7d051","unresolved":false,"context_lines":[{"line_number":884,"context_line":"                timeout \u003d min(heartbeat_timeout, timeout)"},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"        # NOTE(bogdando) will always unblock socket, if timeout is missing"},{"line_number":887,"context_line":"        if timeout is None:"},{"line_number":888,"context_line":"            timeout \u003d 0"},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_61897d26","line":887,"in_reply_to":"bab6814e_73c036e1","updated":"2016-05-19 15:37:56.000000000","message":"indeed, I missed that","commit_id":"02125f5886294efdc451d6d49dbb959fd6bbae42"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"51e2df9c071828920e330e413f9473039ec444b2","unresolved":false,"context_lines":[{"line_number":897,"context_line":"            # TCP_USER_TIMEOUT is not defined on Windows and Mac OS X"},{"line_number":898,"context_line":"            if sys.platform !\u003d \u0027win32\u0027 and sys.platform !\u003d \u0027darwin\u0027:"},{"line_number":899,"context_line":"                try:"},{"line_number":900,"context_line":"                    timeout \u003d timeout * 1000 if timeout is not None else 0"},{"line_number":901,"context_line":"                    # NOTE(gdavoian): only integers and strings are allowed"},{"line_number":902,"context_line":"                    # as socket options\u0027 values, and TCP_USER_TIMEOUT option"},{"line_number":903,"context_line":"                    # can take only integer values, so we round-up the timeout"}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_33e22ea0","line":900,"updated":"2016-05-19 14:28:15.000000000","message":"This if/else is now redondant\n\ntimeout *\u003d 1000 is enought now","commit_id":"02125f5886294efdc451d6d49dbb959fd6bbae42"},{"author":{"_account_id":8601,"name":"Dmitriy Ukhlov","email":"dukhlov@mirantis.com","username":"dukhlov"},"change_message_id":"cac2d5a5dad6db8f527b8ceaf9d4be968387078e","unresolved":false,"context_lines":[{"line_number":893,"context_line":"            # Level is set to debug because otherwise we would spam the logs"},{"line_number":894,"context_line":"            LOG.debug(\u0027Failed to get socket attribute: %s\u0027 % str(e))"},{"line_number":895,"context_line":"        else:"},{"line_number":896,"context_line":"            sock.settimeout(timeout)"},{"line_number":897,"context_line":"            # TCP_USER_TIMEOUT is not defined on Windows and Mac OS X"},{"line_number":898,"context_line":"            if sys.platform !\u003d \u0027win32\u0027 and sys.platform !\u003d \u0027darwin\u0027:"},{"line_number":899,"context_line":"                try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_9f279163","line":896,"range":{"start_line":896,"start_character":17,"end_line":896,"end_character":27},"updated":"2016-05-19 18:12:26.000000000","message":"Are you sure that you want to set unblocking mode for socket? It will change behavior. Previously send call sent N bytes to socket and raised timeout exception in case of any problem. Now send call is nonblocking, it just stores to outbound buffer bytes and if this buffer is full returns number of stored bytes. Therefore some bytes may be just lost without any exception. Nonblocking sockets require async interaction style (select/poll/epoll calls). Am I missing something?","commit_id":"1330d3a1741d422068544b84d82b55b8eadc5a38"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"889899358ca8433d9e5496bbcd7f723a821058ef","unresolved":false,"context_lines":[{"line_number":897,"context_line":"            # TCP_USER_TIMEOUT is not defined on Windows and Mac OS X"},{"line_number":898,"context_line":"            if sys.platform !\u003d \u0027win32\u0027 and sys.platform !\u003d \u0027darwin\u0027:"},{"line_number":899,"context_line":"                try:"},{"line_number":900,"context_line":"                    timeout \u003d timeout * 1000 if timeout is not None else 0"},{"line_number":901,"context_line":"                    # NOTE(gdavoian): only integers and strings are allowed"},{"line_number":902,"context_line":"                    # as socket options\u0027 values, and TCP_USER_TIMEOUT option"},{"line_number":903,"context_line":"                    # can take only integer values, so we round-up the timeout"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_9a5b262e","line":900,"range":{"start_line":900,"start_character":45,"end_line":900,"end_character":74},"updated":"2016-05-19 16:17:16.000000000","message":"nit: still useless","commit_id":"1330d3a1741d422068544b84d82b55b8eadc5a38"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"69b9619111df064030e07073f59e157531e5fd6c","unresolved":false,"context_lines":[{"line_number":885,"context_line":""},{"line_number":886,"context_line":"        # NOTE(bogdando) will always use timeout mode for a socket"},{"line_number":887,"context_line":"        elif timeout is None:"},{"line_number":888,"context_line":"            timeout \u003d TCP_USER_TIMEOUT"},{"line_number":889,"context_line":""},{"line_number":890,"context_line":"        try:"},{"line_number":891,"context_line":"            sock \u003d self.channel.connection.sock"}],"source_content_type":"text/x-python","patch_set":6,"id":"bab6814e_4cce1eb5","line":888,"updated":"2016-05-19 21:23:29.000000000","message":"the timeout in this case should be zero or None, but not 18s (TCP_USER_TIMEOUT is a constant with value 18 nothing else)\n\nif zero produces 100% cpu issue, this should stay None.\n\nAnyways I don\u0027t think we should care about non heartbeat setup anymore, because this kind of setup is broken by design. The only working workaround when heartbeat is not enabled is to tune tcp_keepalive_XXX values.","commit_id":"88303d7bb3f59eba51ece07c7f07a7220b22f4d6"}]}
