)]}'
{"oslo_messaging/_drivers/zmq_driver/broker/zmq_queue_proxy.py":[{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"b83c518bbd5fa1f834907a8abd66bcb5bdd802c9","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self.matchmaker.unregister_router(self.be_router_address)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class RouterUpdater(object):"},{"line_number":118,"context_line":"    \"\"\"This entity performs periodic async updates"},{"line_number":119,"context_line":"    from router proxy to the matchmaker."},{"line_number":120,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_162fc488","line":117,"range":{"start_line":117,"start_character":20,"end_line":117,"end_character":26},"updated":"2016-06-08 11:46:28.000000000","message":"I think we can inherit RouterUpdater from UpdaterBase.","commit_id":"87e63f04e1aee6ac163a3fe5c9eaa7d9bb6e58d1"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"49363fc7e8058a84e6d379d741e85a919e63dd76","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self.matchmaker.unregister_router(self.be_router_address)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"class RouterUpdater(object):"},{"line_number":118,"context_line":"    \"\"\"This entity performs periodic async updates"},{"line_number":119,"context_line":"    from router proxy to the matchmaker."},{"line_number":120,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_0a6cb3cc","line":117,"range":{"start_line":117,"start_character":20,"end_line":117,"end_character":26},"in_reply_to":"7aa08908_162fc488","updated":"2016-06-08 12:36:45.000000000","message":"Done","commit_id":"87e63f04e1aee6ac163a3fe5c9eaa7d9bb6e58d1"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"b83c518bbd5fa1f834907a8abd66bcb5bdd802c9","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.fe_router_address \u003d fe_router_address"},{"line_number":128,"context_line":"        self.be_router_address \u003d be_router_address"},{"line_number":129,"context_line":"        self.executor \u003d zmq_async.get_executor(method\u003dself._update_records,"},{"line_number":130,"context_line":"                                               zmq_concurrency\u003d\u0027native\u0027)"},{"line_number":131,"context_line":"        self.executor.execute()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def _update_records(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_9c9ab86c","line":130,"range":{"start_line":130,"start_character":47,"end_line":130,"end_character":62},"updated":"2016-06-08 11:46:28.000000000","message":"zmq_concurrency argument doesn\u0027t exist anymore","commit_id":"87e63f04e1aee6ac163a3fe5c9eaa7d9bb6e58d1"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"49363fc7e8058a84e6d379d741e85a919e63dd76","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.fe_router_address \u003d fe_router_address"},{"line_number":128,"context_line":"        self.be_router_address \u003d be_router_address"},{"line_number":129,"context_line":"        self.executor \u003d zmq_async.get_executor(method\u003dself._update_records,"},{"line_number":130,"context_line":"                                               zmq_concurrency\u003d\u0027native\u0027)"},{"line_number":131,"context_line":"        self.executor.execute()"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def _update_records(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_caa46b09","line":130,"range":{"start_line":130,"start_character":47,"end_line":130,"end_character":62},"in_reply_to":"7aa08908_9c9ab86c","updated":"2016-06-08 12:36:45.000000000","message":"Done","commit_id":"87e63f04e1aee6ac163a3fe5c9eaa7d9bb6e58d1"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"3a20dc1cb3cbf8b2031cb650dc3b9fb9867f3eaf","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def __init__(self, conf, matchmaker, publisher_address, fe_router_address,"},{"line_number":123,"context_line":"                 be_router_address):"},{"line_number":124,"context_line":"        super(RouterUpdater, self).__init__(conf, matchmaker,"},{"line_number":125,"context_line":"                                            self._update_records)"},{"line_number":126,"context_line":"        self.publisher_address \u003d publisher_address"},{"line_number":127,"context_line":"        self.fe_router_address \u003d fe_router_address"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_ebcfa953","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":61},"updated":"2016-06-08 13:17:53.000000000","message":"There is a little problem here. We have to create additional child\u0027s attributes (publisher_address, fe_router_address and be_router_address) first, and only then call parent\u0027s constructor, since parent\u0027s executor may start calling _update_records at once. For example, this code gives me an AttributeError: \u0027RouterUpdater\u0027 object has no attribute \u0027publisher_address\u0027.","commit_id":"19ab7f72434e57bea71e477f97bc27b2e00ac5ae"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"e8568f665518f84a4b2ecd0438ed40e008d9b63e","unresolved":false,"context_lines":[{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def __init__(self, conf, matchmaker, publisher_address, fe_router_address,"},{"line_number":123,"context_line":"                 be_router_address):"},{"line_number":124,"context_line":"        super(RouterUpdater, self).__init__(conf, matchmaker,"},{"line_number":125,"context_line":"                                            self._update_records)"},{"line_number":126,"context_line":"        self.publisher_address \u003d publisher_address"},{"line_number":127,"context_line":"        self.fe_router_address \u003d fe_router_address"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_2b8ed1cf","line":124,"range":{"start_line":124,"start_character":0,"end_line":124,"end_character":61},"in_reply_to":"7aa08908_ebcfa953","updated":"2016-06-08 13:22:41.000000000","message":"Done","commit_id":"19ab7f72434e57bea71e477f97bc27b2e00ac5ae"}]}
