)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"54e62c09fc8123a68efd92529f043f85501d5ad3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ilya Tyaptin \u003cityaptin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-23 14:49:27 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PoC of new kafka-python with KafkaProducer"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I29862ed7bf56b9d8878fa8e9fb1cbd9d643908a4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3aaa91ec_4eef4187","line":7,"updated":"2016-06-23 12:03:34.000000000","message":"Your change already deals the consumer side, doesn\u0027t it?","commit_id":"da16ba9100a04624a79dacdd85e5c694a8d5b409"}],"oslo_messaging/_drivers/impl_kafka.py":[{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"54e62c09fc8123a68efd92529f043f85501d5ad3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        # https://github.com/eventlet/eventlet/blob/master/eventlet/green/selectors.py#L32"},{"line_number":23,"context_line":"        kafka.selectors34.SelectSelector._select \u003d staticmethod("},{"line_number":24,"context_line":"            eventlet.green.select.select)"},{"line_number":25,"context_line":"        # eventlet \u003c\u003d 1.9.0 does not remove select.poll, so we manually"},{"line_number":26,"context_line":"        # DefaultSelector to SelectSelector"},{"line_number":27,"context_line":"        # see https://github.com/eventlet/eventlet/pull/317"},{"line_number":28,"context_line":"        kafka.selectors34.DefaultSelector \u003d kafka.selectors34.SelectSelector"}],"source_content_type":"text/x-python","patch_set":2,"id":"3aaa91ec_6e5cbded","line":25,"updated":"2016-06-23 12:03:34.000000000","message":"s/manually/manually set/","commit_id":"da16ba9100a04624a79dacdd85e5c694a8d5b409"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"109e35e6654254c78161757940a5f49e9f9cde76","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"        # make SelectSelector._select a staticmethod as done in eventlet itself"},{"line_number":22,"context_line":"        # https://github.com/eventlet/eventlet/blob/master/eventlet/green/selectors.py#L32"},{"line_number":23,"context_line":"        kafka.selectors34.SelectSelector._select \u003d staticmethod("},{"line_number":24,"context_line":"            eventlet.green.select.select)"},{"line_number":25,"context_line":"        # eventlet \u003c\u003d 1.9.0 does not remove select.poll, so we manually"},{"line_number":26,"context_line":"        # DefaultSelector to SelectSelector"}],"source_content_type":"text/x-python","patch_set":4,"id":"3aaa91ec_c9404ba8","line":23,"updated":"2016-06-23 12:16:44.000000000","message":"We cannot monkey patch private method.","commit_id":"259310b9b2884ef61c6e7c7a47461fb07dab40ec"},{"author":{"_account_id":19300,"name":"Eric Lemoine","email":"elemoine@mirantis.com","username":"elemoine"},"change_message_id":"da88c1b8d9a5c2c2b22a4e4ed6c03d06ab54e479","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    cfg.IntOpt(\u0027pool_size\u0027, default\u003d10,"},{"line_number":88,"context_line":"               help\u003d\u0027Pool Size for Kafka driver\u0027),"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    cfg.StrOpt(\u0027consumer_group\u0027, default\u003duuid.uuid4().hex,"},{"line_number":91,"context_line":"               help\u003d\u0027Group id for Kafka consumer. Consumers in one group \u0027"},{"line_number":92,"context_line":"                    \u0027will coordinate message consumption\u0027)"},{"line_number":93,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_eb0bbf7b","line":90,"updated":"2016-06-28 08:00:03.000000000","message":"Minor, but I\u0027d change the option name to \"consumer_group_id\", to be as close as possible to the KafkaConsumer API.\n\nFor the default value why using a random UUID? Why not using something like \"oslo-messaging-default-group\"? Using a fixed string may ease debugging, and I don\u0027t see the reason for using a random string. FWIW kafka-python uses \"kafka-python-default-group\" as the default value.","commit_id":"e119bdaf07b3dcc3c6dce42a0558c6e9642a252a"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3311e4e29ba530260bdd103ac954348c3dc9d95a","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        for target, priority in targets_and_priorities:"},{"line_number":369,"context_line":"            topics.add(target_to_topic(target, priority))"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"        conn.declare_topic_consumer(topics, pool)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"        listener \u003d KafkaListener(conn)"},{"line_number":374,"context_line":"        return base.PollStyleListenerAdapter(listener, batch_size,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9a89bdaa_64d57be3","side":"PARENT","line":371,"range":{"start_line":371,"start_character":44,"end_line":371,"end_character":48},"updated":"2016-09-13 16:10:03.000000000","message":"Why is pool suppressed ? We should use that as group_id and fallback to consumer_group if not provided.","commit_id":"09fa0447778defb35d367c604fa862bb12ca8b29"}],"test-requirements.txt":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3311e4e29ba530260bdd103ac954348c3dc9d95a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"pyzmq\u003e\u003d14.3.1 # LGPL+BSD"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"# for test_impl_kafka"},{"line_number":24,"context_line":"kafka-python\u003e\u003d1.0.0,\u003c\u003d1.2.2 # Apache-2.0"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# when we can require tox\u003e\u003d 1.4, this can go into tox.ini:"},{"line_number":27,"context_line":"#  [testenv:cover]"}],"source_content_type":"text/plain","patch_set":11,"id":"9a89bdaa_e4ac2ba1","line":24,"updated":"2016-09-13 16:10:03.000000000","message":"Why a new upper bound ? Are we writing already outdated code :p","commit_id":"dcf58f80d43ab115f1fd8b888c65caee52165cb0"}],"tox.ini":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"97c9e7ddfaa13491f9f9a187d9ac09358590c036","unresolved":false,"context_lines":[{"line_number":58,"context_line":"setenv \u003d"},{"line_number":59,"context_line":"    {[testenv]setenv}"},{"line_number":60,"context_line":"    TRANSPORT_DRIVER\u003dkafka"},{"line_number":61,"context_line":"    kafka-python\u003e\u003d1.3.1"},{"line_number":62,"context_line":"commands \u003d {toxinidir}/setup-test-env-kafka.sh python setup.py testr --slowest --testr-args\u003d\u0027{posargs:oslo_messaging.tests.functional}\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"[testenv:py27-func-amqp1]"}],"source_content_type":"text/x-properties","patch_set":19,"id":"ba5201f7_15f367d7","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":23},"updated":"2017-01-04 11:00:02.000000000","message":"better with lower version which satisfies your requirements.","commit_id":"f139eb258db12c10d921560db132263a7cf25b61"}]}
