)]}'
{"oslo_messaging/_drivers/impl_zmq.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"098479655fb694e5ad7d6ba4f7f1ac67637354a2","unresolved":false,"context_lines":[{"line_number":102,"context_line":"               help\u003d\u0027Number of retries to find free port number before \u0027"},{"line_number":103,"context_line":"                    \u0027fail with ZMQBindError.\u0027),"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    cfg.StrOpt(\u0027rpc_zmq_serialization\u0027, default\u003d\u0027json\u0027,"},{"line_number":106,"context_line":"               help\u003d\u0027Default serialization mechanism for \u0027"},{"line_number":107,"context_line":"                    \u0027serializing/deserializing outgoing/incoming messages\u0027)"},{"line_number":108,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_193625e6","line":105,"updated":"2016-07-05 16:25:40.000000000","message":"you could use ``choices`` keyword argument here to document (and check a runtime) allowed values of this option: http://docs.openstack.org/developer/oslo.config/opts.html#oslo_config.cfg.StrOpt","commit_id":"8b037e96125e5ef3e8e872e5dcca0a1d00c28c74"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"aeccb22e057132564718fd18079e72291bb2ca96","unresolved":false,"context_lines":[{"line_number":102,"context_line":"               help\u003d\u0027Number of retries to find free port number before \u0027"},{"line_number":103,"context_line":"                    \u0027fail with ZMQBindError.\u0027),"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    cfg.StrOpt(\u0027rpc_zmq_serialization\u0027, default\u003d\u0027json\u0027,"},{"line_number":106,"context_line":"               help\u003d\u0027Default serialization mechanism for \u0027"},{"line_number":107,"context_line":"                    \u0027serializing/deserializing outgoing/incoming messages\u0027)"},{"line_number":108,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1aa78d24_625fb2e5","line":105,"in_reply_to":"1aa78d24_193625e6","updated":"2016-07-05 17:26:33.000000000","message":"Done","commit_id":"8b037e96125e5ef3e8e872e5dcca0a1d00c28c74"}],"oslo_messaging/_drivers/zmq_driver/zmq_socket.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"543cc54adcf58b0eca38c84e10f3eb4ac0a5fc86","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            self.connect(address)"},{"line_number":138,"context_line":"        except zmq.ZMQError as e:"},{"line_number":139,"context_line":"            errmsg \u003d _LE(\"Failed connecting %(stype)s to %(address)s: %(e)s\") \\"},{"line_number":140,"context_line":"                % dict(stype\u003dstype, address\u003daddress, e\u003de)"},{"line_number":141,"context_line":"            LOG.error(_LE(\"Failed connecting %(stype)s to %(address)s: %(e)s\"),"},{"line_number":142,"context_line":"                      dict(stype\u003dstype, address\u003daddress, e\u003de))"},{"line_number":143,"context_line":"            raise rpc_common.RPCException(errmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_6e2dc2fd","line":140,"updated":"2016-07-06 07:28:26.000000000","message":"We can use {}-braced notation as we do 5 lines above for consistency","commit_id":"9addc3b479245a03f69a84d0585798d12797d071"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"95659774107c09a344e36d46e24d6ff21ba7c15a","unresolved":false,"context_lines":[{"line_number":137,"context_line":"            self.connect(address)"},{"line_number":138,"context_line":"        except zmq.ZMQError as e:"},{"line_number":139,"context_line":"            errmsg \u003d _LE(\"Failed connecting %(stype)s to %(address)s: %(e)s\") \\"},{"line_number":140,"context_line":"                % dict(stype\u003dstype, address\u003daddress, e\u003de)"},{"line_number":141,"context_line":"            LOG.error(_LE(\"Failed connecting %(stype)s to %(address)s: %(e)s\"),"},{"line_number":142,"context_line":"                      dict(stype\u003dstype, address\u003daddress, e\u003de))"},{"line_number":143,"context_line":"            raise rpc_common.RPCException(errmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_c9e67014","line":140,"in_reply_to":"1aa78d24_6e2dc2fd","updated":"2016-07-06 07:40:31.000000000","message":"Done","commit_id":"9addc3b479245a03f69a84d0585798d12797d071"}],"oslo_messaging/tests/drivers/zmq/test_pub_sub.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"859be34cc6b5dfd3fd0454f7b06f7e4da3bbee2d","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(TestPubSub, self).setUp()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        kwargs \u003d {\u0027use_pub_sub\u0027: True}"},{"line_number":38,"context_line":"        self.config(**kwargs)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.publisher \u003d zmq_pub_publisher.PubPublisherProxy("}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_b29b6d17","side":"PARENT","line":37,"updated":"2016-07-06 16:20:58.000000000","message":"Q: should the tests also test the non-default msgpack serializer also?\n\n(not a -1, just curious)","commit_id":"5a6592b4540f085ce3c5953716d57a7b785c894c"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"cf98d064f122d65e4eb9520db7d2912b3158c6a0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    def setUp(self):"},{"line_number":35,"context_line":"        super(TestPubSub, self).setUp()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        kwargs \u003d {\u0027use_pub_sub\u0027: True}"},{"line_number":38,"context_line":"        self.config(**kwargs)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.publisher \u003d zmq_pub_publisher.PubPublisherProxy("}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_0eaaf918","side":"PARENT","line":37,"in_reply_to":"1aa78d24_b29b6d17","updated":"2016-07-07 08:40:47.000000000","message":"Yes, I agree. Done.","commit_id":"5a6592b4540f085ce3c5953716d57a7b785c894c"}]}