)]}'
{"oslo_messaging/_drivers/zmq_driver/zmq_socket.py":[{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"eeb47f9b5048da5da7a0dd02d6fc9bba133e97df","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        # NOTE(ozamiatin): Not using send_string until"},{"line_number":90,"context_line":"        # eventlet zmq support this convenience method"},{"line_number":91,"context_line":"        # in thread-safe manner"},{"line_number":92,"context_line":"        self.handle.send(six.b(value), *args, **kwargs)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def send_json(self, *args, **kwargs):"},{"line_number":95,"context_line":"        self.handle.send_json(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_7e66f151","line":92,"range":{"start_line":92,"start_character":28,"end_line":92,"end_character":29},"updated":"2016-08-30 08:13:44.000000000","message":"As I know, six.b does nothing in PY2, but in PY3 it uses latin-1 encoding. So I suggest to do here something similar to recv_string, i.e. manually encode value using utf-8.","commit_id":"68669484bf03a87b396478d4d957614b8911883a"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"473ae7966835e7fdc29bdbc9c4a61924c36fe415","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        # NOTE(ozamiatin): Not using send_string until"},{"line_number":90,"context_line":"        # eventlet zmq support this convenience method"},{"line_number":91,"context_line":"        # in thread-safe manner"},{"line_number":92,"context_line":"        self.handle.send(six.b(value), *args, **kwargs)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def send_json(self, *args, **kwargs):"},{"line_number":95,"context_line":"        self.handle.send_json(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_b97ed367","line":92,"range":{"start_line":92,"start_character":28,"end_line":92,"end_character":29},"in_reply_to":"fa7ab95a_7e66f151","updated":"2016-08-30 08:18:36.000000000","message":"The latin-1 is used because we are converting to raw bytes and there is no encoding there (because we are sending bytes not characters the encoding doesn\u0027t matter). In recv_string we have to decode string out of received bytes so we use utf-8 in py3.","commit_id":"68669484bf03a87b396478d4d957614b8911883a"}]}
