)]}'
{"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":19520,"name":"Kirill Bespalov","email":"kbespalov@mirantis.com","username":"k.bespalov"},"change_message_id":"0605d79ba0a067253f5721dbb60d860316317e63","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            # bugs.launchpad.net/oslo.messaging/+bug/1581148"},{"line_number":333,"context_line":"            # bugs.launchpad.net/oslo.messaging/+bug/1609766"},{"line_number":334,"context_line":"            # bugs.launchpad.net/neutron/+bug/1318721"},{"line_number":335,"context_line":"            if exc.code \u003d\u003d 404:"},{"line_number":336,"context_line":"                self.declare(conn)"},{"line_number":337,"context_line":"                self.queue.consume(callback\u003dself._callback,"},{"line_number":338,"context_line":"                                   consumer_tag\u003dsix.text_type(tag),"},{"line_number":339,"context_line":"                                   nowait\u003dself.nowait)"},{"line_number":340,"context_line":"            else:"},{"line_number":341,"context_line":"                raise"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_351a646f","line":339,"range":{"start_line":335,"start_character":0,"end_line":339,"end_character":54},"updated":"2016-09-09 12:10:35.000000000","message":"You should reset here all consumers tags:\n\n ...\n if exc.code \u003d\u003d 404\n   self.declare(conn)\n   self.queue.consume(....)\n   conn._new_tags \u003d set(conn._consumers.values())\n   conn._new_tags.remove(tag)\n\n \n\nBecause at any channel error, the RabbitMQ closes \na channel and all consumers with it and then the amqp lib \nquietly reopen the channel and raise exception (e.g. 404). \n\nI prepare the demo here:\n\nhttps://gist.github.com/kbespalov/381679ea6e0ed8757b8e9802c1af90e9\n\nJust run simulator.py --url  rabbit://guest:guest@localhost rpc-server and then check consumers in rabbitmqctl.","commit_id":"221482c9e8aaaae51f230e4ec15bd68fbc5c53b3"},{"author":{"_account_id":19520,"name":"Kirill Bespalov","email":"kbespalov@mirantis.com","username":"k.bespalov"},"change_message_id":"5e61321b5bde3f81cda922713910ce1a3e4680f4","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            # bugs.launchpad.net/oslo.messaging/+bug/1581148"},{"line_number":333,"context_line":"            # bugs.launchpad.net/oslo.messaging/+bug/1609766"},{"line_number":334,"context_line":"            # bugs.launchpad.net/neutron/+bug/1318721"},{"line_number":335,"context_line":"            if exc.code \u003d\u003d 404:"},{"line_number":336,"context_line":"                self.declare(conn)"},{"line_number":337,"context_line":"                self.queue.consume(callback\u003dself._callback,"},{"line_number":338,"context_line":"                                   consumer_tag\u003dsix.text_type(tag),"},{"line_number":339,"context_line":"                                   nowait\u003dself.nowait)"},{"line_number":340,"context_line":"            else:"},{"line_number":341,"context_line":"                raise"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_fc9ee452","line":339,"range":{"start_line":335,"start_character":0,"end_line":339,"end_character":54},"in_reply_to":"9a89bdaa_1331f3ec","updated":"2016-09-12 08:34:49.000000000","message":"Both of patches fixes the bug (on condition that you will add tags cleanup on channel error), but your approach seems better for me. \n\nSo, let\u0027s just fix it :) I have already been abandoned my patch.","commit_id":"221482c9e8aaaae51f230e4ec15bd68fbc5c53b3"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7fe70ff051670e2698c0fa905cf87a1d615aa5be","unresolved":false,"context_lines":[{"line_number":332,"context_line":"            # bugs.launchpad.net/oslo.messaging/+bug/1581148"},{"line_number":333,"context_line":"            # bugs.launchpad.net/oslo.messaging/+bug/1609766"},{"line_number":334,"context_line":"            # bugs.launchpad.net/neutron/+bug/1318721"},{"line_number":335,"context_line":"            if exc.code \u003d\u003d 404:"},{"line_number":336,"context_line":"                self.declare(conn)"},{"line_number":337,"context_line":"                self.queue.consume(callback\u003dself._callback,"},{"line_number":338,"context_line":"                                   consumer_tag\u003dsix.text_type(tag),"},{"line_number":339,"context_line":"                                   nowait\u003dself.nowait)"},{"line_number":340,"context_line":"            else:"},{"line_number":341,"context_line":"                raise"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a89bdaa_1331f3ec","line":339,"range":{"start_line":335,"start_character":0,"end_line":339,"end_character":54},"in_reply_to":"9a89bdaa_351a646f","updated":"2016-09-09 13:53:45.000000000","message":"So I would say your fix is better than mine, no ?","commit_id":"221482c9e8aaaae51f230e4ec15bd68fbc5c53b3"}]}
