)]}'
{"oslo_messaging/_drivers/zmq_driver/poller/threading_poller.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"a3922a1c1d9b923fd55431f2ffb1931308eba289","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            self.sockets_and_recv_methods.pop(socket_handle, None)"},{"line_number":44,"context_line":"        if socket_and_recv_method:"},{"line_number":45,"context_line":"            LOG.debug(\"Unregistering socket %s\", socket_handle.identity)"},{"line_number":46,"context_line":"            self.poller.unregister(socket_handle)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def poll(self, timeout\u003dNone):"},{"line_number":49,"context_line":"        if timeout is not None and timeout \u003e 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_c2ca096e","line":46,"updated":"2016-09-06 19:35:57.000000000","message":"Is it possible to register the handle in register() above (line 38) if recv_method is None?  If so, might this unregister be skipped (a leak)?","commit_id":"3aa59828f91ff07b51891518ec1d715762e297d4"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"ac21930153adb6d2f04b16ae78a9df0a244e45da","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            self.sockets_and_recv_methods.pop(socket_handle, None)"},{"line_number":44,"context_line":"        if socket_and_recv_method:"},{"line_number":45,"context_line":"            LOG.debug(\"Unregistering socket %s\", socket_handle.identity)"},{"line_number":46,"context_line":"            self.poller.unregister(socket_handle)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def poll(self, timeout\u003dNone):"},{"line_number":49,"context_line":"        if timeout is not None and timeout \u003e 0:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a89bdaa_fb95dd86","line":46,"in_reply_to":"9a89bdaa_c2ca096e","updated":"2016-09-07 08:54:42.000000000","message":"Yes, it is possible and allowed, since if a socket is ready for reading, then we can always use recv_multipart on it in order to obtain a message (our current default case; line 65). So if the socket is registered, then it has to be unregistered, and I am not sure how we can skip this and why we have to skip.","commit_id":"3aa59828f91ff07b51891518ec1d715762e297d4"}]}
