)]}'
{"oslo_messaging/_drivers/zmq_driver/server/consumers/zmq_dealer_consumer.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"0a6b605d857e49df112f464adc1500fa59055fe2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"class DealerConsumer(zmq_consumer_base.SingleSocketConsumer):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def __init__(self, conf, poller, server):"},{"line_number":41,"context_line":"        self.ack_sender \u003d zmq_senders.AckSenderProxy(conf)"},{"line_number":42,"context_line":"        self.reply_sender \u003d zmq_senders.ReplySenderProxy(conf)"},{"line_number":43,"context_line":"        self.messages_cache \u003d zmq_ttl_cache.TTLCache("},{"line_number":44,"context_line":"            ttl\u003dconf.oslo_messaging_zmq.rpc_message_ttl"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_30341bdd","line":41,"updated":"2016-09-20 10:13:35.000000000","message":"Should we check the same for ack_sender?","commit_id":"b41642fda659127934f3a95fdcf5019af3f27e69"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"c06f9c790aeae792e64239fdf8950ec2c030e31c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"class DealerConsumer(zmq_consumer_base.SingleSocketConsumer):"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def __init__(self, conf, poller, server):"},{"line_number":41,"context_line":"        self.ack_sender \u003d zmq_senders.AckSenderProxy(conf)"},{"line_number":42,"context_line":"        self.reply_sender \u003d zmq_senders.ReplySenderProxy(conf)"},{"line_number":43,"context_line":"        self.messages_cache \u003d zmq_ttl_cache.TTLCache("},{"line_number":44,"context_line":"            ttl\u003dconf.oslo_messaging_zmq.rpc_message_ttl"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a8ec9b2_30bedbff","line":41,"in_reply_to":"7a8ec9b2_30341bdd","updated":"2016-09-20 10:22:08.000000000","message":"Yes, agree. Done.","commit_id":"b41642fda659127934f3a95fdcf5019af3f27e69"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"4e440ed75299109f35d89e2362fd32dc67c34436","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            raise rpc_common.RPCException(str(e))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @staticmethod"},{"line_number":69,"context_line":"    def _receive_request(socket):"},{"line_number":70,"context_line":"        empty \u003d socket.recv()"},{"line_number":71,"context_line":"        assert empty \u003d\u003d b\u0027\u0027, \u0027Bad format: empty delimiter expected\u0027"},{"line_number":72,"context_line":"        reply_id \u003d socket.recv()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a8bc5a2_426e1d30","line":69,"updated":"2016-09-23 13:12:03.000000000","message":"I\u0027d move this to a receive_message method, so we don\u0027t pass all the received data over a return statement.","commit_id":"554968ddc3ba42773749921ee1416d867bffe8ec"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"94faa4473595c6df3c6159c9fdeca22a12bd5e0f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            raise rpc_common.RPCException(str(e))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @staticmethod"},{"line_number":69,"context_line":"    def _receive_request(socket):"},{"line_number":70,"context_line":"        empty \u003d socket.recv()"},{"line_number":71,"context_line":"        assert empty \u003d\u003d b\u0027\u0027, \u0027Bad format: empty delimiter expected\u0027"},{"line_number":72,"context_line":"        reply_id \u003d socket.recv()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a8bc5a2_d1667928","line":69,"in_reply_to":"5a8bc5a2_426e1d30","updated":"2016-09-23 14:31:43.000000000","message":"Done","commit_id":"554968ddc3ba42773749921ee1416d867bffe8ec"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"4e440ed75299109f35d89e2362fd32dc67c34436","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"            message \u003d self._create_message(context, message, reply_id,"},{"line_number":109,"context_line":"                                           message_id, socket, message_type)"},{"line_number":110,"context_line":"            if message is None:"},{"line_number":111,"context_line":"                return None"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"            LOG.debug(\"[%(host)s] Received %(msg_type)s message %(msg_id)s\","}],"source_content_type":"text/x-python","patch_set":9,"id":"5a8bc5a2_a2f8c14a","line":110,"updated":"2016-09-23 13:12:03.000000000","message":"Can we remove this check?","commit_id":"554968ddc3ba42773749921ee1416d867bffe8ec"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"94faa4473595c6df3c6159c9fdeca22a12bd5e0f","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"            message \u003d self._create_message(context, message, reply_id,"},{"line_number":109,"context_line":"                                           message_id, socket, message_type)"},{"line_number":110,"context_line":"            if message is None:"},{"line_number":111,"context_line":"                return None"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"            LOG.debug(\"[%(host)s] Received %(msg_type)s message %(msg_id)s\","}],"source_content_type":"text/x-python","patch_set":9,"id":"5a8bc5a2_b163ad19","line":110,"in_reply_to":"5a8bc5a2_a2f8c14a","updated":"2016-09-23 14:31:43.000000000","message":"Done","commit_id":"554968ddc3ba42773749921ee1416d867bffe8ec"}],"oslo_messaging/_drivers/zmq_driver/server/consumers/zmq_router_consumer.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"4e440ed75299109f35d89e2362fd32dc67c34436","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        LOG.info(_LI(\"[%s] Run ROUTER consumer\"), self.host)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @staticmethod"},{"line_number":40,"context_line":"    def _receive_request(socket):"},{"line_number":41,"context_line":"        reply_id \u003d socket.recv()"},{"line_number":42,"context_line":"        empty \u003d socket.recv()"},{"line_number":43,"context_line":"        assert empty \u003d\u003d b\u0027\u0027, \u0027Bad format: empty delimiter expected\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a8bc5a2_22baf16e","line":40,"updated":"2016-09-23 13:12:03.000000000","message":"Can we please also move this to receive_message and get rid of _receive_request?","commit_id":"554968ddc3ba42773749921ee1416d867bffe8ec"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"94faa4473595c6df3c6159c9fdeca22a12bd5e0f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        LOG.info(_LI(\"[%s] Run ROUTER consumer\"), self.host)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @staticmethod"},{"line_number":40,"context_line":"    def _receive_request(socket):"},{"line_number":41,"context_line":"        reply_id \u003d socket.recv()"},{"line_number":42,"context_line":"        empty \u003d socket.recv()"},{"line_number":43,"context_line":"        assert empty \u003d\u003d b\u0027\u0027, \u0027Bad format: empty delimiter expected\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a8bc5a2_b14acd81","line":40,"in_reply_to":"5a8bc5a2_22baf16e","updated":"2016-09-23 14:31:43.000000000","message":"Done","commit_id":"554968ddc3ba42773749921ee1416d867bffe8ec"}]}