)]}'
{"oslo_messaging/_drivers/zmq_driver/proxy/central/zmq_central_proxy.py":[{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"5c4263dd82289736e4c327a0e30f3d8177aa10be","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        if message is None:"},{"line_number":70,"context_line":"            return"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        msg_type \u003d int(message[zmq_names.MESSAGE_TYPE_IDX])"},{"line_number":73,"context_line":"        if self.conf.oslo_messaging_zmq.use_pub_sub and \\"},{"line_number":74,"context_line":"                msg_type in (zmq_names.CAST_FANOUT_TYPE,"},{"line_number":75,"context_line":"                             zmq_names.NOTIFY_TYPE):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_c5d31737","line":72,"range":{"start_line":72,"start_character":8,"end_line":72,"end_character":16},"updated":"2016-09-23 13:29:45.000000000","message":"I suggest moving this type conversion to _receive_message, since run method is not protected against incorrect incoming messages. A single malformed message can break the proxy now.","commit_id":"d4626e945a8380c67b80e707bdc67f4c6fe56107"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"5c4263dd82289736e4c327a0e30f3d8177aa10be","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    @check_message_format"},{"line_number":92,"context_line":"    def _receive_message(socket):"},{"line_number":93,"context_line":"        message \u003d socket.recv_multipart()"},{"line_number":94,"context_line":"        assert len(message) \u003e zmq_names.ROUTING_KEY_IDX, \"Not enough parts\""},{"line_number":95,"context_line":"        assert message[zmq_names.REPLY_ID_IDX] is not None, \"Valid id expected\""},{"line_number":96,"context_line":"        assert message[zmq_names.EMPTY_IDX] \u003d\u003d b\u0027\u0027, \"Empty delimiter expected\""},{"line_number":97,"context_line":"        return message"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_c54dd773","line":94,"range":{"start_line":94,"start_character":40,"end_line":94,"end_character":55},"updated":"2016-09-23 13:29:45.000000000","message":"Actually len(message) must be even greater than zmq_names.MESSAGE_ID_IDX.","commit_id":"d4626e945a8380c67b80e707bdc67f4c6fe56107"}],"oslo_messaging/_drivers/zmq_driver/proxy/zmq_sender.py":[{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"5b609d1cbea73c884932de3d778194f72125732f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        topic_filter \u003d multipart_message[zmq_names.ROUTING_KEY_IDX]"},{"line_number":62,"context_line":"        reply_id \u003d multipart_message[zmq_names.REPLY_ID_IDX]"},{"line_number":63,"context_line":"        message_id \u003d multipart_message[zmq_names.MESSAGE_ID_IDX]"},{"line_number":64,"context_line":"        assert reply_id is not None, \"Reply id expected!\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        socket.send(topic_filter, zmq.SNDMORE)"},{"line_number":67,"context_line":"        socket.send_multipart(multipart_message[zmq_names.MESSAGE_ID_IDX:])"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_5c743dfc","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":14},"updated":"2016-09-23 14:53:38.000000000","message":"Checks of this kind seem to be useless. And there a lot of them in the driver :(","commit_id":"fdfc3807c6a443066344196cd8b93ff10421000b"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"304b87c8f5f568605fa5dc3bc0e371dc0db2909a","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        topic_filter \u003d multipart_message[zmq_names.ROUTING_KEY_IDX]"},{"line_number":62,"context_line":"        reply_id \u003d multipart_message[zmq_names.REPLY_ID_IDX]"},{"line_number":63,"context_line":"        message_id \u003d multipart_message[zmq_names.MESSAGE_ID_IDX]"},{"line_number":64,"context_line":"        assert reply_id is not None, \"Reply id expected!\""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        socket.send(topic_filter, zmq.SNDMORE)"},{"line_number":67,"context_line":"        socket.send_multipart(multipart_message[zmq_names.MESSAGE_ID_IDX:])"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_24757d97","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":14},"in_reply_to":"5a8bc5a2_5c743dfc","updated":"2016-09-24 07:24:53.000000000","message":"Done","commit_id":"fdfc3807c6a443066344196cd8b93ff10421000b"}],"oslo_messaging/_drivers/zmq_driver/zmq_names.py":[{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"5b609d1cbea73c884932de3d778194f72125732f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"MESSAGE_TYPES \u003d REQUEST_TYPES + (REPLY_TYPE, ACK_TYPE)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"MULTISEND_TYPES \u003d (CAST_FANOUT_TYPE, NOTIFY_TYPE)"},{"line_number":49,"context_line":"DIRECT_TYPES \u003d (CALL_TYPE, CAST_TYPE, REPLY_TYPE)"},{"line_number":50,"context_line":"CAST_TYPES \u003d (CAST_TYPE, CAST_FANOUT_TYPE)"},{"line_number":51,"context_line":"NOTIFY_TYPES \u003d (NOTIFY_TYPE,)"},{"line_number":52,"context_line":"NON_BLOCKING_TYPES \u003d CAST_TYPES + NOTIFY_TYPES"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_bc3c61e3","line":49,"range":{"start_line":49,"start_character":48,"end_line":49,"end_character":49},"updated":"2016-09-23 14:53:38.000000000","message":"ACK_TYPE should be also added here. I think we can define a new type of messages in addition to REQUEST_TYPES, e.g. RESPONSE_TYPES \u003d (REPLY_TYPE, ACK_TYPE).","commit_id":"fdfc3807c6a443066344196cd8b93ff10421000b"},{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"304b87c8f5f568605fa5dc3bc0e371dc0db2909a","unresolved":false,"context_lines":[{"line_number":46,"context_line":"MESSAGE_TYPES \u003d REQUEST_TYPES + (REPLY_TYPE, ACK_TYPE)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"MULTISEND_TYPES \u003d (CAST_FANOUT_TYPE, NOTIFY_TYPE)"},{"line_number":49,"context_line":"DIRECT_TYPES \u003d (CALL_TYPE, CAST_TYPE, REPLY_TYPE)"},{"line_number":50,"context_line":"CAST_TYPES \u003d (CAST_TYPE, CAST_FANOUT_TYPE)"},{"line_number":51,"context_line":"NOTIFY_TYPES \u003d (NOTIFY_TYPE,)"},{"line_number":52,"context_line":"NON_BLOCKING_TYPES \u003d CAST_TYPES + NOTIFY_TYPES"}],"source_content_type":"text/x-python","patch_set":8,"id":"5a8bc5a2_0448815a","line":49,"range":{"start_line":49,"start_character":48,"end_line":49,"end_character":49},"in_reply_to":"5a8bc5a2_bc3c61e3","updated":"2016-09-24 07:24:53.000000000","message":"Done","commit_id":"fdfc3807c6a443066344196cd8b93ff10421000b"}]}
