)]}'
{"oslo/messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"bfe144596428f5787e1b4369f95272571fcc19cb","unresolved":false,"context_lines":[{"line_number":882,"context_line":""},{"line_number":883,"context_line":"class RabbitIncomingMessage(base.IncomingMessage):"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"    def __init__(self, listener, ctxt, message, msg_id, reply_q):"},{"line_number":886,"context_line":"        super(RabbitIncomingMessage, self).__init__(listener, ctxt, message)"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"        self.msg_id \u003d msg_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fnz8%3D","line":885,"updated":"2013-07-26 15:03:31.000000000","message":"Would it make sense to make reply_q an optional keyword of base.IncomingMessage ?\n\nIt\u0027s being used in fake\u0027s, rabbit\u0027s and I\u0027ll most likely use it on qpid\u0027s. It also makes sense for messages waiting for a reply to pass it along with the context.","commit_id":"b7350fa2292339ef91ef4398001de53461631cf6"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"548054532a853ef8b67bd1e62bfff215a4547610","unresolved":false,"context_lines":[{"line_number":882,"context_line":""},{"line_number":883,"context_line":"class RabbitIncomingMessage(base.IncomingMessage):"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"    def __init__(self, listener, ctxt, message, msg_id, reply_q):"},{"line_number":886,"context_line":"        super(RabbitIncomingMessage, self).__init__(listener, ctxt, message)"},{"line_number":887,"context_line":""},{"line_number":888,"context_line":"        self.msg_id \u003d msg_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FcXM%3D","line":885,"in_reply_to":"AAAAQn%2F%2Fnz8%3D","updated":"2013-07-31 05:51:39.000000000","message":"Yep, we can definitely refactor more to be shared between drivers - e.g. Ib09e467313c9b68f1eba6b615e6fce83f44fee70","commit_id":"b7350fa2292339ef91ef4398001de53461631cf6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"bfe144596428f5787e1b4369f95272571fcc19cb","unresolved":false,"context_lines":[{"line_number":915,"context_line":""},{"line_number":916,"context_line":"    def done(self):"},{"line_number":917,"context_line":"        LOG.info(\"done\")"},{"line_number":918,"context_line":"        # FIXME(markmc): I\u0027m not sure we need this method ... we\u0027ve already"},{"line_number":919,"context_line":"        # acked the message at this point"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fn1E%3D","line":918,"updated":"2013-07-26 15:03:31.000000000","message":"I have the same thought! Do you think there\u0027s another use for it?\n\nFor example: Post-Message hook? I\u0027m not using it in qpid\u0027s implementation either.","commit_id":"b7350fa2292339ef91ef4398001de53461631cf6"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"548054532a853ef8b67bd1e62bfff215a4547610","unresolved":false,"context_lines":[{"line_number":915,"context_line":""},{"line_number":916,"context_line":"    def done(self):"},{"line_number":917,"context_line":"        LOG.info(\"done\")"},{"line_number":918,"context_line":"        # FIXME(markmc): I\u0027m not sure we need this method ... we\u0027ve already"},{"line_number":919,"context_line":"        # acked the message at this point"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FcXE%3D","line":918,"in_reply_to":"AAAAQn%2F%2Fn1E%3D","updated":"2013-07-31 05:51:39.000000000","message":"I think we\u0027ll just remove it - I was originally thinking we\u0027d need it for acking, but I obviously missed something","commit_id":"b7350fa2292339ef91ef4398001de53461631cf6"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"d498501be152a030bc7177d58045b628495c4cfa","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"            self.conf.set_override(\u0027control_exchange\u0027, self._default_exchange)"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"        # FIXME(markmc): get connection params from URL in addition to conf"},{"line_number":1095,"context_line":"        # FIXME(markmc): close connections"},{"line_number":1096,"context_line":"        self._connection_pool \u003d rpc_amqp.get_connection_pool(self.conf,"},{"line_number":1097,"context_line":"                                                             Connection)"},{"line_number":1098,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FpdQ%3D","line":1095,"updated":"2013-07-25 20:40:42.000000000","message":"Shouldn\u0027t this be handled by the connection pool?  Or do you mean return the connections to the pool so they can be closed?","commit_id":"b7350fa2292339ef91ef4398001de53461631cf6"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"548054532a853ef8b67bd1e62bfff215a4547610","unresolved":false,"context_lines":[{"line_number":1092,"context_line":"            self.conf.set_override(\u0027control_exchange\u0027, self._default_exchange)"},{"line_number":1093,"context_line":""},{"line_number":1094,"context_line":"        # FIXME(markmc): get connection params from URL in addition to conf"},{"line_number":1095,"context_line":"        # FIXME(markmc): close connections"},{"line_number":1096,"context_line":"        self._connection_pool \u003d rpc_amqp.get_connection_pool(self.conf,"},{"line_number":1097,"context_line":"                                                             Connection)"},{"line_number":1098,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FcW8%3D","line":1095,"in_reply_to":"AAAAQn%2F%2FpdQ%3D","updated":"2013-07-31 05:51:39.000000000","message":"Just that there should be e.g. a cleanup() method on the Transport which calls cleanup() on the driver object","commit_id":"b7350fa2292339ef91ef4398001de53461631cf6"},{"author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"change_message_id":"bfe144596428f5787e1b4369f95272571fcc19cb","unresolved":false,"context_lines":[{"line_number":1137,"context_line":"        msg \u003d message"},{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":"        msg_id \u003d uuid.uuid4().hex"},{"line_number":1140,"context_line":"        msg.update({\u0027_msg_id\u0027: msg_id})"},{"line_number":1141,"context_line":"        LOG.debug(_(\u0027MSG_ID is %s\u0027) % (msg_id))"},{"line_number":1142,"context_line":"        rpc_amqp._add_unique_id(msg)"},{"line_number":1143,"context_line":"        rpc_amqp.pack_context(msg, context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FugA%3D","line":1140,"updated":"2013-07-26 15:03:31.000000000","message":"Can we re-use the unique_id added in line 1142? \n\nCan we make .prepare method add that id for us?","commit_id":"b7350fa2292339ef91ef4398001de53461631cf6"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"548054532a853ef8b67bd1e62bfff215a4547610","unresolved":false,"context_lines":[{"line_number":1137,"context_line":"        msg \u003d message"},{"line_number":1138,"context_line":""},{"line_number":1139,"context_line":"        msg_id \u003d uuid.uuid4().hex"},{"line_number":1140,"context_line":"        msg.update({\u0027_msg_id\u0027: msg_id})"},{"line_number":1141,"context_line":"        LOG.debug(_(\u0027MSG_ID is %s\u0027) % (msg_id))"},{"line_number":1142,"context_line":"        rpc_amqp._add_unique_id(msg)"},{"line_number":1143,"context_line":"        rpc_amqp.pack_context(msg, context)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FcWs%3D","line":1140,"in_reply_to":"AAAAQn%2F%2FugA%3D","updated":"2013-07-31 05:51:39.000000000","message":"The _unique_id and _msg_id fields in our messages serve different purposes\n\nEach message contains a different _unique_id to identify duplicates\n\nA reply to a msg will contain the same _msg_id as the original request\n\nSee also some of the background in I5bfacadbdf7de8b34d6370b9aa869c271957692d\n\nAnyway, it\u0027s kinda academic - we can\u0027t change the wire protocol incompatibly","commit_id":"b7350fa2292339ef91ef4398001de53461631cf6"}]}