)]}'
{"oslo_messaging/notify/messaging.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"2437ba6147555b1f94d024eb6eb07f3e409d36b6","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    deployed which do not support the 2.0 message format."},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def __init__(self, conf, topics, transport, exchange\u003dNone, version\u003d1.0):"},{"line_number":60,"context_line":"        super(MessagingDriver, self).__init__(conf, topics,"},{"line_number":61,"context_line":"                                              transport, exchange\u003dexchange)"},{"line_number":62,"context_line":"        self.version \u003d version"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_6181ac8f","line":59,"range":{"start_line":59,"start_character":47,"end_line":59,"end_character":62},"updated":"2016-10-26 08:41:14.000000000","message":"This breaks the API","commit_id":"1d4e128d4df7fbc0b4fc08efa928d3fa67a4360d"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"1f748e9d3c07a8784d3f2e75c5aa963565ec6a5a","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    deployed which do not support the 2.0 message format."},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def __init__(self, conf, topics, transport, exchange\u003dNone, version\u003d1.0):"},{"line_number":60,"context_line":"        super(MessagingDriver, self).__init__(conf, topics,"},{"line_number":61,"context_line":"                                              transport, exchange\u003dexchange)"},{"line_number":62,"context_line":"        self.version \u003d version"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_a9b6423b","line":59,"range":{"start_line":59,"start_character":47,"end_line":59,"end_character":62},"in_reply_to":"ba5da102_4cadbf30","updated":"2016-10-26 14:19:08.000000000","message":"Default value for an argument is not enough, since the relative order of all arguments is also important. If you make exchange\u003dNone the last argument, then it won\u0027t break the public API.","commit_id":"1d4e128d4df7fbc0b4fc08efa928d3fa67a4360d"},{"author":{"_account_id":18414,"name":"Shengping Zhang","email":"zhangshengping@unitedstack.com","username":"PeterZhang"},"change_message_id":"c0bbee6cd47ac70c7e1ef1b2fbd551b9264eb3c7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    deployed which do not support the 2.0 message format."},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def __init__(self, conf, topics, transport, exchange\u003dNone, version\u003d1.0):"},{"line_number":60,"context_line":"        super(MessagingDriver, self).__init__(conf, topics,"},{"line_number":61,"context_line":"                                              transport, exchange\u003dexchange)"},{"line_number":62,"context_line":"        self.version \u003d version"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_4cadbf30","line":59,"range":{"start_line":59,"start_character":47,"end_line":59,"end_character":62},"in_reply_to":"ba5da102_6181ac8f","updated":"2016-10-26 09:14:58.000000000","message":"sorry, do you mean other class that inherits this class will mandatorily add a exchange parameter in constructor ? or someone uses  this API will mandatorily add a exchange parameter? but, I set the exchange a default value, it is not required mandatorily.","commit_id":"1d4e128d4df7fbc0b4fc08efa928d3fa67a4360d"},{"author":{"_account_id":18414,"name":"Shengping Zhang","email":"zhangshengping@unitedstack.com","username":"PeterZhang"},"change_message_id":"9acaad15cb81234e8933bc44e819287a694c66eb","unresolved":false,"context_lines":[{"line_number":56,"context_line":"    deployed which do not support the 2.0 message format."},{"line_number":57,"context_line":"    \"\"\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def __init__(self, conf, topics, transport, exchange\u003dNone, version\u003d1.0):"},{"line_number":60,"context_line":"        super(MessagingDriver, self).__init__(conf, topics,"},{"line_number":61,"context_line":"                                              transport, exchange\u003dexchange)"},{"line_number":62,"context_line":"        self.version \u003d version"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_144ad783","line":59,"range":{"start_line":59,"start_character":47,"end_line":59,"end_character":62},"in_reply_to":"ba5da102_a9b6423b","updated":"2016-10-27 04:38:27.000000000","message":"Thank you a lot. I will do it now :)","commit_id":"1d4e128d4df7fbc0b4fc08efa928d3fa67a4360d"}],"oslo_messaging/notify/notifier.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"2437ba6147555b1f94d024eb6eb07f3e409d36b6","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                           removal_version\u003d\u00275.0.0\u0027)"},{"line_number":223,"context_line":"    def __init__(self, transport, publisher_id\u003dNone,"},{"line_number":224,"context_line":"                 driver\u003dNone, topic\u003dNone,"},{"line_number":225,"context_line":"                 exchange\u003dNone, serializer\u003dNone,"},{"line_number":226,"context_line":"                 retry\u003dNone, topics\u003dNone):"},{"line_number":227,"context_line":"        \"\"\"Construct a Notifier object."},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_e16cdc0a","line":225,"updated":"2016-10-26 08:41:14.000000000","message":"This breaks the API :(","commit_id":"1d4e128d4df7fbc0b4fc08efa928d3fa67a4360d"},{"author":{"_account_id":20864,"name":"Gevorg Davoian","email":"gdavoian@gmail.com","username":"gdavoian"},"change_message_id":"1f748e9d3c07a8784d3f2e75c5aa963565ec6a5a","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                           removal_version\u003d\u00275.0.0\u0027)"},{"line_number":223,"context_line":"    def __init__(self, transport, publisher_id\u003dNone,"},{"line_number":224,"context_line":"                 driver\u003dNone, topic\u003dNone,"},{"line_number":225,"context_line":"                 exchange\u003dNone, serializer\u003dNone,"},{"line_number":226,"context_line":"                 retry\u003dNone, topics\u003dNone):"},{"line_number":227,"context_line":"        \"\"\"Construct a Notifier object."},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_8955fec7","line":225,"in_reply_to":"ba5da102_cc2f0ff5","updated":"2016-10-26 14:19:08.000000000","message":"The same thing here.","commit_id":"1d4e128d4df7fbc0b4fc08efa928d3fa67a4360d"},{"author":{"_account_id":18414,"name":"Shengping Zhang","email":"zhangshengping@unitedstack.com","username":"PeterZhang"},"change_message_id":"7298fc477dcd35abe5a7493ac130b1700d822ad3","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                           removal_version\u003d\u00275.0.0\u0027)"},{"line_number":223,"context_line":"    def __init__(self, transport, publisher_id\u003dNone,"},{"line_number":224,"context_line":"                 driver\u003dNone, topic\u003dNone,"},{"line_number":225,"context_line":"                 exchange\u003dNone, serializer\u003dNone,"},{"line_number":226,"context_line":"                 retry\u003dNone, topics\u003dNone):"},{"line_number":227,"context_line":"        \"\"\"Construct a Notifier object."},{"line_number":228,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba5da102_cc2f0ff5","line":225,"in_reply_to":"ba5da102_e16cdc0a","updated":"2016-10-26 09:07:09.000000000","message":"I set  this exchange parameter a default value as None, so it would not affect the previous API. I am not quite get your meaning here. could you  please give me something more specific, really appreciated :).","commit_id":"1d4e128d4df7fbc0b4fc08efa928d3fa67a4360d"}]}