)]}'
{"oslo_messaging/rpc/server.py":[{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"26e65c58c7bb8bb2cabaffde5d0393d3dca380f7","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"class RPCServer(msg_server.MessageHandlingServer):"},{"line_number":138,"context_line":"    def __init__(self, transport, target, dispatcher, executor\u003d\u0027blocking\u0027):"},{"line_number":139,"context_line":"        super(RPCServer, self).__init__(transport, dispatcher, executor)"},{"line_number":140,"context_line":"        self._target \u003d target"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_604f96bd","line":138,"range":{"start_line":138,"start_character":42,"end_line":138,"end_character":52},"updated":"2016-11-08 19:10:00.000000000","message":"put differently, if you don\u0027t want people to specify the dispatcher, don\u0027t make it an argument to the constructor on your public class.","commit_id":"ae371409c15ef3b75847be77049ee03d85560778"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"b75a31f8797faed19237d7430eb389fc82f87ad7","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"class RPCServer(msg_server.MessageHandlingServer):"},{"line_number":138,"context_line":"    def __init__(self, transport, target, dispatcher, executor\u003d\u0027blocking\u0027):"},{"line_number":139,"context_line":"        super(RPCServer, self).__init__(transport, dispatcher, executor)"},{"line_number":140,"context_line":"        self._target \u003d target"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_3cde8711","line":138,"range":{"start_line":138,"start_character":42,"end_line":138,"end_character":52},"in_reply_to":"9a629dbe_07489d2c","updated":"2016-11-09 11:51:17.000000000","message":"Agreed","commit_id":"ae371409c15ef3b75847be77049ee03d85560778"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"0b09d5682f9f5b963e1ad7120e43d83fa1ba4110","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"class RPCServer(msg_server.MessageHandlingServer):"},{"line_number":138,"context_line":"    def __init__(self, transport, target, dispatcher, executor\u003d\u0027blocking\u0027):"},{"line_number":139,"context_line":"        super(RPCServer, self).__init__(transport, dispatcher, executor)"},{"line_number":140,"context_line":"        self._target \u003d target"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_8bee8bb2","line":138,"range":{"start_line":138,"start_character":42,"end_line":138,"end_character":52},"in_reply_to":"9a629dbe_604f96bd","updated":"2016-11-08 19:31:21.000000000","message":"This is not a public class. __all__ does not have this one.","commit_id":"ae371409c15ef3b75847be77049ee03d85560778"},{"author":{"_account_id":9664,"name":"amrith","email":"amrith.kumar@gmail.com","username":"amrith"},"change_message_id":"1c899da05d770bd46bfb38064f367579df21ab9a","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"class RPCServer(msg_server.MessageHandlingServer):"},{"line_number":138,"context_line":"    def __init__(self, transport, target, dispatcher, executor\u003d\u0027blocking\u0027):"},{"line_number":139,"context_line":"        super(RPCServer, self).__init__(transport, dispatcher, executor)"},{"line_number":140,"context_line":"        self._target \u003d target"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_dd95a4e4","line":138,"range":{"start_line":138,"start_character":42,"end_line":138,"end_character":52},"in_reply_to":"9a629dbe_8bee8bb2","updated":"2016-11-08 20:53:37.000000000","message":"My mistake, I was looking at the wiki and didn\u0027t focus on __all__","commit_id":"ae371409c15ef3b75847be77049ee03d85560778"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"5139750ce15400d21e6b69cb7414069855c7eb06","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"class RPCServer(msg_server.MessageHandlingServer):"},{"line_number":138,"context_line":"    def __init__(self, transport, target, dispatcher, executor\u003d\u0027blocking\u0027):"},{"line_number":139,"context_line":"        super(RPCServer, self).__init__(transport, dispatcher, executor)"},{"line_number":140,"context_line":"        self._target \u003d target"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_07489d2c","line":138,"range":{"start_line":138,"start_character":42,"end_line":138,"end_character":52},"in_reply_to":"9a629dbe_dd95a4e4","updated":"2016-11-09 06:49:02.000000000","message":"Personally, I don\u0027t like usage of __all__ and prefer explicit thing like _RPCServer.","commit_id":"ae371409c15ef3b75847be77049ee03d85560778"}]}