)]}'
{"oslo_messaging/_drivers/zmq_driver/client/zmq_routing_table.py":[{"author":{"_account_id":13290,"name":"Oleksii Zamiatin","email":"ozamiatin@mirantis.com","username":"ozamiatin"},"change_message_id":"ebec067211ee33673919c1d2769f7c46d608ae59","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    self.routing_table.update_hosts(target_key, hosts)"},{"line_number":70,"context_line":"                    self.round_robin_targets[target_key] \u003d \\"},{"line_number":71,"context_line":"                        self.routing_table.get_hosts_round_robin(target_key)"},{"line_number":72,"context_line":"        else:"},{"line_number":73,"context_line":"            with self._lock:"},{"line_number":74,"context_line":"                hosts \u003d self.matchmaker.get_hosts_retry("},{"line_number":75,"context_line":"                    target, zmq_names.socket_type_str(self.listener_type))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa31d9ce_85e75fe3","line":72,"updated":"2017-02-11 03:07:00.000000000","message":"Unfortunately this approach still doesn\u0027t guarantee that we have 100% valid host at the moment. assume a host goes away and didn\u0027t cleanup redis record, we will receive this invalid host for all the expiration time.\n\nYour suggestion with zmq.NOBLOCK was correct from the beginning the only thing I didn\u0027t like in it was using time.sleep to wait for socket to connect. So I\u0027ve used retrying and zmq.Again handling approach here https://review.openstack.org/#/c/429639 please revisit.","commit_id":"ff4a35daa1b0de5571fc9973d1b3ea87fc5f1df3"}]}
