)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"0e68c27098c788cfe6a79487757e330691b84637","unresolved":false,"context_lines":[{"line_number":11,"context_line":"not supported. There are retry support specific to drivers,"},{"line_number":12,"context_line":"it\u0027s better to have the support uniform across the drivers,"},{"line_number":13,"context_line":"by adding configuration retry on the oslo_messaging_notifier."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I8d547ef2a9e8b086f94a1efca17735f3f3cdaac1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da36d5c6_7c579826","line":14,"updated":"2017-02-27 18:40:47.000000000","message":"Can you adds \"Closes-bug: 1666364\" ?","commit_id":"c60eab234aba391bb7b141c6b8dda6c49301d64f"}],"oslo_messaging/notify/notifier.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"d922918b81283e1e68d6366609a70df708dbd97e","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                ],"},{"line_number":56,"context_line":"                help\u003d\u0027AMQP topic used for OpenStack notifications.\u0027),"},{"line_number":57,"context_line":"    cfg.IntOpt(\u0027retry\u0027, default\u003d-1,"},{"line_number":58,"context_line":"               help\u003d\u0027Number of retries for posting a message, \u0027"},{"line_number":59,"context_line":"                    \u00270 - No retry, -1 - indefinite\u0027),"},{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ffa3b31_41aebb98","line":58,"updated":"2017-04-18 14:23:53.000000000","message":"IIRC the notification is re-sent only when the driver\u0027s original send request fails due to a recoverable error from the message bus.\n\nI\u0027d suggest the following help text instead:\n\n\u0027The maximum number of attempts to re-send a notification message which failed to be delivered due to a recoverable error.\u0027","commit_id":"f56a6b83a7c8a3c5fcf64a3d01f1b6b24b9dc4ee"}],"oslo_messaging/tests/notify/test_notifier.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"058d691ea812b7a94c0060c71ed8d1e3d874acf8","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                if hasattr(self, \u0027retry\u0027):"},{"line_number":213,"context_line":"                    send_kwargs[\u0027retry\u0027] \u003d self.retry"},{"line_number":214,"context_line":"                else:"},{"line_number":215,"context_line":"                    send_kwargs[\u0027retry\u0027] \u003d -1"},{"line_number":216,"context_line":"                target \u003d oslo_messaging.Target(topic\u003d\u0027%s.%s\u0027 % (topic,"},{"line_number":217,"context_line":"                                                                self.priority))"},{"line_number":218,"context_line":"                calls.append(mock.call(target,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_a88bc3c0","line":215,"updated":"2017-04-11 12:41:31.000000000","message":"just curious, but what\u0027s this change for?","commit_id":"f56a6b83a7c8a3c5fcf64a3d01f1b6b24b9dc4ee"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"058d691ea812b7a94c0060c71ed8d1e3d874acf8","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":""},{"line_number":376,"context_line":"class TestNotificationConfig(test_utils.BaseTestCase):"},{"line_number":377,"context_line":"    def setUp(self):"},{"line_number":378,"context_line":"        super(TestNotificationConfig, self).setUp()"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def test_retry_config(self):"},{"line_number":381,"context_line":"        conf \u003d self.messaging_conf.conf"}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_28c1f3e5","line":378,"range":{"start_line":377,"start_character":0,"end_line":378,"end_character":51},"updated":"2017-04-11 12:41:31.000000000","message":"don\u0027t need this.","commit_id":"f56a6b83a7c8a3c5fcf64a3d01f1b6b24b9dc4ee"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"058d691ea812b7a94c0060c71ed8d1e3d874acf8","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        transport \u003d _FakeTransport(conf)"},{"line_number":398,"context_line":"        notifier \u003d oslo_messaging.Notifier(transport, retry\u003d5)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"        self.assertNotEqual(3, notifier.retry)"},{"line_number":401,"context_line":"        self.assertEqual(5, notifier.retry)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bff0334d_48f7975a","line":400,"updated":"2017-04-11 12:41:31.000000000","message":"this test seems unnecessary since it\u0027ll just fail on following assertion","commit_id":"f56a6b83a7c8a3c5fcf64a3d01f1b6b24b9dc4ee"}]}