)]}'
{"oslo_messaging/notify/notifier.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"0e9595c1e50ce2f2130e4bb83082ef9c4163cb58","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        else:"},{"line_number":254,"context_line":"            self._topics \u003d conf.oslo_messaging_notifications.topics"},{"line_number":255,"context_line":"        self._serializer \u003d serializer or msg_serializer.NoOpSerializer()"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        self._driver_mgr \u003d named.NamedExtensionManager("},{"line_number":258,"context_line":"            \u0027oslo.messaging.notify.drivers\u0027,"},{"line_number":259,"context_line":"            names\u003dself._driver_names,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_2dae2481","line":256,"updated":"2017-03-03 16:53:52.000000000","message":"You can skip driver_mgr setup is driver_names is [\u0027noop\u0027]","commit_id":"ed149bae81cd6131b91404efc8f28efc0b0f1324"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"81d0db9ef00f5d09c07283c0c1c09bd201a13b82","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        else:"},{"line_number":254,"context_line":"            self._topics \u003d conf.oslo_messaging_notifications.topics"},{"line_number":255,"context_line":"        self._serializer \u003d serializer or msg_serializer.NoOpSerializer()"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        self._driver_mgr \u003d named.NamedExtensionManager("},{"line_number":258,"context_line":"            \u0027oslo.messaging.notify.drivers\u0027,"},{"line_number":259,"context_line":"            names\u003dself._driver_names,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_4e0a2e27","line":256,"in_reply_to":"ba2be162_2dae2481","updated":"2017-03-06 14:51:38.000000000","message":"I would keep the manager setup here as it makes possible to load NoOpDriver and that implement the not-doing-anything behavior in a generic way instead of putting ifs to multiple places in this base class. See my answer to you second comment in this file.","commit_id":"ed149bae81cd6131b91404efc8f28efc0b0f1324"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"0e9595c1e50ce2f2130e4bb83082ef9c4163cb58","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        return _SubNotifier._prepare(self, publisher_id, retry\u003dretry)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def _notify(self, ctxt, event_type, payload, priority, publisher_id\u003dNone,"},{"line_number":290,"context_line":"                retry\u003dNone):"},{"line_number":291,"context_line":"        payload \u003d self._serializer.serialize_entity(ctxt, payload)"},{"line_number":292,"context_line":"        ctxt \u003d self._serializer.serialize_context(ctxt)"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_ad74d435","line":290,"updated":"2017-03-03 16:53:52.000000000","message":"you can check drivers here and directly returns.","commit_id":"ed149bae81cd6131b91404efc8f28efc0b0f1324"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"81d0db9ef00f5d09c07283c0c1c09bd201a13b82","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        return _SubNotifier._prepare(self, publisher_id, retry\u003dretry)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def _notify(self, ctxt, event_type, payload, priority, publisher_id\u003dNone,"},{"line_number":290,"context_line":"                retry\u003dNone):"},{"line_number":291,"context_line":"        payload \u003d self._serializer.serialize_entity(ctxt, payload)"},{"line_number":292,"context_line":"        ctxt \u003d self._serializer.serialize_context(ctxt)"},{"line_number":293,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba2be162_ee6be2ee","line":290,"in_reply_to":"ba2be162_ad74d435","updated":"2017-03-06 14:51:38.000000000","message":"We don\u0027t need that as NoOpDriver.notify() short circuit the notification emitting and it don\u0027t even call _notify in the base class.","commit_id":"ed149bae81cd6131b91404efc8f28efc0b0f1324"}]}