)]}'
{"oslo_messaging/rpc/dispatcher.py":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"6af3f6a59e0364d17f166ade02eaeb0caf124b76","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        # This is a special message that only works when"},{"line_number":207,"context_line":"        # targeted at no namespace..."},{"line_number":208,"context_line":"        if method \u003d\u003d \"healthcheck\" and not namespace:"},{"line_number":209,"context_line":"            self._do_health(ctx)"},{"line_number":210,"context_line":"            return"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_5a47ea1c","line":208,"range":{"start_line":208,"start_character":22,"end_line":208,"end_character":33},"updated":"2017-03-20 13:10:02.000000000","message":"There is assumption that endpoint can\u0027t have method \u0027healthcheck\u0027.","commit_id":"f5c5078a63f9b8dc5edc5a991937ddb13c98bd6e"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"024d4ab0cd2b8f57b872fefee97784fb83196596","unresolved":false,"context_lines":[{"line_number":205,"context_line":""},{"line_number":206,"context_line":"        # This is a special message that only works when"},{"line_number":207,"context_line":"        # targeted at no namespace..."},{"line_number":208,"context_line":"        if method \u003d\u003d \"healthcheck\" and not namespace:"},{"line_number":209,"context_line":"            self._do_health(ctx)"},{"line_number":210,"context_line":"            return"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_ab7972fe","line":208,"range":{"start_line":208,"start_character":22,"end_line":208,"end_character":33},"in_reply_to":"1a1ced50_5a47ea1c","updated":"2017-03-20 14:28:09.000000000","message":"Would it make sense to reserve an \u0027oslo.messaging\u0027 namespace?\nIntroduce a warning if any application is using the namespace first, then implement the healthcheck once users fix their code?","commit_id":"f5c5078a63f9b8dc5edc5a991937ddb13c98bd6e"},{"author":{"_account_id":19520,"name":"Kirill Bespalov","email":"kbespalov@mirantis.com","username":"k.bespalov"},"change_message_id":"c7428fb4e4f77c255a5ab1b01c1cc37bc595e259","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        # This is a special message that only works when"},{"line_number":207,"context_line":"        # targeted at no namespace..."},{"line_number":208,"context_line":"        if method \u003d\u003d \"healthcheck\" and not namespace:"},{"line_number":209,"context_line":"            self._do_health(ctx)"},{"line_number":210,"context_line":"            return"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        found_compatible \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a1ced50_1960fba4","line":209,"range":{"start_line":209,"start_character":9,"end_line":209,"end_character":32},"updated":"2017-03-21 07:58:45.000000000","message":"The fact what Dispatcher implements a \"health check\" functionality seems not good.\n\nMaybe will be better if you are add by default an special Endpoint called like \"RPCStateEndpoint\" which will be do all this stuff? Like:\n\n class RPCStateEndpoint(object):\n   target \u003d Target(namespace\u003d\"oslo.messaging.rpc_state\")\n\n   def healthcheck(): pass","commit_id":"f5c5078a63f9b8dc5edc5a991937ddb13c98bd6e"}]}