)]}'
{"oslo_messaging/_drivers/amqpdriver.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"cdf8d9e1509402b7dd4565eceefb3f961dbb6283","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class MessageOperationsHandler(object):"},{"line_number":46,"context_line":"    \"\"\"Queue of pending message operation to do."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    This class helps to ensure message operation are done by"},{"line_number":49,"context_line":"    the thread that handles the rabbitmq connection"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_9b8527d2","line":46,"updated":"2017-05-10 09:04:55.000000000","message":"Hum, the docstring is a little bit confusing. I suggest:\n\n\"Queue used by message operations to ensure that all tasks are serialized and run in the same thread, since underlying drivers like kombu are not thread safe.\"","commit_id":"228cc10e246f3edd96f9ae5d1522dd07e49f153d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"1ca79bfb6478474b650d1deb356d1a1b6c50f00b","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class MessageOperationsHandler(object):"},{"line_number":46,"context_line":"    \"\"\"Queue of pending message operation to do."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    This class helps to ensure message operation are done by"},{"line_number":49,"context_line":"    the thread that handles the rabbitmq connection"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_9bec0790","line":46,"in_reply_to":"3f044301_9b8527d2","updated":"2017-05-10 09:10:28.000000000","message":"Done","commit_id":"228cc10e246f3edd96f9ae5d1522dd07e49f153d"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"32e8a6c8d74e8ba5586d414767a9115d30aa4e5f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    \"\"\"Queue of pending message operation to do."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    This class helps to ensure message operation are done by"},{"line_number":49,"context_line":"    the thread that handles the rabbitmq connection"},{"line_number":50,"context_line":"    \"\"\""},{"line_number":51,"context_line":"    def __init__(self):"},{"line_number":52,"context_line":"        self._tasks \u003d moves.queue.Queue()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_60e50a09","line":49,"updated":"2017-05-10 07:44:43.000000000","message":"nit, add a period :D","commit_id":"228cc10e246f3edd96f9ae5d1522dd07e49f153d"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3398d18ca90f72125e9fb444ae652eb1b9cd44f5","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                finally:"},{"line_number":64,"context_line":"                    event.set()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def do(self, task):"},{"line_number":67,"context_line":"        event \u003d threading.Event()"},{"line_number":68,"context_line":"        self._tasks.put((task, event))"},{"line_number":69,"context_line":"        event.wait()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_9bb407d3","line":66,"updated":"2017-05-10 08:58:27.000000000","message":"Can you please add a short comment/docstring explaining the purpose of this \"do\" method?\n\n\"Put the task in the queue and waits until the task is completed.\"","commit_id":"228cc10e246f3edd96f9ae5d1522dd07e49f153d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"1ca79bfb6478474b650d1deb356d1a1b6c50f00b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                finally:"},{"line_number":64,"context_line":"                    event.set()"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def do(self, task):"},{"line_number":67,"context_line":"        event \u003d threading.Event()"},{"line_number":68,"context_line":"        self._tasks.put((task, event))"},{"line_number":69,"context_line":"        event.wait()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_7b05bb45","line":66,"in_reply_to":"3f044301_9bb407d3","updated":"2017-05-10 09:10:28.000000000","message":"Done","commit_id":"228cc10e246f3edd96f9ae5d1522dd07e49f153d"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"51cba10cb1659c6de894c25918653ebbe4b68385","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def __init__(self):"},{"line_number":51,"context_line":"        self._tasks \u003d moves.queue.Queue()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def process(self):"},{"line_number":54,"context_line":"        while True:"},{"line_number":55,"context_line":"            try:"},{"line_number":56,"context_line":"                task, event \u003d self._tasks.get(block\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_062ade7d","line":53,"updated":"2017-05-10 09:27:39.000000000","message":"Docstring: \"Run all pending tasks queued by do().\"\n\nIt wasn\u0027t obvious for me at the first read if the method blocks forever or not. It doesn\u0027t block, it completes once all queue tasks are run...\n\nOther tasks can be queued in parallel, but I guess that it\u0027s ok since while process() is running, I expect that slowly we will not get any do() call anymore, right?","commit_id":"57eceaa264ede443dc60786fb27535bef3a8e29a"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"6abc42d57b2189defe837646f3ce73587a3692f9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    def __init__(self):"},{"line_number":51,"context_line":"        self._tasks \u003d moves.queue.Queue()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def process(self):"},{"line_number":54,"context_line":"        while True:"},{"line_number":55,"context_line":"            try:"},{"line_number":56,"context_line":"                task, event \u003d self._tasks.get(block\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_46e4663c","line":53,"in_reply_to":"3f044301_062ade7d","updated":"2017-05-10 09:33:31.000000000","message":"Yes, because while we are running this, we don\u0027t poll the connection anymore, so no new message will come until we finish to processed all acks.","commit_id":"57eceaa264ede443dc60786fb27535bef3a8e29a"},{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"fd49dcc5066d0dc5b591cde4085fba91b8c3494a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \"Put the task in the queue and waits until the task is completed.\""},{"line_number":68,"context_line":"        event \u003d threading.Event()"},{"line_number":69,"context_line":"        self._tasks.put((task, event))"},{"line_number":70,"context_line":"        event.wait()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class AMQPIncomingMessage(base.RpcIncomingMessage):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_a4e5580b","line":70,"updated":"2017-05-10 17:20:05.000000000","message":"Only suggestion is a timeout here.\n\nFrom what I remember on py2.7 the wait without a timeout has problems (I think it had something to do with signals not being handled), this was fixed in py3.x from what I remember.","commit_id":"9922005d59715bd8cb6d70423daa61f151097e34"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"73a7d26a9d416b4f760dd7ab21e1649fef536dd0","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        \"Put the task in the queue and waits until the task is completed.\""},{"line_number":68,"context_line":"        event \u003d threading.Event()"},{"line_number":69,"context_line":"        self._tasks.put((task, event))"},{"line_number":70,"context_line":"        event.wait()"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class AMQPIncomingMessage(base.RpcIncomingMessage):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f044301_33117e05","line":70,"in_reply_to":"3f044301_a4e5580b","updated":"2017-05-11 11:30:16.000000000","message":"\u003e From what I remember on py2.7 the wait without a timeout has problems (I think it had something to do with signals not being handled), this was fixed in py3.x from what I remember.\n\nWhich kind of issue? I expect more issues with a timeout and a blocking wait/acquire. Python 3.5 now retries interrupted syscalls (EINTR) automatically which means recomputing the timeout for functions taking a timeout. But it seems like previously, wait/acquire was already retried when interrupted by a signal, especially blocking ones.\n\nI\u0027m aware of two Python 2.7 bugs fixed in Python 3:\n\n* python RLock implementation unsafe with signals: http://bugs.python.org/issue13697\n* Locks cannot be interrupted by signals in Python 2: Condition.wait() doesn’t raise KeyboardInterrupt: http://bugs.python.org/issue8844","commit_id":"9922005d59715bd8cb6d70423daa61f151097e34"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"7ceeccb82281a782ebcc5425c33fe2006c3448f8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from oslo_messaging._i18n import _LI"},{"line_number":34,"context_line":"from oslo_messaging._i18n import _LW"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"logging.basicConfig()"},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Minimum/Maximum sleep between a poll and ack/requeue"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_4a412d0b","line":36,"updated":"2017-05-19 15:22:15.000000000","message":"Is this intentional?","commit_id":"91976f1ff211f408849810b60aa5c9367747b41e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"e5ae649799d758eaa551fcc2d1e633a10540ed0d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from oslo_messaging._i18n import _LI"},{"line_number":34,"context_line":"from oslo_messaging._i18n import _LW"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"logging.basicConfig()"},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Minimum/Maximum sleep between a poll and ack/requeue"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_0a9afc61","line":36,"in_reply_to":"ff0f0b1f_4a412d0b","updated":"2017-05-21 10:05:40.000000000","message":"No, removed","commit_id":"91976f1ff211f408849810b60aa5c9367747b41e"},{"author":{"_account_id":11536,"name":"hongbin","email":"hongbin034@gmail.com","username":"hongbin"},"change_message_id":"d433355b5c6925b824e1f7650775c8ea8e9ae089","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        \"Put the task in the queue and waits until the task is completed.\""},{"line_number":88,"context_line":"        event \u003d threading.Event()"},{"line_number":89,"context_line":"        self._tasks.put((task, event))"},{"line_number":90,"context_line":"        event.wait()"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"class AMQPIncomingMessage(base.RpcIncomingMessage):"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_ccc1cb82","line":90,"range":{"start_line":90,"start_character":14,"end_line":90,"end_character":18},"updated":"2017-06-01 00:37:30.000000000","message":"This patch incurs bug #1694728. It looks the issue is that:\n* If executor is \u0027blocking\u0027, which is the default, the message acknowledgement will be blocked in here forever.\n* If executor is \u0027eventlet\u0027, it will work.","commit_id":"da02bc2169b09959d857c605961ead1bbba1019d"}]}
