)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"dd8ed4c3b2e245cde2b114ebf3db965f4e89c0c4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajath Agasthya \u003crajathagasthya@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-29 23:49:16 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: Remove deprecated options in rabbitmq driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Removed options:"},{"line_number":10,"context_line":"* rabbit_host"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_a34833b2","line":7,"updated":"2017-08-31 14:48:39.000000000","message":"Remove the WIP - best to leave that out of a git commit message (since it won\u0027t be WIP when it\u0027s commited :) \n\nNormally we just mark the gerrit review as WIP until it\u0027s done and ready to review.","commit_id":"9f019dc0562b1a672189c547e44b4405ca2bb9b1"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"dd8ed4c3b2e245cde2b114ebf3db965f4e89c0c4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"* rabbit_password"},{"line_number":15,"context_line":"* rabbit_virtual_host"},{"line_number":16,"context_line":"* rabbit_max_retries"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I3d4c6ea9db4cc6d25245705b85508092c3f6e9fa"},{"line_number":19,"context_line":"Closes-Bug: #1712394"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f287b81_a3ddd3dd","line":17,"updated":"2017-08-31 14:48:39.000000000","message":"Can you add some text to explain that these options have been replaced by the transport_url option?","commit_id":"9f019dc0562b1a672189c547e44b4405ca2bb9b1"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"dd8ed4c3b2e245cde2b114ebf3db965f4e89c0c4","unresolved":false,"context_lines":[{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        self.login_method \u003d driver_conf.rabbit_login_method"},{"line_number":420,"context_line":"        self.fake_rabbit \u003d driver_conf.fake_rabbit"},{"line_number":421,"context_line":"        self.virtual_host \u003d \u0027/\u0027"},{"line_number":422,"context_line":"        self.rabbit_host \u003d \u0027localhost\u0027"},{"line_number":423,"context_line":"        self.rabbit_port \u003d \u00275672\u0027"},{"line_number":424,"context_line":"        self.rabbit_hosts \u003d [\u0027:\u0027.join([self.rabbit_host, self.rabbit_port])]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_fe57f456","line":421,"updated":"2017-08-31 14:48:39.000000000","message":"I would go as far as completely removing these attributes.  They\u0027re not used anywhere but the default case below and I think it would be clearer just hardcoding these defaults in that case below (see below)","commit_id":"9f019dc0562b1a672189c547e44b4405ca2bb9b1"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"dd8ed4c3b2e245cde2b114ebf3db965f4e89c0c4","unresolved":false,"context_lines":[{"line_number":481,"context_line":"            # (like kombu+memory:///), pass it to kombu as-is"},{"line_number":482,"context_line":"            transport \u003d url.transport.replace(\u0027kombu+\u0027, \u0027\u0027)"},{"line_number":483,"context_line":"            self._url \u003d \"%s://%s\" % (transport, virtual_host)"},{"line_number":484,"context_line":"        else:"},{"line_number":485,"context_line":"            if len(self.rabbit_hosts) \u003e 1:"},{"line_number":486,"context_line":"                random.shuffle(self.rabbit_hosts)"},{"line_number":487,"context_line":"            for adr in self.rabbit_hosts:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_5e360805","line":484,"updated":"2017-08-31 14:48:39.000000000","message":"This is the case where transport_url has not been set and we have to use the defaults.  Since the options can no longer be set this code can be simplified to remove the hosts loop and just update self._url using a string containing the defaults e.g. \"%samqp://guest:guest@localhost:5672/\"","commit_id":"9f019dc0562b1a672189c547e44b4405ca2bb9b1"}],"oslo_messaging/tests/test_removed_opts.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"dd8ed4c3b2e245cde2b114ebf3db965f4e89c0c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"# not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"# a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_5952a214","line":1,"updated":"2017-08-31 14:48:39.000000000","message":"I wouldn\u0027t bother adding tests for removed options - these types of tests basically become obsolete as soon as the patch is merged.   And besides, we know the options have been removed because we reviewed the code were the options where deleted :)","commit_id":"9f019dc0562b1a672189c547e44b4405ca2bb9b1"}]}