)]}'
{"oslo_messaging/_drivers/impl_kafka.py":[{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"e42cd426a2d8924410621f75f6170262a795c872","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from oslo_log import log as logging"},{"line_number":30,"context_line":"from oslo_utils import eventletutils"},{"line_number":31,"context_line":"import tenacity"},{"line_number":32,"context_line":"import uuid"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from oslo_messaging._drivers import base"},{"line_number":35,"context_line":"from oslo_messaging._drivers import common as driver_common"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_c244de1d","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":11},"updated":"2017-10-13 02:37:05.000000000","message":"uuid is standard library, please move this into line 25","commit_id":"45f1a5e34073284a5dc4a0d7a7600a16628ea935"},{"author":{"_account_id":9796,"name":"ChangBo Guo","email":"glongwave@gmail.com","username":"gcb"},"change_message_id":"e42cd426a2d8924410621f75f6170262a795c872","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        self.consumer \u003d None"},{"line_number":128,"context_line":"        self.consumer_timeout \u003d driver_conf.kafka_consumer_timeout"},{"line_number":129,"context_line":"        self.max_fetch_bytes \u003d driver_conf.kafka_max_fetch_bytes"},{"line_number":130,"context_line":"        # TODO(ansmith): temporary to get func tests working"},{"line_number":131,"context_line":"        self.group_id \u003d uuid.uuid4()"},{"line_number":132,"context_line":"        self.url \u003d url"},{"line_number":133,"context_line":"        self._parse_url()"},{"line_number":134,"context_line":"        self._consume_loop_stopped \u003d False"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f4e5783_42734e4e","line":131,"range":{"start_line":130,"start_character":0,"end_line":131,"end_character":36},"updated":"2017-10-13 02:37:05.000000000","message":"I\u0027m not familiar with kafka, uuid is requested by it.\n\nIf we just test, can we use method set_override to override config option `consumer_group` value in test ?\n\n\nhttps://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py","commit_id":"45f1a5e34073284a5dc4a0d7a7600a16628ea935"}],"setup-test-env-kafka.sh":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"c04a4db9ad3c7e7367d374297deadd699de0d7af","unresolved":false,"context_lines":[{"line_number":7,"context_line":"trap \"server_exit $DATADIR\" EXIT"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"SCALA_VERSION\u003d\"2.12\""},{"line_number":10,"context_line":"KAFKA_VERSION\u003d\"0.11.0.1\""},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"function _install_servers {"},{"line_number":13,"context_line":"    tarball\u003dkafka_${SCALA_VERSION}-${KAFKA_VERSION}.tgz"}],"source_content_type":"text/x-sh","patch_set":3,"id":"7f515b1d_8f112860","line":10,"updated":"2017-09-28 16:51:11.000000000","message":"Would it be useful to allow environment variable override of these (say to manually test specific releases)?\n\nSCALA_VERSION\u003d${SCALA_VERSION:-\"2.12\"}  etc.","commit_id":"5959eaa5ae402077611e2ac58b1512517ad4855d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"db24d9dfc602f47a07f0d53951af9764850807ef","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    export PATH\u003d$DATADIR/kafka_${SCALA_VERSION}-${KAFKA_VERSION}/bin:$PATH"},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"pifpaf run kafka -- $*"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3f4b6375_af9b3dc7","side":"PARENT","line":19,"updated":"2017-10-20 04:50:32.000000000","message":"Why rewritting pifpaf in bash ?","commit_id":"a9d10d33cd51387df78a551a4c85fd24a0539e28"},{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"2e89a0530da2388b9c92841d68ab5ad3c8b34c20","unresolved":false,"context_lines":[{"line_number":16,"context_line":"    export PATH\u003d$DATADIR/kafka_${SCALA_VERSION}-${KAFKA_VERSION}/bin:$PATH"},{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"pifpaf run kafka -- $*"}],"source_content_type":"text/x-sh","patch_set":6,"id":"3f4b6375_ec449849","side":"PARENT","line":19,"in_reply_to":"3f4b6375_af9b3dc7","updated":"2017-10-31 13:18:57.000000000","message":"At the time of trying to get the functional test working with the updated kafka version, pifpaf failed starting the server due to new checks implemented in kafka. So, I went down the path of the script to make progress.\n\nI recognize using pifpaf is preferable in the long run and will plan to update it for use with the latest kafka server. I will then return to using it in the setup rather than the script. \n\nI will mark the review wip until completed.","commit_id":"a9d10d33cd51387df78a551a4c85fd24a0539e28"}],"tox.ini":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"fe5e4effa7a9e213e09820192115da94fce1bd72","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    {[testenv]setenv}"},{"line_number":55,"context_line":"    TRANSPORT_URL\u003dkafka://127.0.0.1:9092//"},{"line_number":56,"context_line":"    OS_GROUP_REGEX\u003doslo_messaging.tests.functional"},{"line_number":57,"context_line":"    kafka-python\u003e\u003d1.3.4"},{"line_number":58,"context_line":"commands \u003d {toxinidir}/setup-test-env-kafka.sh python setup.py testr --slowest --testr-args\u003d\u0027{posargs:oslo_messaging.tests.functional}\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[testenv:py27-func-amqp1]"}],"source_content_type":"text/x-properties","patch_set":13,"id":"df87a7cf_c8e22802","line":57,"updated":"2017-12-14 17:34:21.000000000","message":"Is this env variable used anywhere?  And why does it\u0027s value differ from what is in test-requirements.txt?","commit_id":"524ef68832245b40071a56b0aea0f6309e017fa5"},{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"6b195936456386f3437670bf517ae8402fdccd9d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    {[testenv]setenv}"},{"line_number":55,"context_line":"    TRANSPORT_URL\u003dkafka://127.0.0.1:9092//"},{"line_number":56,"context_line":"    OS_GROUP_REGEX\u003doslo_messaging.tests.functional"},{"line_number":57,"context_line":"    kafka-python\u003e\u003d1.3.4"},{"line_number":58,"context_line":"commands \u003d {toxinidir}/setup-test-env-kafka.sh python setup.py testr --slowest --testr-args\u003d\u0027{posargs:oslo_messaging.tests.functional}\u0027"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"[testenv:py27-func-amqp1]"}],"source_content_type":"text/x-properties","patch_set":13,"id":"df87a7cf_9f19b389","line":57,"in_reply_to":"df87a7cf_c8e22802","updated":"2017-12-14 21:23:29.000000000","message":"It is not used and will remove...","commit_id":"524ef68832245b40071a56b0aea0f6309e017fa5"}]}