)]}'
{"oslo_messaging/transport.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"24302e505a975585c2fd2508499b747f43f071f1","unresolved":false,"context_lines":[{"line_number":43,"context_line":"_transport_opts \u003d ["},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027transport_url\u0027,"},{"line_number":45,"context_line":"               secret\u003dTrue,"},{"line_number":46,"context_line":"               help\u003d\u0027A URL representing the messaging driver to use and its \u0027"},{"line_number":47,"context_line":"                    \u0027full configuration. The expected format is:\\n\\n\u0027"},{"line_number":48,"context_line":"                    \u0027scheme://[user:pass@]host:port[,[userN:passN@]hostN:\u0027"},{"line_number":49,"context_line":"                    \u0027portN]/virtual_host?query\\n\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_50cf0129","line":46,"updated":"2017-10-03 20:29:45.000000000","message":"That original help text (first sentence) is awfully vague. \n\nPerhaps we should delete it entirely and replace it with a more concise description of this option\u0027s primary purpose: connecting to the messaging backend?  Suggestion: \n\n\"The network address and optional user credentials for connecting to the messaging backend in URL format.\"\n\nYour additional comment points them to the docs where they can read up on the other optional bits (vhost, query, failover hosts, etc).","commit_id":"07efc0a9758e098c3984f2d1430accc031a629d2"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"960cfcb24bd172094277b7b2cd35a8b7115c9b9c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"_transport_opts \u003d ["},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027transport_url\u0027,"},{"line_number":45,"context_line":"               secret\u003dTrue,"},{"line_number":46,"context_line":"               help\u003d\u0027A URL representing the messaging driver to use and its \u0027"},{"line_number":47,"context_line":"                    \u0027full configuration. The expected format is:\\n\\n\u0027"},{"line_number":48,"context_line":"                    \u0027scheme://[user:pass@]host:port[,[userN:passN@]hostN:\u0027"},{"line_number":49,"context_line":"                    \u0027portN]/virtual_host?query\\n\\n\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_6f450f15","line":46,"in_reply_to":"7f515b1d_50cf0129","updated":"2017-10-06 20:04:08.000000000","message":"Sounds good.  Done.","commit_id":"07efc0a9758e098c3984f2d1430accc031a629d2"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"24302e505a975585c2fd2508499b747f43f071f1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               secret\u003dTrue,"},{"line_number":46,"context_line":"               help\u003d\u0027A URL representing the messaging driver to use and its \u0027"},{"line_number":47,"context_line":"                    \u0027full configuration. The expected format is:\\n\\n\u0027"},{"line_number":48,"context_line":"                    \u0027scheme://[user:pass@]host:port[,[userN:passN@]hostN:\u0027"},{"line_number":49,"context_line":"                    \u0027portN]/virtual_host?query\\n\\n\u0027"},{"line_number":50,"context_line":"                    \u0027Example: rabbit://rabbitmq:password@127.0.0.1:5672//\\n\\n\u0027"},{"line_number":51,"context_line":"                    \u0027For full details on the fields in the URL see the \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_90933901","line":48,"updated":"2017-10-03 20:29:45.000000000","message":"\"scheme\" - this is a generic term for this segment of a URL.  Since oslo.messaging uses it specifically as the name of the messaging backend driver, perhaps it\u0027s better just to use the term \"driver\" instead.\n\n\"scheme\" is also used in the docs - it should be changed there as well.","commit_id":"07efc0a9758e098c3984f2d1430accc031a629d2"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"960cfcb24bd172094277b7b2cd35a8b7115c9b9c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"               secret\u003dTrue,"},{"line_number":46,"context_line":"               help\u003d\u0027A URL representing the messaging driver to use and its \u0027"},{"line_number":47,"context_line":"                    \u0027full configuration. The expected format is:\\n\\n\u0027"},{"line_number":48,"context_line":"                    \u0027scheme://[user:pass@]host:port[,[userN:passN@]hostN:\u0027"},{"line_number":49,"context_line":"                    \u0027portN]/virtual_host?query\\n\\n\u0027"},{"line_number":50,"context_line":"                    \u0027Example: rabbit://rabbitmq:password@127.0.0.1:5672//\\n\\n\u0027"},{"line_number":51,"context_line":"                    \u0027For full details on the fields in the URL see the \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_0fe9fb18","line":48,"in_reply_to":"7f515b1d_90933901","updated":"2017-10-06 20:04:08.000000000","message":"Yeah, I\u0027m good with that.  Before I realized that there was a docstring that already explained this I think I started my example format with driver:// anyway. :-)","commit_id":"07efc0a9758e098c3984f2d1430accc031a629d2"}]}
