)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"aec3dac0ba05adc1de9db6c7a2104688b6bf1d8f","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"To show it working, move the test_amqp_driver to using transport_url --"},{"line_number":13,"context_line":"and will move everything else once there is agreement."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6e2ae2b511fdc52790d5755a9aecaf2f427ab706"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f7c97a3_765c8e18","line":14,"updated":"2018-05-30 15:47:39.000000000","message":"Can you add a\n\nPartial-Bug: #1712399\n\nhere?","commit_id":"9dbc0cd267b39fa952afca68dc3db31107fa3ef9"}],"oslo_messaging/conffixture.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"aec3dac0ba05adc1de9db6c7a2104688b6bf1d8f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    An example usage::"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.messaging_conf \u003d self.useFixture(messaging.ConfFixture(cfg.CONF))"},{"line_number":40,"context_line":"        self.messaging_conf.transport_url \u003d \u0027fake://vhost\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    :param conf: a ConfigOpts instance"},{"line_number":43,"context_line":"    :type conf: oslo.config.cfg.ConfigOpts"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_d6e7a2ab","line":40,"updated":"2018-05-30 15:47:39.000000000","message":"Actually, if the intent is to set a vhost this syntax is incorrect (the DNS hostname is being set to vhost here).\n\nThe following are valid if you simply want the fake driver (no vhost):\n\n\"fake:\"\n\"fake://\"\n\nTo specify a vhost, it must come directly after the first slash, e.g.:\n\n\"fake:/vhost\"\n\nMost (all?) users won\u0027t need to set a virtual host, so I\u0027d recommend using \"fake://\" as the example.","commit_id":"9dbc0cd267b39fa952afca68dc3db31107fa3ef9"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"aec3dac0ba05adc1de9db6c7a2104688b6bf1d8f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.addCleanup(self.conf.reset)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @property"},{"line_number":126,"context_line":"    def transport_driver(self):"},{"line_number":127,"context_line":"        \"\"\"The transport driver - for example \u0027rabbit\u0027, \u0027amqp\u0027 or \u0027fake\u0027.\"\"\""},{"line_number":128,"context_line":"        return self.conf.rpc_backend"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_618fe674","line":126,"updated":"2018-05-30 15:47:39.000000000","message":"We should mark this transport_driver property as deprecated and point folks to the transport_url property instead.\n\nSee \n\nhttps://docs.openstack.org/debtcollector/queens/reference/index.html#debtcollector.removals.removed_property\n\nthe library follows a 2-release deprecation period, so if we\u0027re deprecating this in Stein, then it can be removed in \"U\"....","commit_id":"9dbc0cd267b39fa952afca68dc3db31107fa3ef9"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"9f534753d46cb28f25bd97f5a06b4423dbc54495","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.addCleanup(self.conf.reset)"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @property"},{"line_number":126,"context_line":"    def transport_driver(self):"},{"line_number":127,"context_line":"        \"\"\"The transport driver - for example \u0027rabbit\u0027, \u0027amqp\u0027 or \u0027fake\u0027.\"\"\""},{"line_number":128,"context_line":"        return self.conf.rpc_backend"},{"line_number":129,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_653cc992","line":126,"in_reply_to":"5f7c97a3_618fe674","updated":"2018-05-31 01:20:37.000000000","message":"Normally, I\u0027d completely agree with you, but this is a fixture for testing, so I\u0027d argue that as soon as all consumers of it have moved to transport_url, we can remove it.","commit_id":"9dbc0cd267b39fa952afca68dc3db31107fa3ef9"}],"oslo_messaging/tests/drivers/test_amqp_driver.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"aec3dac0ba05adc1de9db6c7a2104688b6bf1d8f","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def setUp(self):"},{"line_number":121,"context_line":"        super(TestProtonDriverLoad, self).setUp()"},{"line_number":122,"context_line":"        self.messaging_conf.transport_url \u003d \u0027amqp://vhost\u0027"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    def test_driver_load(self):"},{"line_number":125,"context_line":"        transport \u003d oslo_messaging.get_transport(self.conf)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_41ee6a22","line":122,"updated":"2018-05-30 15:47:39.000000000","message":"just \"amqp://\" should be ok","commit_id":"9dbc0cd267b39fa952afca68dc3db31107fa3ef9"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"aec3dac0ba05adc1de9db6c7a2104688b6bf1d8f","unresolved":false,"context_lines":[{"line_number":750,"context_line":"                                  sasl_config_dir\u003d_dir,"},{"line_number":751,"context_line":"                                  sasl_config_name\u003d\"openstack\")"},{"line_number":752,"context_line":"        self._broker.start()"},{"line_number":753,"context_line":"        self.messaging_conf.transport_url \u003d \u0027amqp://vhost\u0027"},{"line_number":754,"context_line":"        self.conf \u003d self.messaging_conf.conf"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"    def tearDown(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_a1de5e6a","line":753,"updated":"2018-05-30 15:47:39.000000000","message":"ditto","commit_id":"9dbc0cd267b39fa952afca68dc3db31107fa3ef9"}],"oslo_messaging/tests/test_fixture.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"aec3dac0ba05adc1de9db6c7a2104688b6bf1d8f","unresolved":false,"context_lines":[{"line_number":49,"context_line":"    def test_fixture_properties(self):"},{"line_number":50,"context_line":"        conf \u003d self.messaging_conf.conf"},{"line_number":51,"context_line":"        self.messaging_conf.transport_driver \u003d \u0027fake\u0027"},{"line_number":52,"context_line":"        self.messaging_conf.transport_url \u003d \u0027fake://vhost\u0027"},{"line_number":53,"context_line":"        self.assertEqual(\u0027fake\u0027, self.messaging_conf.transport_driver)"},{"line_number":54,"context_line":"        self.assertEqual(\u0027fake\u0027, conf.rpc_backend)"},{"line_number":55,"context_line":"        self.assertEqual(\u0027fake://vhost\u0027, self.messaging_conf.transport_url)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_21d48e47","line":52,"updated":"2018-05-30 15:47:39.000000000","message":"Maybe \"fake:/vhost\" instead in case anyone uses this test as a template/example for others.","commit_id":"9dbc0cd267b39fa952afca68dc3db31107fa3ef9"}]}