)]}'
{"oslo_messaging/conffixture.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"2518306e2a13fcf61a11b8e6caf8ea2985128236","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        self.addCleanup(self.conf.reset)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def transport_driver(self):"},{"line_number":119,"context_line":"        \"\"\"The transport driver - for example \u0027rabbit\u0027, \u0027amqp\u0027 or \u0027fake\u0027.\"\"\""},{"line_number":120,"context_line":"        return self.conf.rpc_backend"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_e320f54b","side":"PARENT","line":118,"updated":"2018-09-05 15:30:05.000000000","message":"We never \"officially\" marked these API\u0027s as deprecated and a handful of projects still reference them:\n\nhttp://codesearch.openstack.org/?q\u003d.*%5C.transport_driver\u0026i\u003dnope\u0026files\u003d.*%5C.py\u0026repos\u003d\n\nWe can either submit patches for those projects or leave these in, mark them deprecated using debtcollector, and modify them to get/set the value of the scheme field from the transport_url instead?\n\nThoughts?\n\nSee transport.py for an example of using urllib.parse.urlparse() to extract the scheme from the url.","commit_id":"90a5bd50775f5682756836897da105aac2cb1d41"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"bcc3899a79af8a49d51c862a9b930d03c732867c","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        self.addCleanup(self.conf.reset)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def transport_driver(self):"},{"line_number":119,"context_line":"        \"\"\"The transport driver - for example \u0027rabbit\u0027, \u0027amqp\u0027 or \u0027fake\u0027.\"\"\""},{"line_number":120,"context_line":"        return self.conf.rpc_backend"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_ac2da9af","side":"PARENT","line":118,"in_reply_to":"3f79a3b5_4963a7de","updated":"2018-09-10 22:24:49.000000000","message":"Which now I can see are linked from the Same Topic block ... hello jetlag, my old friend.","commit_id":"90a5bd50775f5682756836897da105aac2cb1d41"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"8030d169d917fd1733672768fd1de3fcb2d5389f","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        self.addCleanup(self.conf.reset)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def transport_driver(self):"},{"line_number":119,"context_line":"        \"\"\"The transport driver - for example \u0027rabbit\u0027, \u0027amqp\u0027 or \u0027fake\u0027.\"\"\""},{"line_number":120,"context_line":"        return self.conf.rpc_backend"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4f3ac7c4","side":"PARENT","line":118,"in_reply_to":"3f79a3b5_ac2da9af","updated":"2018-09-10 22:29:32.000000000","message":"And I missed neutron-lib, pushed up now.","commit_id":"90a5bd50775f5682756836897da105aac2cb1d41"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"6e89efcd5e9f4549f0af3934aa2e62642317dbab","unresolved":false,"context_lines":[{"line_number":115,"context_line":"        self.addCleanup(self.conf.reset)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    @property"},{"line_number":118,"context_line":"    def transport_driver(self):"},{"line_number":119,"context_line":"        \"\"\"The transport driver - for example \u0027rabbit\u0027, \u0027amqp\u0027 or \u0027fake\u0027.\"\"\""},{"line_number":120,"context_line":"        return self.conf.rpc_backend"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_4963a7de","side":"PARENT","line":118,"in_reply_to":"3f79a3b5_e320f54b","updated":"2018-09-10 21:18:55.000000000","message":"I posted patches for everything first, and waited for most of them to merge before I proposed this change. https://review.openstack.org/574521 for meteos, https://review.openstack.org/575575 for daisycloud-core and https://review.openstack.org/575577 for tacker.","commit_id":"90a5bd50775f5682756836897da105aac2cb1d41"}],"oslo_messaging/tests/test_transport.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"039510bb8962b6968cbbe7b4ff16f7791f49ccc9","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            driver.DriverManager.side_effect \u003d RuntimeError()"},{"line_number":160,"context_line":"        try:"},{"line_number":161,"context_line":"            oslo_messaging.get_transport(self.conf, url\u003dself.url)"},{"line_number":162,"context_line":"            self.assertFalse(True)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"            driver.DriverManager.\\"},{"line_number":165,"context_line":"                assert_called_once_with(\u0027oslo.messaging.drivers\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_5ec5fe08","side":"PARENT","line":162,"updated":"2018-09-18 17:12:44.000000000","message":"Wut?\n\nIt looks like everything after the get_transport call here is dead code since get_transport raises a RuntimeError? At least I\u0027m assuming that was the intent.","commit_id":"3b1b08b74ab12e4460ee3441ff1301a60c8d606d"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"039510bb8962b6968cbbe7b4ff16f7791f49ccc9","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"            driver.DriverManager.side_effect \u003d RuntimeError()"},{"line_number":150,"context_line":"            oslo_messaging.get_transport(self.conf, url\u003dself.url)"},{"line_number":151,"context_line":"            driver.DriverManager.assert_called_once_with("},{"line_number":152,"context_line":"                \u0027oslo.messaging.drivers\u0027, invoke_on_load\u003dTrue,"},{"line_number":153,"context_line":"                invoke_args\u003dinvoke_args, invoke_kwds\u003dinvoke_kwds)"},{"line_number":154,"context_line":"        except Exception as ex:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_9ede36d9","line":151,"updated":"2018-09-18 17:12:44.000000000","message":"I think that means this is meaningless since we never get to this point. I guess it\u0027s an existing problem, but it might be nice to remove this in a followup or subsequent patch set if one is needed.","commit_id":"d3f6ca0b47e2a5a3413b27617d9655f02b191c6a"}],"oslo_messaging/transport.py":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"039510bb8962b6968cbbe7b4ff16f7791f49ccc9","unresolved":false,"context_lines":[{"line_number":359,"context_line":"        else:"},{"line_number":360,"context_line":"            transport \u003d self._transport"},{"line_number":361,"context_line":"        final_transport \u003d transport"},{"line_number":362,"context_line":"        if not self._deprecation_logged and final_transport !\u003d transport:"},{"line_number":363,"context_line":"            # NOTE(sileht): The first step is deprecate this one cycle."},{"line_number":364,"context_line":"            # To ensure deployer have updated they configuration during Ocata"},{"line_number":365,"context_line":"            # Then in P we will deprecate aliases kwargs of TransportURL() and"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_1e40e65e","side":"PARENT","line":362,"range":{"start_line":362,"start_character":44,"end_line":362,"end_character":72},"updated":"2018-09-18 17:12:44.000000000","message":"This is also making me o.O. We just set these two equal on the previous line, how would they ever be !\u003d? Were we not correctly logging the deprecation?\n\nAh, this came from https://github.com/openstack/oslo.messaging/commit/e55f419017200d0026ffb0fb8cfef19833347e4e so it\u0027s only been doing this for a few months. Fair enough.","commit_id":"3b1b08b74ab12e4460ee3441ff1301a60c8d606d"}]}