)]}'
{"oslo/messaging/_executors/base.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"084b747cd747282cf01433bd99e37d9ebb897da9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.conf \u003d conf"},{"line_number":31,"context_line":"        self.listener \u003d listener"},{"line_number":32,"context_line":"        self.callback \u003d callback"},{"line_number":33,"context_line":"        self.reply \u003d reply"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _dispatch(self, incoming):"},{"line_number":36,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9upE%3D","line":33,"updated":"2013-12-06 16:48:37.000000000","message":"I wouldn\u0027t add the reply param in this patch, and instead assume reply\u003dTrue ... since reply\u003dFalse isn\u0027t used yet\n\nI know that\u0027s annoying, but I think it would call out more clearly the change you\u0027re making here - i.e. that we\u0027re now we\u0027re doing the ack() from a different greenthread (with the eventlet executor, at least)","commit_id":"de8865998ac11893d91ca3ec8be91eec42c7c29a"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3e2287da2bd3ab646f1db1773bd44807103745b7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        self.conf \u003d conf"},{"line_number":31,"context_line":"        self.listener \u003d listener"},{"line_number":32,"context_line":"        self.callback \u003d callback"},{"line_number":33,"context_line":"        self.reply \u003d reply"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def _dispatch(self, incoming):"},{"line_number":36,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9XPU%3D","line":33,"in_reply_to":"AAAATn%2F9upE%3D","updated":"2013-12-12 08:31:50.000000000","message":"I have splited/reworked/simplied all this part, to be sure all executor use the listener connection to ack message.","commit_id":"de8865998ac11893d91ca3ec8be91eec42c7c29a"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"084b747cd747282cf01433bd99e37d9ebb897da9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def _dispatch(self, incoming):"},{"line_number":36,"context_line":"        try:"},{"line_number":37,"context_line":"            if self.reply:"},{"line_number":38,"context_line":"                incoming.acknowledge()"},{"line_number":39,"context_line":"            result \u003d self.callback(incoming.ctxt, incoming.message)"},{"line_number":40,"context_line":"            if self.reply:"},{"line_number":41,"context_line":"                incoming.reply(result)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9umI%3D","line":38,"updated":"2013-12-06 16:48:37.000000000","message":"So, this is the bit I\u0027m really suspicious of - how we can acknowledge this message from outside the greenthread\n\ne.g. you\u0027re creating a new connection to do it, but are you sure message.ack() isn\u0027t using the listener connection? If it is, is that safe?\n\nand I\u0027m sure the details of this are different for kombu and python-qpid, so we need to figure out both","commit_id":"de8865998ac11893d91ca3ec8be91eec42c7c29a"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3e2287da2bd3ab646f1db1773bd44807103745b7","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    def _dispatch(self, incoming):"},{"line_number":36,"context_line":"        try:"},{"line_number":37,"context_line":"            if self.reply:"},{"line_number":38,"context_line":"                incoming.acknowledge()"},{"line_number":39,"context_line":"            result \u003d self.callback(incoming.ctxt, incoming.message)"},{"line_number":40,"context_line":"            if self.reply:"},{"line_number":41,"context_line":"                incoming.reply(result)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9XPQ%3D","line":38,"in_reply_to":"AAAATn%2F9umI%3D","updated":"2013-12-12 08:31:50.000000000","message":"I have made some change to make the ack safe.","commit_id":"de8865998ac11893d91ca3ec8be91eec42c7c29a"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"084b747cd747282cf01433bd99e37d9ebb897da9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                incoming.acknowledge()"},{"line_number":44,"context_line":"        except messaging.RequeueMessageException as e:"},{"line_number":45,"context_line":"            _LOG.debug(\u0027Requeue exception during message handling\u0027)"},{"line_number":46,"context_line":"            incoming.requeue()"},{"line_number":47,"context_line":"        except messaging.ExpectedException as e:"},{"line_number":48,"context_line":"            _LOG.debug(\u0027Expected exception during message handling (%s)\u0027 %"},{"line_number":49,"context_line":"                       e.exc_info[1])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9uo0%3D","line":46,"updated":"2013-12-06 16:48:37.000000000","message":"Let\u0027s leave requeue() out of this too - its introduction is a separate thing","commit_id":"de8865998ac11893d91ca3ec8be91eec42c7c29a"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3e2287da2bd3ab646f1db1773bd44807103745b7","unresolved":false,"context_lines":[{"line_number":43,"context_line":"                incoming.acknowledge()"},{"line_number":44,"context_line":"        except messaging.RequeueMessageException as e:"},{"line_number":45,"context_line":"            _LOG.debug(\u0027Requeue exception during message handling\u0027)"},{"line_number":46,"context_line":"            incoming.requeue()"},{"line_number":47,"context_line":"        except messaging.ExpectedException as e:"},{"line_number":48,"context_line":"            _LOG.debug(\u0027Expected exception during message handling (%s)\u0027 %"},{"line_number":49,"context_line":"                       e.exc_info[1])"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9XPM%3D","line":46,"in_reply_to":"AAAATn%2F9uo0%3D","updated":"2013-12-12 08:31:50.000000000","message":"Done","commit_id":"de8865998ac11893d91ca3ec8be91eec42c7c29a"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"31388c7c321af657a4fd5ad21507a04cde8060fd","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.listener \u003d listener"},{"line_number":32,"context_line":"        self.callback \u003d callback"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _dispatch(self, incoming):"},{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            self.callback(incoming.ctxt, dict(incoming.message))"},{"line_number":37,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2FXEc%3D","line":34,"updated":"2014-01-14 16:58:46.000000000","message":"Do we need separate methods to handle the flag about whether or not to reply? I\u0027m worried that having separate exception handling sections split in 2 methods will lead to their behavior drifting apart as we make changes later.","commit_id":"ab1f381cd26c4d3897864a1167dd5bfd2dab200b"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7d65693014d3d85ab3810c9b785408c228aaf510","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.listener \u003d listener"},{"line_number":32,"context_line":"        self.callback \u003d callback"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _dispatch(self, incoming):"},{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            self.callback(incoming.ctxt, dict(incoming.message))"},{"line_number":37,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2BF2k%3D","line":34,"in_reply_to":"AAAAUH%2F%2BOdg%3D","updated":"2014-01-30 07:57:20.000000000","message":"I agree RPC calls don\u0027t need to requeue message.\nI don\u0027t fully understand the question \u0027Are we returning items to the queue now?\u0027 but an other reason why I have two separate methods for notification is we don\u0027t need the ExpectedException.","commit_id":"ab1f381cd26c4d3897864a1167dd5bfd2dab200b"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"286d8d8986deb1f748e6341589e6a91188b11a92","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.listener \u003d listener"},{"line_number":32,"context_line":"        self.callback \u003d callback"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _dispatch(self, incoming):"},{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            self.callback(incoming.ctxt, dict(incoming.message))"},{"line_number":37,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2BOdg%3D","line":34,"in_reply_to":"AAAAUH%2F%2FOaE%3D","updated":"2014-01-28 22:12:50.000000000","message":"That\u0027s a good question. I\u0027m not sure what the expectation is from the consuming apps. Are we returning items to the queue now? I\u0027m pretty sure we want that for notifications, but maybe not for RPC calls.","commit_id":"ab1f381cd26c4d3897864a1167dd5bfd2dab200b"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"0af910e9ba0d1f4ecd38075ac494a78663cd35bb","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        self.listener \u003d listener"},{"line_number":32,"context_line":"        self.callback \u003d callback"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def _dispatch(self, incoming):"},{"line_number":35,"context_line":"        try:"},{"line_number":36,"context_line":"            self.callback(incoming.ctxt, dict(incoming.message))"},{"line_number":37,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2FOaE%3D","line":34,"in_reply_to":"AAAAUH%2F%2FXEc%3D","updated":"2014-01-16 07:57:29.000000000","message":"In later reveiw, the error handling is different between the rpc server and the notification listener:\n\nhttps://review.openstack.org/#/c/61675/7/oslo/messaging/_executors/base.py\n\nhttps://review.openstack.org/#/c/61675/7/oslo/messaging/_executors/impl_eventlet.py\n\nBut the main question, does the rpc mode should be allowed to requeue message ?","commit_id":"ab1f381cd26c4d3897864a1167dd5bfd2dab200b"}],"oslo/messaging/_executors/impl_eventlet.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"5aed9a28e19029f2b8c63b687e77f1d80ea5ba79","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            if exc:"},{"line_number":54,"context_line":"                exit(None, None, None)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    spawn \u003d pool.spawn or eventlet.spawn"},{"line_number":57,"context_line":"    callback \u003d ctxt.__enter__()"},{"line_number":58,"context_line":"    thread \u003d spawn(callback)"},{"line_number":59,"context_line":"    thread.link(complete, ctxt.__exit__)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUX%2F%2FDe4%3D","line":56,"updated":"2014-02-17 12:38:51.000000000","message":"Don\u0027t really love adding unused code (i.e. the pool\u003dNone) support, but not a big deal","commit_id":"697e01093fe1e58abb4c6fc20bd1424be24a5bc0"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"9e90dd48696824ecc55972b5d00c9527a72b49f1","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            if exc:"},{"line_number":54,"context_line":"                exit(None, None, None)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    spawn \u003d pool.spawn or eventlet.spawn"},{"line_number":57,"context_line":"    callback \u003d ctxt.__enter__()"},{"line_number":58,"context_line":"    thread \u003d spawn(callback)"},{"line_number":59,"context_line":"    thread.link(complete, ctxt.__exit__)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUX%2F%2FDJQ%3D","line":56,"in_reply_to":"AAAAUX%2F%2FDe4%3D","updated":"2014-02-17 13:10:15.000000000","message":"Removed","commit_id":"697e01093fe1e58abb4c6fc20bd1424be24a5bc0"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"5aed9a28e19029f2b8c63b687e77f1d80ea5ba79","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                while True:"},{"line_number":87,"context_line":"                    incoming \u003d self.listener.poll()"},{"line_number":88,"context_line":"                    spawn_with(ctxt\u003dself.dispatcher(incoming),"},{"line_number":89,"context_line":"                               pool\u003dself._greenpool)"},{"line_number":90,"context_line":"            except greenlet.GreenletExit:"},{"line_number":91,"context_line":"                return"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUX%2F%2FDes%3D","line":89,"updated":"2014-02-17 12:38:51.000000000","message":"FWIW, I played with this a little before I saw your version and ended up with https://github.com/markmc/oslo.messaging/blob/d5e7fc65a321ebfe91215fdf3a2e5f87e1b1b8c0/oslo/messaging/_executors/impl_eventlet.py#L59-74","commit_id":"697e01093fe1e58abb4c6fc20bd1424be24a5bc0"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"9e90dd48696824ecc55972b5d00c9527a72b49f1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                while True:"},{"line_number":87,"context_line":"                    incoming \u003d self.listener.poll()"},{"line_number":88,"context_line":"                    spawn_with(ctxt\u003dself.dispatcher(incoming),"},{"line_number":89,"context_line":"                               pool\u003dself._greenpool)"},{"line_number":90,"context_line":"            except greenlet.GreenletExit:"},{"line_number":91,"context_line":"                return"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUX%2F%2FDBs%3D","line":89,"in_reply_to":"AAAAUX%2F%2FDes%3D","updated":"2014-02-17 13:10:15.000000000","message":"I keep mine because according the PEP, we must not re-raise the exception if __exit__() return True.","commit_id":"697e01093fe1e58abb4c6fc20bd1424be24a5bc0"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"fa4ef70d9af75051ce8d3d1360633d6d21946268","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                exc \u003d False"},{"line_number":50,"context_line":"                if not exit(**sys.exc_info()):"},{"line_number":51,"context_line":"                    raise"},{"line_number":52,"context_line":"        except Exception:"},{"line_number":53,"context_line":"            if exc:"},{"line_number":54,"context_line":"                exit(None, None, None)"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAUX%2F%2FBnk%3D","line":52,"updated":"2014-02-17 15:24:41.000000000","message":"This method is bugged, I will upload a fix and a test class for this method.","commit_id":"3e047bbd48f90d3d83641fe3a1ae2604c8dbd3ed"}],"oslo/messaging/notify/dispatcher.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"31388c7c321af657a4fd5ad21507a04cde8060fd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    message to the endpoints"},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    sender_expect_reply \u003d False"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, targets, endpoints, serializer):"},{"line_number":44,"context_line":"        self.targets \u003d targets"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2FXGU%3D","line":41,"updated":"2014-01-14 16:58:46.000000000","message":"sender_expects_reply would be more grammatically correct","commit_id":"ab1f381cd26c4d3897864a1167dd5bfd2dab200b"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"5aed9a28e19029f2b8c63b687e77f1d80ea5ba79","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            # NOTE(dhellmann): Remove circular object reference"},{"line_number":70,"context_line":"            # between the current stack frame and the traceback in"},{"line_number":71,"context_line":"            # exc_info."},{"line_number":72,"context_line":"            del exc_info"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _dispatch(self, ctxt, message):"},{"line_number":75,"context_line":"        \"\"\"Dispatch an RPC message to the appropriate endpoint method."}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUX%2F%2FDdw%3D","line":72,"updated":"2014-02-17 12:38:51.000000000","message":"Oh, interesting - I would have thought we\u0027d continue to do the error handling in the greenthread ... https://github.com/markmc/oslo.messaging/blob/d5e7fc65a321ebfe91215fdf3a2e5f87e1b1b8c0/oslo/messaging/notify/dispatcher.py#L99\n\nAny reason you moved the error handling into the greenthread link() callback?","commit_id":"697e01093fe1e58abb4c6fc20bd1424be24a5bc0"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"9e90dd48696824ecc55972b5d00c9527a72b49f1","unresolved":false,"context_lines":[{"line_number":69,"context_line":"            # NOTE(dhellmann): Remove circular object reference"},{"line_number":70,"context_line":"            # between the current stack frame and the traceback in"},{"line_number":71,"context_line":"            # exc_info."},{"line_number":72,"context_line":"            del exc_info"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def _dispatch(self, ctxt, message):"},{"line_number":75,"context_line":"        \"\"\"Dispatch an RPC message to the appropriate endpoint method."}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUX%2F%2FDFA%3D","line":72,"in_reply_to":"AAAAUX%2F%2FDdw%3D","updated":"2014-02-17 13:10:15.000000000","message":"No, ack/requeue must be in the main thread and callback/error in the greenthread I have fixed that.","commit_id":"697e01093fe1e58abb4c6fc20bd1424be24a5bc0"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"5c79a55d39615e05c16d8c05e7684486521a7fb6","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            self._dispatch(incoming.ctxt, incoming.message)"},{"line_number":72,"context_line":"        except Exception:"},{"line_number":73,"context_line":"            # sys.exc_info() is deleted by LOG.exception()."},{"line_number":74,"context_line":"            exc_info \u003d sys.exc_info()"},{"line_number":75,"context_line":"            LOG.error(\u0027Exception during message handling\u0027,"},{"line_number":76,"context_line":"                      exc_info\u003dexc_info)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2FAts%3D","line":73,"updated":"2014-02-17 16:58:31.000000000","message":"LOG.exception() isn\u0027t being called here.\n\nYou should del the local copy of the exception to avoid introducing a cycle between the stack trace and the current stack frame, as the rpc dispatcher does.","commit_id":"7a936b41744c093f72da16b0418c04b08a5fb901"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"942872a510f6e25f4c55b11e22d012be507329d0","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            self._dispatch(incoming.ctxt, incoming.message)"},{"line_number":72,"context_line":"        except Exception:"},{"line_number":73,"context_line":"            # sys.exc_info() is deleted by LOG.exception()."},{"line_number":74,"context_line":"            exc_info \u003d sys.exc_info()"},{"line_number":75,"context_line":"            LOG.error(\u0027Exception during message handling\u0027,"},{"line_number":76,"context_line":"                      exc_info\u003dexc_info)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAUX%2F%2FAro%3D","line":73,"in_reply_to":"AAAAUX%2F%2FAts%3D","updated":"2014-02-17 17:00:02.000000000","message":"Actually, it was like this before, so let\u0027s leave that change for later in the series of patches to avoid derailing your progress.","commit_id":"7a936b41744c093f72da16b0418c04b08a5fb901"}],"oslo/messaging/notify/listener.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"47da9b616a0bef0c3d1e6148377b5ca72b2c6d89","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import logging"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_LOG \u003d logging.getLogger(__name__)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class RequeueMessageException(Exception):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F91IQ%3D","line":19,"updated":"2013-12-05 14:00:14.000000000","message":"looks unused","commit_id":"de8865998ac11893d91ca3ec8be91eec42c7c29a"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3e2287da2bd3ab646f1db1773bd44807103745b7","unresolved":false,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import logging"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"_LOG \u003d logging.getLogger(__name__)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class RequeueMessageException(Exception):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F9jF4%3D","line":19,"in_reply_to":"AAAATn%2F91IQ%3D","updated":"2013-12-12 08:31:50.000000000","message":"removed","commit_id":"de8865998ac11893d91ca3ec8be91eec42c7c29a"}],"oslo/messaging/rpc/dispatcher.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"31388c7c321af657a4fd5ad21507a04cde8060fd","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    \"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    sender_expect_reply \u003d True"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def __init__(self, target, endpoints, serializer):"},{"line_number":76,"context_line":"        \"\"\"Construct a rpc server dispatcher."}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAUH%2F%2FXF4%3D","line":73,"updated":"2014-01-14 16:58:46.000000000","message":"sender_expects_reply","commit_id":"ab1f381cd26c4d3897864a1167dd5bfd2dab200b"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"5aed9a28e19029f2b8c63b687e77f1d80ea5ba79","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    exceptional logging."},{"line_number":48,"context_line":"    \"\"\""},{"line_number":49,"context_line":"    def __init__(self):"},{"line_number":50,"context_line":"        self.exc_info \u003d sys.exc_info()"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class RPCDispatcherError(msg_server.MessagingServerError):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUX%2F%2FDcY%3D","line":50,"updated":"2014-02-17 12:38:51.000000000","message":"Moving this exception here proves to me we\u0027re doing the right thing - the fact that the executor previously needed to know the semantics of this exception was all wrong","commit_id":"697e01093fe1e58abb4c6fc20bd1424be24a5bc0"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"5aed9a28e19029f2b8c63b687e77f1d80ea5ba79","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            # NOTE(dhellmann): Remove circular object reference"},{"line_number":144,"context_line":"            # between the current stack frame and the traceback in"},{"line_number":145,"context_line":"            # exc_info."},{"line_number":146,"context_line":"            del exc_info"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def _dispatch(self, ctxt, message):"},{"line_number":149,"context_line":"        \"\"\"Dispatch an RPC message to the appropriate endpoint method."}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUX%2F%2FDdU%3D","line":146,"updated":"2014-02-17 12:38:51.000000000","message":"You see, here you\u0027re doing that error handling in the greenthread. Which makes sense to me","commit_id":"697e01093fe1e58abb4c6fc20bd1424be24a5bc0"}]}
