)]}'
{"oslo/messaging/_drivers/impl_fake.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"1ea3bcf0ca26b0607ef29f9b37a06e5db3ed0116","unresolved":false,"context_lines":[{"line_number":40,"context_line":"class FakeListener(base.Listener):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, driver, target, exchange):"},{"line_number":43,"context_line":"        super(FakeListener, self).__init__(driver, target)"},{"line_number":44,"context_line":"        self._exchange \u003d exchange"},{"line_number":45,"context_line":"        self._consumers \u003d []"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9DC0%3D","line":43,"updated":"2013-12-17 10:30:52.000000000","message":"I don\u0027t think BaseListener or FakeListener should take a target anymore since it\u0027s not used\n\nIOW move the listener attribute out of BaseListener into AMQPListener and ZmqListener and also make it private (i.e. self._target)","commit_id":"cbe4868a7a0a204dc4a5e8d56d01f5aa730485c0"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7887518045a70124fbaa335c49d81bb6bb420405","unresolved":false,"context_lines":[{"line_number":40,"context_line":"class FakeListener(base.Listener):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self, driver, target, exchange):"},{"line_number":43,"context_line":"        super(FakeListener, self).__init__(driver, target)"},{"line_number":44,"context_line":"        self._exchange \u003d exchange"},{"line_number":45,"context_line":"        self._consumers \u003d []"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9Bnk%3D","line":43,"in_reply_to":"AAAATn%2F9DC0%3D","updated":"2013-12-17 16:16:34.000000000","message":"Done, AMQPListener and ZmqListener don\u0027t use the target too","commit_id":"cbe4868a7a0a204dc4a5e8d56d01f5aa730485c0"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"1ea3bcf0ca26b0607ef29f9b37a06e5db3ed0116","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self._exchange \u003d exchange"},{"line_number":45,"context_line":"        self._consumers \u003d []"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def declare_consumer(self, target, topic, server\u003dNone):"},{"line_number":48,"context_line":"        self._consumers.append((target, topic, server))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def poll(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9DDg%3D","line":47,"updated":"2013-12-17 10:30:52.000000000","message":"target is unused here too, no?","commit_id":"cbe4868a7a0a204dc4a5e8d56d01f5aa730485c0"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7887518045a70124fbaa335c49d81bb6bb420405","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        self._exchange \u003d exchange"},{"line_number":45,"context_line":"        self._consumers \u003d []"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"    def declare_consumer(self, target, topic, server\u003dNone):"},{"line_number":48,"context_line":"        self._consumers.append((target, topic, server))"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def poll(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9Bn8%3D","line":47,"in_reply_to":"AAAATn%2F9DDg%3D","updated":"2013-12-17 16:16:34.000000000","message":"Done","commit_id":"cbe4868a7a0a204dc4a5e8d56d01f5aa730485c0"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"1ea3bcf0ca26b0607ef29f9b37a06e5db3ed0116","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        listener \u003d FakeListener(self, target, exchange)"},{"line_number":162,"context_line":"        listener.declare_consumer(target, target.topic, target.server)"},{"line_number":163,"context_line":"        listener.declare_consumer(target, target.topic)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        return listener"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9DCY%3D","line":163,"updated":"2013-12-17 10:30:52.000000000","message":"I think I\u0027d like declare_consumer() to be underscore prefixed\n\nThe point is that when the server calls listen() and passes the return value to the executor, neither the server nor executor should ever depend on that object having a declare_consumer() method - it is purely an implementation detail of this driver","commit_id":"cbe4868a7a0a204dc4a5e8d56d01f5aa730485c0"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7887518045a70124fbaa335c49d81bb6bb420405","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"        listener \u003d FakeListener(self, target, exchange)"},{"line_number":162,"context_line":"        listener.declare_consumer(target, target.topic, target.server)"},{"line_number":163,"context_line":"        listener.declare_consumer(target, target.topic)"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        return listener"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F9BqY%3D","line":163,"in_reply_to":"AAAATn%2F9DCY%3D","updated":"2013-12-17 16:16:34.000000000","message":"Done","commit_id":"cbe4868a7a0a204dc4a5e8d56d01f5aa730485c0"}]}
