)]}'
{"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"c1ae51ea32ff2f313de8cbbc0dcec7792cdd7f4b","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        if self.max_retries \u003c\u003d 0:"},{"line_number":445,"context_line":"            self.max_retries \u003d None"},{"line_number":446,"context_line":""},{"line_number":447,"context_line":"        self._url \u003d \u0027\u0027"},{"line_number":448,"context_line":"        if url.hosts:"},{"line_number":449,"context_line":"            if url.transport.startswith(\u0027kombu+\u0027):"},{"line_number":450,"context_line":"                LOG.warning(_LW(\u0027Selecting the kombu transport through the \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4bb6adfb","line":447,"updated":"2018-09-05 14:20:26.000000000","message":"We should keep the default virtualhost to \u0027/\u0027","commit_id":"317c03d8a47d2440536e6c5ae2a95e33b3800061"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"c1ae51ea32ff2f313de8cbbc0dcec7792cdd7f4b","unresolved":false,"context_lines":[{"line_number":467,"context_line":"            # NOTE(sileht): url have a + but no hosts"},{"line_number":468,"context_line":"            # (like kombu+memory:///), pass it to kombu as-is"},{"line_number":469,"context_line":"            transport \u003d url.transport.replace(\u0027kombu+\u0027, \u0027\u0027)"},{"line_number":470,"context_line":"            self._url \u003d \"%s://%s\" % (transport, url.virtual_host)"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"        self._initial_pid \u003d os.getpid()"},{"line_number":473,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_454bf185","line":470,"updated":"2018-09-05 14:20:26.000000000","message":"This will generate \"amqp://None\" by default, which is wrong.","commit_id":"6f8198786c7a5d5c26c1c1b2beb6ba99613aa650"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"b521e20bdd6456109d7023f347da56f120350b26","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            self._url \u003d \"%s://\" % transport"},{"line_number":454,"context_line":"            if url.virtual_host:"},{"line_number":455,"context_line":"                self._url +\u003d url.virtual_host"},{"line_number":456,"context_line":"        elif not url.hosts:"},{"line_number":457,"context_line":"            host \u003d oslo_messaging.transport.TransportHost(\u0027\u0027)"},{"line_number":458,"context_line":"            self._url \u003d self._transform_transport_url("},{"line_number":459,"context_line":"                url, host, default_username\u003d\u0027guest\u0027, default_password\u003d\u0027guest\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_f4ab26d4","line":456,"updated":"2018-09-13 13:47:31.000000000","message":"Is the \"elif\" conditional necessary since url.hosts was checked above?  Could this just be \u0027else\u0027?\n\nJust interested - no need to modify the patch.","commit_id":"b0d3bfceb8ea5d2574651e24e347be55f63c3fca"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"bd44bc8d2d8ce9b9b5f31e8498ddeb1698d4cbe4","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            self._url \u003d \"%s://\" % transport"},{"line_number":454,"context_line":"            if url.virtual_host:"},{"line_number":455,"context_line":"                self._url +\u003d url.virtual_host"},{"line_number":456,"context_line":"        elif not url.hosts:"},{"line_number":457,"context_line":"            host \u003d oslo_messaging.transport.TransportHost(\u0027\u0027)"},{"line_number":458,"context_line":"            self._url \u003d self._transform_transport_url("},{"line_number":459,"context_line":"                url, host, default_username\u003d\u0027guest\u0027, default_password\u003d\u0027guest\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_9598a9cc","line":456,"in_reply_to":"3f79a3b5_e33b6a36","updated":"2018-09-13 17:13:25.000000000","message":"I\u0027ve made this change locally, and I will push it up if this review requires more changes.","commit_id":"b0d3bfceb8ea5d2574651e24e347be55f63c3fca"},{"author":{"_account_id":9369,"name":"Steve Kowalik","email":"steven@wedontsleep.org","username":"stevenk"},"change_message_id":"15a3797e0927f510992da8775771232544beb8df","unresolved":false,"context_lines":[{"line_number":453,"context_line":"            self._url \u003d \"%s://\" % transport"},{"line_number":454,"context_line":"            if url.virtual_host:"},{"line_number":455,"context_line":"                self._url +\u003d url.virtual_host"},{"line_number":456,"context_line":"        elif not url.hosts:"},{"line_number":457,"context_line":"            host \u003d oslo_messaging.transport.TransportHost(\u0027\u0027)"},{"line_number":458,"context_line":"            self._url \u003d self._transform_transport_url("},{"line_number":459,"context_line":"                url, host, default_username\u003d\u0027guest\u0027, default_password\u003d\u0027guest\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_e33b6a36","line":456,"in_reply_to":"3f79a3b5_f4ab26d4","updated":"2018-09-13 16:54:40.000000000","message":"It could be, I was trying a few things to get the tests to pass, and this was the explicit check that was working for me so it stayed. I\u0027m happy to switch to else if you\u0027d prefer for cleaner code.","commit_id":"b0d3bfceb8ea5d2574651e24e347be55f63c3fca"}],"oslo_messaging/tests/drivers/test_impl_rabbit.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"c1ae51ea32ff2f313de8cbbc0dcec7792cdd7f4b","unresolved":false,"context_lines":[{"line_number":376,"context_line":"              expected\u003d[\u0027amqp://:@localhost:5672/\u0027])),"},{"line_number":377,"context_line":"        (\u0027virtual_host\u0027,"},{"line_number":378,"context_line":"         dict(url\u003d\u0027rabbit:///vhost\u0027,"},{"line_number":379,"context_line":"              expected\u003d[\u0027amqp://guest:guest@localhost:5672/vhost\u0027])),"},{"line_number":380,"context_line":"        (\u0027no_creds\u0027,"},{"line_number":381,"context_line":"         dict(url\u003d\u0027rabbit://host/virtual_host\u0027,"},{"line_number":382,"context_line":"              expected\u003d[\u0027amqp://:@host:5672/virtual_host\u0027])),"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_05417963","side":"PARENT","line":379,"updated":"2018-09-05 14:20:26.000000000","message":"We must keep this test as the default should not change.","commit_id":"90a5bd50775f5682756836897da105aac2cb1d41"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"d5877c5ec968f0d93f703b4651a0a7afdbd11bf5","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"    scenarios \u003d ["},{"line_number":367,"context_line":"        (\u0027none\u0027, dict(url\u003dNone,"},{"line_number":368,"context_line":"                      expected\u003d[\"amqp://guest:guest@localhost:5672/\"])),"},{"line_number":369,"context_line":"        (\u0027memory\u0027, dict(url\u003d\u0027kombu+memory:////\u0027,"},{"line_number":370,"context_line":"                        expected\u003d[\"memory:///\"])),"},{"line_number":371,"context_line":"        (\u0027empty\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_eaf6285e","side":"PARENT","line":368,"updated":"2018-09-10 18:43:44.000000000","message":"This test must stay.","commit_id":"90a5bd50775f5682756836897da105aac2cb1d41"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"d5877c5ec968f0d93f703b4651a0a7afdbd11bf5","unresolved":false,"context_lines":[{"line_number":370,"context_line":"                        expected\u003d[\"memory:///\"])),"},{"line_number":371,"context_line":"        (\u0027empty\u0027,"},{"line_number":372,"context_line":"         dict(url\u003d\u0027rabbit:///\u0027,"},{"line_number":373,"context_line":"              expected\u003d[\u0027amqp://guest:guest@localhost:5672/\u0027])),"},{"line_number":374,"context_line":"        (\u0027localhost\u0027,"},{"line_number":375,"context_line":"         dict(url\u003d\u0027rabbit://localhost/\u0027,"},{"line_number":376,"context_line":"              expected\u003d[\u0027amqp://:@localhost:5672/\u0027])),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_aa96f0ee","side":"PARENT","line":373,"updated":"2018-09-10 18:43:44.000000000","message":"This test must stay.","commit_id":"90a5bd50775f5682756836897da105aac2cb1d41"}]}
