)]}'
{"oslo_messaging/_drivers/impl_kafka.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"8561b6794c12b6d6da44f6c7eca2c68aafc2e532","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from eventlet import tpool"},{"line_number":16,"context_line":"import logging"},{"line_number":17,"context_line":"import threading"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_fc8eb6cf","line":15,"updated":"2018-09-26 13:29:07.000000000","message":"This should be conditionalized instead of directly imported.  Use the EVENTLET_AVAILABLE flag from oslo_utils to control the import.\n\nIs tpool a hard requirement for kafka support?  If so perhaps that needs to be documented and an driver load failure should occur if eventlet is not available.","commit_id":"98ac50e68f0619ba69f377e93ae0e71d8f2c3883"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"436c61d9468dd77fb6820fe769afb2932fb0a58d","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":"logging.getLogger(\"confluent_kafka\").setLevel(logging.WARN)"},{"line_number":33,"context_line":"logging.getLogger(\"stevedore\").setLevel(logging.WARN)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def unpack_message(msg):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_a57113e2","line":33,"updated":"2018-10-08 15:11:00.000000000","message":"Shouldn\u0027t the application determine the warning level?\nIf this configuration is necessary please add a comment so maintainers won\u0027t think it was accidentally left in and remove it.","commit_id":"b531f7a56d677c5222edfb060ad9d536742a0637"},{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"7fdfc3405180c7cb58d8fa51a8effa009d30ebe7","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":"logging.getLogger(\"confluent_kafka\").setLevel(logging.WARN)"},{"line_number":33,"context_line":"logging.getLogger(\"stevedore\").setLevel(logging.WARN)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def unpack_message(msg):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_659a1414","line":33,"in_reply_to":"3f79a3b5_a57113e2","updated":"2018-10-08 20:34:32.000000000","message":"Done","commit_id":"b531f7a56d677c5222edfb060ad9d536742a0637"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"436c61d9468dd77fb6820fe769afb2932fb0a58d","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    def _close_producer(self):"},{"line_number":305,"context_line":"        with self.producer_lock:"},{"line_number":306,"context_line":"            if self.producer:"},{"line_number":307,"context_line":"                self.producer.flush()"},{"line_number":308,"context_line":"                self.producer \u003d None"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def _ensure_producer(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_a0ca616c","line":307,"updated":"2018-10-08 15:11:00.000000000","message":"May want to catch any exceptions raised here and ignore them since the producer may be in an error state.","commit_id":"b531f7a56d677c5222edfb060ad9d536742a0637"},{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"7fdfc3405180c7cb58d8fa51a8effa009d30ebe7","unresolved":false,"context_lines":[{"line_number":304,"context_line":"    def _close_producer(self):"},{"line_number":305,"context_line":"        with self.producer_lock:"},{"line_number":306,"context_line":"            if self.producer:"},{"line_number":307,"context_line":"                self.producer.flush()"},{"line_number":308,"context_line":"                self.producer \u003d None"},{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    def _ensure_producer(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_a5b90c7d","line":307,"in_reply_to":"3f79a3b5_a0ca616c","updated":"2018-10-08 20:34:32.000000000","message":"Done","commit_id":"b531f7a56d677c5222edfb060ad9d536742a0637"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"436c61d9468dd77fb6820fe769afb2932fb0a58d","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    def __init__(self, ctxt, message):"},{"line_number":332,"context_line":"        super(OsloKafkaMessage, self).__init__(ctxt, message)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def requeue(self):"},{"line_number":335,"context_line":"        LOG.warning(\"requeue is not supported\")"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def reply(self, reply\u003dNone, failure\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_e0a5b9b5","line":334,"updated":"2018-10-08 15:11:00.000000000","message":"Out of curiosity - can Kafka support re-queue?","commit_id":"b531f7a56d677c5222edfb060ad9d536742a0637"},{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"7fdfc3405180c7cb58d8fa51a8effa009d30ebe7","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    def __init__(self, ctxt, message):"},{"line_number":332,"context_line":"        super(OsloKafkaMessage, self).__init__(ctxt, message)"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    def requeue(self):"},{"line_number":335,"context_line":"        LOG.warning(\"requeue is not supported\")"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    def reply(self, reply\u003dNone, failure\u003dNone):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_a55eec4e","line":334,"in_reply_to":"3f79a3b5_e0a5b9b5","updated":"2018-10-08 20:34:32.000000000","message":"Conceptually, kafka could support re-queue through tracking of committed offsets. Currently, driver utilizes synchronous commit without requeue support. I plan to revisit this in the near future.","commit_id":"b531f7a56d677c5222edfb060ad9d536742a0637"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"7b33a163da03567e53e725cf9526470ac8b5b86c","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_messaging._drivers import base"},{"line_number":22,"context_line":"from oslo_messaging._drivers import common as driver_common"},{"line_number":23,"context_line":"from oslo_messaging._drivers.kafka_driver import kafka_options"},{"line_number":24,"context_line":"from oslo_serialization import jsonutils"},{"line_number":25,"context_line":"from oslo_utils import eventletutils"},{"line_number":26,"context_line":"from oslo_utils import importutils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"if eventletutils.EVENTLET_AVAILABLE:"},{"line_number":29,"context_line":"    tpool \u003d importutils.try_import(\u0027eventlet.tpool\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_7f375faf","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":34},"updated":"2018-11-27 22:01:15.000000000","message":"These should technically be above with the confluent_kafka imports as they are also third-party libraries. It was an existing problem with the oslo_serialization import though so consider it a possible followup.","commit_id":"86697c32cb1609ee4600776d8da57fef9d360fca"},{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"9ed5d2d21c10e932b836bc8a97bb64abdb2313c1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from oslo_messaging._drivers import base"},{"line_number":22,"context_line":"from oslo_messaging._drivers import common as driver_common"},{"line_number":23,"context_line":"from oslo_messaging._drivers.kafka_driver import kafka_options"},{"line_number":24,"context_line":"from oslo_serialization import jsonutils"},{"line_number":25,"context_line":"from oslo_utils import eventletutils"},{"line_number":26,"context_line":"from oslo_utils import importutils"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"if eventletutils.EVENTLET_AVAILABLE:"},{"line_number":29,"context_line":"    tpool \u003d importutils.try_import(\u0027eventlet.tpool\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_b1fd1c0b","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":34},"in_reply_to":"3f79a3b5_7f375faf","updated":"2018-11-29 18:09:12.000000000","message":"Done","commit_id":"86697c32cb1609ee4600776d8da57fef9d360fca"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"7b33a163da03567e53e725cf9526470ac8b5b86c","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        self.use_auto_commit \u003d self.driver_conf.enable_auto_commit"},{"line_number":143,"context_line":"        self.max_poll_records \u003d self.driver_conf.max_poll_records"},{"line_number":144,"context_line":"        self._consume_loop_stopped \u003d False"},{"line_number":145,"context_line":"        self.assignment \u003d []"},{"line_number":146,"context_line":"        self.assignment_dict \u003d dict()"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def find_assignment(self, topic, partition):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_5f1703f0","line":145,"updated":"2018-11-27 22:01:15.000000000","message":"Is self.assignment ever actually used or is it just an intermediate step to getting the assignment_dict? I\u0027m not sure we actually need to store this as a member on the object.","commit_id":"86697c32cb1609ee4600776d8da57fef9d360fca"},{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"9ed5d2d21c10e932b836bc8a97bb64abdb2313c1","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        self.use_auto_commit \u003d self.driver_conf.enable_auto_commit"},{"line_number":143,"context_line":"        self.max_poll_records \u003d self.driver_conf.max_poll_records"},{"line_number":144,"context_line":"        self._consume_loop_stopped \u003d False"},{"line_number":145,"context_line":"        self.assignment \u003d []"},{"line_number":146,"context_line":"        self.assignment_dict \u003d dict()"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def find_assignment(self, topic, partition):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_00634348","line":145,"in_reply_to":"3f79a3b5_5f1703f0","updated":"2018-11-29 18:09:12.000000000","message":"Done","commit_id":"86697c32cb1609ee4600776d8da57fef9d360fca"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"7b33a163da03567e53e725cf9526470ac8b5b86c","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                break"},{"line_number":182,"context_line":"            a \u003d self.find_assignment(message.topic(), message.partition())"},{"line_number":183,"context_line":"            if a is None:"},{"line_number":184,"context_line":"                LOG.debug(\"Message for %s received on unassigned partition %d\","},{"line_number":185,"context_line":"                          message.topic(), message.partition())"},{"line_number":186,"context_line":"            else:"},{"line_number":187,"context_line":"                messages.append(message.value())"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_dfb9d3ea","line":184,"updated":"2018-11-27 22:01:15.000000000","message":"Is this expected behavior? It feels like maybe a warning as opposed to debug, but that\u0027s based on a very shallow understanding of what\u0027s going on here.","commit_id":"86697c32cb1609ee4600776d8da57fef9d360fca"},{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"9ed5d2d21c10e932b836bc8a97bb64abdb2313c1","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                break"},{"line_number":182,"context_line":"            a \u003d self.find_assignment(message.topic(), message.partition())"},{"line_number":183,"context_line":"            if a is None:"},{"line_number":184,"context_line":"                LOG.debug(\"Message for %s received on unassigned partition %d\","},{"line_number":185,"context_line":"                          message.topic(), message.partition())"},{"line_number":186,"context_line":"            else:"},{"line_number":187,"context_line":"                messages.append(message.value())"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_e62bc07a","line":184,"in_reply_to":"3f79a3b5_dfb9d3ea","updated":"2018-11-29 18:09:12.000000000","message":"My understanding is that while this condition is not expected to typically happen, due to the asynchronous nature of message polling and partition re-balancing it can occur and should be handled.\n\nI agree with changing to a warning so that operationally, if the condition occurs with frequency it can indicate that the server partition strategy and the consumer patterns should be evaluated.","commit_id":"86697c32cb1609ee4600776d8da57fef9d360fca"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"7b33a163da03567e53e725cf9526470ac8b5b86c","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            try:"},{"line_number":265,"context_line":"                self.producer.produce(topic, message)"},{"line_number":266,"context_line":"            except KafkaException as e:"},{"line_number":267,"context_line":"                LOG.debug(\"Produce message failed: %s\" % str(e))"},{"line_number":268,"context_line":"            except BufferError:"},{"line_number":269,"context_line":"                LOG.debug(\"Produce message queue full, waiting for deliveries\")"},{"line_number":270,"context_line":"                self.producer.poll(0.5)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_df9eb366","line":267,"updated":"2018-11-27 22:01:15.000000000","message":"Same question  here. This seems like an error that should be logged at a higher level.","commit_id":"86697c32cb1609ee4600776d8da57fef9d360fca"},{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"9ed5d2d21c10e932b836bc8a97bb64abdb2313c1","unresolved":false,"context_lines":[{"line_number":264,"context_line":"            try:"},{"line_number":265,"context_line":"                self.producer.produce(topic, message)"},{"line_number":266,"context_line":"            except KafkaException as e:"},{"line_number":267,"context_line":"                LOG.debug(\"Produce message failed: %s\" % str(e))"},{"line_number":268,"context_line":"            except BufferError:"},{"line_number":269,"context_line":"                LOG.debug(\"Produce message queue full, waiting for deliveries\")"},{"line_number":270,"context_line":"                self.producer.poll(0.5)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_263778df","line":267,"in_reply_to":"3f79a3b5_df9eb366","updated":"2018-11-29 18:09:12.000000000","message":"Done","commit_id":"86697c32cb1609ee4600776d8da57fef9d360fca"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"7b33a163da03567e53e725cf9526470ac8b5b86c","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                try:"},{"line_number":306,"context_line":"                    self.producer.flush()"},{"line_number":307,"context_line":"                except KafkaException:"},{"line_number":308,"context_line":"                    LOG.debug(\"Flush error during producer close\")"},{"line_number":309,"context_line":"                self.producer \u003d None"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def _ensure_producer(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_5f8aa31d","line":308,"updated":"2018-11-27 22:01:15.000000000","message":"Ditto my previous log questions.","commit_id":"86697c32cb1609ee4600776d8da57fef9d360fca"},{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"9ed5d2d21c10e932b836bc8a97bb64abdb2313c1","unresolved":false,"context_lines":[{"line_number":305,"context_line":"                try:"},{"line_number":306,"context_line":"                    self.producer.flush()"},{"line_number":307,"context_line":"                except KafkaException:"},{"line_number":308,"context_line":"                    LOG.debug(\"Flush error during producer close\")"},{"line_number":309,"context_line":"                self.producer \u003d None"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    def _ensure_producer(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_e64ae023","line":308,"in_reply_to":"3f79a3b5_5f8aa31d","updated":"2018-11-29 18:09:12.000000000","message":"Done","commit_id":"86697c32cb1609ee4600776d8da57fef9d360fca"}],"oslo_messaging/tests/functional/test_functional.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"436c61d9468dd77fb6820fe769afb2932fb0a58d","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    def test_independent_topics(self):"},{"line_number":411,"context_line":"        get_timeout \u003d 0.5"},{"line_number":412,"context_line":"        if self.url.startswith(\"kafka://\"):"},{"line_number":413,"context_line":"            get_timeout \u003d 5"},{"line_number":414,"context_line":"            self.conf.set_override(\u0027consumer_group\u0027,"},{"line_number":415,"context_line":"                                   \u0027test_independent_topics_a\u0027,"},{"line_number":416,"context_line":"                                   group\u003d\u0027oslo_messaging_kafka\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_200f318c","line":413,"updated":"2018-10-08 15:11:00.000000000","message":"Why does kafka require such a long timeout?   Can you add a comment here with the reason?","commit_id":"b531f7a56d677c5222edfb060ad9d536742a0637"},{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"7fdfc3405180c7cb58d8fa51a8effa009d30ebe7","unresolved":false,"context_lines":[{"line_number":410,"context_line":"    def test_independent_topics(self):"},{"line_number":411,"context_line":"        get_timeout \u003d 0.5"},{"line_number":412,"context_line":"        if self.url.startswith(\"kafka://\"):"},{"line_number":413,"context_line":"            get_timeout \u003d 5"},{"line_number":414,"context_line":"            self.conf.set_override(\u0027consumer_group\u0027,"},{"line_number":415,"context_line":"                                   \u0027test_independent_topics_a\u0027,"},{"line_number":416,"context_line":"                                   group\u003d\u0027oslo_messaging_kafka\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_b02388aa","line":413,"in_reply_to":"3f79a3b5_200f318c","updated":"2018-10-08 20:34:32.000000000","message":"The longer timeout value is necessary due to the delay associated with partition/balancing assignment. The timeouts chosen were based on outcomes of numerous test run results.\n\nA comment was added and I plan to continue to evaluate/maintain appropriate timeouts over the kafka server release horizon.","commit_id":"b531f7a56d677c5222edfb060ad9d536742a0637"}],"releasenotes/notes/kafka-client-library-change-fe16d5a34550db7f.yaml":[{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"7b33a163da03567e53e725cf9526470ac8b5b86c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Threading issues with the kafka-python consumer client were identified"},{"line_number":5,"context_line":"    and documented. The driver has been updated to integrate the"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_9f2efbf5","line":2,"updated":"2018-11-27 22:01:15.000000000","message":"I\u0027m not sure I would put this in the issues section. That\u0027s for known issues with the new code, while this is actually talking about known issues in the old code. To me that makes it a bug fix.\n\nWe might also want an upgrade impact note since this changes the kafka dependency, although since this is an experimental driver I\u0027m not sure anyone should be relying on it in that way.","commit_id":"86697c32cb1609ee4600776d8da57fef9d360fca"},{"author":{"_account_id":20523,"name":"Andy Smith","email":"ansmith@redhat.com","username":"ajssmith"},"change_message_id":"9ed5d2d21c10e932b836bc8a97bb64abdb2313c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"issues:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Threading issues with the kafka-python consumer client were identified"},{"line_number":5,"context_line":"    and documented. The driver has been updated to integrate the"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_f182b4a5","line":2,"in_reply_to":"3f79a3b5_9f2efbf5","updated":"2018-11-29 18:09:12.000000000","message":"Great suggestion, updated release note accordingly (fixes, upgrade)","commit_id":"86697c32cb1609ee4600776d8da57fef9d360fca"}],"setup.cfg":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"8561b6794c12b6d6da44f6c7eca2c68aafc2e532","unresolved":false,"context_lines":[{"line_number":25,"context_line":"amqp1 \u003d"},{"line_number":26,"context_line":"    pyngus\u003e\u003d2.2.0 # Apache-2.0"},{"line_number":27,"context_line":"kafka \u003d"},{"line_number":28,"context_line":"    confluent-kafka\u003e\u003d0.11.5 # Apache-2.0"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[files]"},{"line_number":31,"context_line":"packages \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"3f79a3b5_9753db16","line":28,"updated":"2018-09-26 13:29:07.000000000","message":"If there is a hard dependency on eventlet that should be added here","commit_id":"98ac50e68f0619ba69f377e93ae0e71d8f2c3883"}]}
