)]}'
{"oslo/messaging/_executors/impl_blocking.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"c345c485850ba2818e6fafc691f953141bf17712","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        while self._running:"},{"line_number":39,"context_line":"            incoming \u003d self.listener.poll()"},{"line_number":40,"context_line":"            if self.callback.sender_expect_reply:"},{"line_number":41,"context_line":"                incoming.acknowledge()"},{"line_number":42,"context_line":"                self._dispatch_and_reply(incoming)"},{"line_number":43,"context_line":"            else:"},{"line_number":44,"context_line":"                self._dispatch(incoming)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FXDw%3D","line":41,"updated":"2014-01-14 17:00:55.000000000","message":"Should the message be acknowledged before we know we can process it?","commit_id":"6e3c076b3e16b52148d32e58b419f5dcdb129663"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"109046650e6dbbcc49c2404fb2823230145b8a10","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        while self._running:"},{"line_number":39,"context_line":"            incoming \u003d self.listener.poll()"},{"line_number":40,"context_line":"            if self.callback.sender_expect_reply:"},{"line_number":41,"context_line":"                incoming.acknowledge()"},{"line_number":42,"context_line":"                self._dispatch_and_reply(incoming)"},{"line_number":43,"context_line":"            else:"},{"line_number":44,"context_line":"                self._dispatch(incoming)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2BOcQ%3D","line":41,"in_reply_to":"AAAAUH%2F%2FOQU%3D","updated":"2014-01-28 22:16:23.000000000","message":"OK,  if that\u0027s what we do now, it\u0027s best to keep that behavior for the time being.","commit_id":"6e3c076b3e16b52148d32e58b419f5dcdb129663"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"02f21e03909dc2d6d2e92e0f586e7078cd7990e8","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        while self._running:"},{"line_number":39,"context_line":"            incoming \u003d self.listener.poll()"},{"line_number":40,"context_line":"            if self.callback.sender_expect_reply:"},{"line_number":41,"context_line":"                incoming.acknowledge()"},{"line_number":42,"context_line":"                self._dispatch_and_reply(incoming)"},{"line_number":43,"context_line":"            else:"},{"line_number":44,"context_line":"                self._dispatch(incoming)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2FOQU%3D","line":41,"in_reply_to":"AAAAUH%2F%2FXDw%3D","updated":"2014-01-16 07:56:53.000000000","message":"I have stupidly kept the previous behavior, I think it was acknowledged before because in the rpc mode even we have a error, the message is consumed and a reply is sent to the caller, so the message was acknowledged as soon as possible.\n\nBut perhaps it can be useful for the the rpc layer to be allowed to requeue message, too and in this case the message should be acknowledged after it is consumed (like we need for notification listener).\n\nFor a more complete picture of how looks the code with the requeue message handling: \n\nhttps://review.openstack.org/#/c/61675/7/oslo/messaging/_executors/impl_eventlet.py","commit_id":"6e3c076b3e16b52148d32e58b419f5dcdb129663"}],"oslo/messaging/notify/dispatcher.py":[{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"265a316a5a6dd2694600d6362f1bf19153b7bf0e","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            # between the current stack frame and the traceback in"},{"line_number":71,"context_line":"            # exc_info."},{"line_number":72,"context_line":"            del exc_info"},{"line_number":73,"context_line":"        incoming.acknowledge()"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _dispatch(self, ctxt, message):"},{"line_number":76,"context_line":"        \"\"\"Dispatch an RPC message to the appropriate endpoint method."}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAUX%2F%2FDVw%3D","line":73,"updated":"2014-02-17 12:42:12.000000000","message":"Same thing here, I expected https://github.com/markmc/oslo.messaging/blob/bff18bcbc8cd8d4ca268f78b833f287496087025/oslo/messaging/notify/dispatcher.py#L94-L95","commit_id":"7d2eefd5f947132355a26bb0cdd1c49d52e6b016"}]}