)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"6e7acd914f1f4416097a788d78e18e4c4a8f8253","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP Retry to declare a queue after internal error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: [1]"},{"line_number":10,"context_line":"Without this commit, the client can lose the messages, because the"},{"line_number":11,"context_line":"client does not handler the \u0027AMQP internal error 541\u0027,"},{"line_number":12,"context_line":"read here [2] for details."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_f5a0e744","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":15},"updated":"2019-04-04 13:46:01.000000000","message":"The \u0027Closes-Bug\u0027 directive should cause the launchpad bug to be automatically updated.  I don\u0027t think this syntax works since the launchpad bug was not updated.\n\nBest to move this to the bottom of the comment and use the\n\nCloses-Bug: #1822778\n\nform.  Keep the url footnotes of course!","commit_id":"36c3690792c668d988129897eaf31f00c83cb051"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"d85f352cadb36850ec10d8d99811ebd770e33db4","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Closes-Bug: [1]"},{"line_number":10,"context_line":"Without this commit, the client can lose the messages, because the"},{"line_number":11,"context_line":"client does not handler the \u0027AMQP internal error 541\u0027,"},{"line_number":12,"context_line":"read here [2] for details."},{"line_number":13,"context_line":"The fix retries to create the queue after a delay."},{"line_number":14,"context_line":"When the virtual-host is ready the declare does not fail."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5fc1f717_88caa64c","line":11,"updated":"2019-04-04 14:17:54.000000000","message":"s/handler/handle/","commit_id":"36c3690792c668d988129897eaf31f00c83cb051"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"692e32d5f24a2277bea577ef3af9053d0e34577f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"               default\u003d\u0027AMQPLAIN\u0027,"},{"line_number":108,"context_line":"               deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":109,"context_line":"               help\u003d\u0027The RabbitMQ login method.\u0027),"},{"line_number":110,"context_line":"    cfg.IntOpt(\u0027rabbit_error_retry_backoff\u0027,"},{"line_number":111,"context_line":"               default\u003d2,"},{"line_number":112,"context_line":"               help\u003d\u0027How long to backoff for between retries when connecting\u0027),"},{"line_number":113,"context_line":"    cfg.IntOpt(\u0027rabbit_retry_interval\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_dccf1027","line":110,"updated":"2019-04-04 17:16:35.000000000","message":"This probably doesn\u0027t require its own dedicated configuration setting since it is a somewhat rare timing error.\n\nIn fact I would simply hardcode the backoff right in the exception handling and not bother adding another parameter to the consumer.","commit_id":"36c3690792c668d988129897eaf31f00c83cb051"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"d85f352cadb36850ec10d8d99811ebd770e33db4","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            auto_delete\u003dself.exchange_auto_delete)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    "},{"line_number":248,"context_line":"    "},{"line_number":249,"context_line":"    def declare(self, conn):"},{"line_number":250,"context_line":"        \"\"\"Re-declare the queue after a rabbit (re)connect.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_68717a44","line":247,"updated":"2019-04-04 14:17:54.000000000","message":"remove Tabs","commit_id":"36c3690792c668d988129897eaf31f00c83cb051"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"d85f352cadb36850ec10d8d99811ebd770e33db4","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            else:"},{"line_number":274,"context_line":"                raise"},{"line_number":275,"context_line":"        except kombu.exceptions.ConnectionError as exc:"},{"line_number":276,"context_line":"            # NOTE(gsantomaggio): This exception happens when the connection is established, "},{"line_number":277,"context_line":"            # but it fails to create the queue."},{"line_number":278,"context_line":"            # Add some delay to avoid too many requests to the server. "},{"line_number":279,"context_line":"            # see: https://bugs.launchpad.net/oslo.messaging/+bug/1822778 for details."}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_a877623b","line":276,"updated":"2019-04-04 14:17:54.000000000","message":"remove trail whitespace","commit_id":"36c3690792c668d988129897eaf31f00c83cb051"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"d85f352cadb36850ec10d8d99811ebd770e33db4","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        except kombu.exceptions.ConnectionError as exc:"},{"line_number":276,"context_line":"            # NOTE(gsantomaggio): This exception happens when the connection is established, "},{"line_number":277,"context_line":"            # but it fails to create the queue."},{"line_number":278,"context_line":"            # Add some delay to avoid too many requests to the server. "},{"line_number":279,"context_line":"            # see: https://bugs.launchpad.net/oslo.messaging/+bug/1822778 for details."},{"line_number":280,"context_line":"            # starting from 3.7.0 there is a more specifi error:"},{"line_number":281,"context_line":"            # \"vhost_supervisor_not_running\" maybe we can add more specif error here"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_887ce620","line":278,"updated":"2019-04-04 14:17:54.000000000","message":"remove trail whitespace","commit_id":"36c3690792c668d988129897eaf31f00c83cb051"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"692e32d5f24a2277bea577ef3af9053d0e34577f","unresolved":false,"context_lines":[{"line_number":277,"context_line":"            # but it fails to create the queue."},{"line_number":278,"context_line":"            # Add some delay to avoid too many requests to the server. "},{"line_number":279,"context_line":"            # see: https://bugs.launchpad.net/oslo.messaging/+bug/1822778 for details."},{"line_number":280,"context_line":"            # starting from 3.7.0 there is a more specifi error:"},{"line_number":281,"context_line":"            # \"vhost_supervisor_not_running\" maybe we can add more specif error here"},{"line_number":282,"context_line":"            if exc.code \u003d\u003d 541:"},{"line_number":283,"context_line":"                LOG.error(_LE(\u0027Internal amqp error (541) during queue declare, the vhost could be not ready yet\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_1736d3b5","line":280,"range":{"start_line":280,"start_character":50,"end_line":280,"end_character":57},"updated":"2019-04-04 17:16:35.000000000","message":"nit: spelling","commit_id":"36c3690792c668d988129897eaf31f00c83cb051"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"692e32d5f24a2277bea577ef3af9053d0e34577f","unresolved":false,"context_lines":[{"line_number":278,"context_line":"            # Add some delay to avoid too many requests to the server. "},{"line_number":279,"context_line":"            # see: https://bugs.launchpad.net/oslo.messaging/+bug/1822778 for details."},{"line_number":280,"context_line":"            # starting from 3.7.0 there is a more specifi error:"},{"line_number":281,"context_line":"            # \"vhost_supervisor_not_running\" maybe we can add more specif error here"},{"line_number":282,"context_line":"            if exc.code \u003d\u003d 541:"},{"line_number":283,"context_line":"                LOG.error(_LE(\u0027Internal amqp error (541) during queue declare, the vhost could be not ready yet\u0027"},{"line_number":284,"context_line":"                        \u0027 (retrying in %s seconds). Queue: [%s], Error Message: [%s]\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_d73feb84","line":281,"range":{"start_line":281,"start_character":67,"end_line":281,"end_character":73},"updated":"2019-04-04 17:16:35.000000000","message":"ditto","commit_id":"36c3690792c668d988129897eaf31f00c83cb051"},{"author":{"_account_id":8770,"name":"Ken Giusti","email":"kgiusti@gmail.com","username":"kgiusti"},"change_message_id":"692e32d5f24a2277bea577ef3af9053d0e34577f","unresolved":false,"context_lines":[{"line_number":283,"context_line":"                LOG.error(_LE(\u0027Internal amqp error (541) during queue declare, the vhost could be not ready yet\u0027"},{"line_number":284,"context_line":"                        \u0027 (retrying in %s seconds). Queue: [%s], Error Message: [%s]\u0027),"},{"line_number":285,"context_line":"                        self.rabbit_error_retry_backoff, self.queue_name, exc.message)"},{"line_number":286,"context_line":"                time.sleep(self.rabbit_error_retry_backoff)"},{"line_number":287,"context_line":"                self.queue.declare()"},{"line_number":288,"context_line":"            else:"},{"line_number":289,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_774e3739","line":286,"updated":"2019-04-04 17:16:35.000000000","message":"I\u0027m ok with simply hardcoding a \u00272\u0027 in here - I doubt anyone will want to tune or adjust this timeout.","commit_id":"36c3690792c668d988129897eaf31f00c83cb051"},{"author":{"_account_id":19307,"name":"Antonio Ojea","email":"antonio.ojea.garcia@gmail.com","username":"itsuugo"},"change_message_id":"d85f352cadb36850ec10d8d99811ebd770e33db4","unresolved":false,"context_lines":[{"line_number":438,"context_line":"        self.interval_max \u003d driver_conf.rabbit_interval_max"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        self.rabbit_error_retry_backoff \u003d driver_conf.rabbit_error_retry_backoff"},{"line_number":441,"context_line":"        "},{"line_number":442,"context_line":"        self.login_method \u003d driver_conf.rabbit_login_method"},{"line_number":443,"context_line":"        self.rabbit_ha_queues \u003d driver_conf.rabbit_ha_queues"},{"line_number":444,"context_line":"        self.rabbit_transient_queues_ttl \u003d \\"}],"source_content_type":"text/x-python","patch_set":1,"id":"5fc1f717_e8856a08","line":441,"updated":"2019-04-04 14:17:54.000000000","message":"remove Tab","commit_id":"36c3690792c668d988129897eaf31f00c83cb051"}]}