)]}'
{"oslo_messaging/_drivers/amqp1_driver/addressing.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9feb810e0263ba7c099db3cec10c2573efea854f","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        # TODO(kgiusti): Router support was added in Newton.  Remove this"},{"line_number":279,"context_line":"        # warning post Newton, once the driver has stabilized."},{"line_number":280,"context_line":"        if product \u003d\u003d \"qpid-dispatch-router\":"},{"line_number":281,"context_line":"            w \u003d \"This is the initial release of support for message\" \\"},{"line_number":282,"context_line":"                \" routing technology. Be aware that messages are not\" \\"},{"line_number":283,"context_line":"                \" queued and may be discarded if there are no consumers\" \\"},{"line_number":284,"context_line":"                \" present.\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_e4b63eda","line":281,"range":{"start_line":281,"start_character":68,"end_line":281,"end_character":70},"updated":"2019-04-12 13:21:14.000000000","message":"Can we use brackets instead of this hard line wrapping? We try to avoid that wherever possible. Alternatively, avoid the use of the variable and pass this directly to LOG.warning","commit_id":"58de883e2646a6d055639f1d4a839659cb8d136a"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"ef3435b7edd6a9b3ee6436345b986c16ddcafb97","unresolved":false,"context_lines":[{"line_number":281,"context_line":"            w \u003d \"This is the initial release of support for message\" \\"},{"line_number":282,"context_line":"                \" routing technology. Be aware that messages are not\" \\"},{"line_number":283,"context_line":"                \" queued and may be discarded if there are no consumers\" \\"},{"line_number":284,"context_line":"                \" present.\""},{"line_number":285,"context_line":"            LOG.warning(w)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        if self._mode \u003d\u003d \u0027legacy\u0027 or (self._mode \u003d\u003d \u0027dynamic\u0027 and"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_a48596af","line":284,"updated":"2019-04-12 13:18:55.000000000","message":"I think can use parentheses here and remove this backslash.","commit_id":"58de883e2646a6d055639f1d4a839659cb8d136a"}],"oslo_messaging/_drivers/amqp1_driver/controller.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9feb810e0263ba7c099db3cec10c2573efea854f","unresolved":false,"context_lines":[{"line_number":1251,"context_line":"            # service.  Try to re-establish the connection:"},{"line_number":1252,"context_line":"            if not self._reconnecting:"},{"line_number":1253,"context_line":"                self._reconnecting \u003d True"},{"line_number":1254,"context_line":"                LOG.info(\"delaying reconnect attempt for %d seconds\","},{"line_number":1255,"context_line":"                         self._delay)"},{"line_number":1256,"context_line":"                self.processor.defer(lambda: self._do_reconnect(reason),"},{"line_number":1257,"context_line":"                                     self._delay)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_84cbba51","line":1254,"range":{"start_line":1254,"start_character":26,"end_line":1254,"end_character":27},"updated":"2019-04-12 13:21:14.000000000","message":"unrelated, but could you capitalize this?","commit_id":"58de883e2646a6d055639f1d4a839659cb8d136a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":417,"context_line":"    def sender_remote_closed(self, sender_link, pn_condition):"},{"line_number":418,"context_line":"        # The remote has initiated a close.  This could happen when the message"},{"line_number":419,"context_line":"        # bus is shutting down, or it detected an error"},{"line_number":420,"context_line":"        LOG.warning(\"sender %(addr)s failed due to remote initiated close:\""},{"line_number":421,"context_line":"                    \" condition\u003d%(cond)s\","},{"line_number":422,"context_line":"                    {\u0027addr\u0027: self._address, \u0027cond\u0027: pn_condition})"},{"line_number":423,"context_line":"        self._link.close()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_05ffc401","line":420,"range":{"start_line":420,"start_character":21,"end_line":420,"end_character":22},"updated":"2019-04-12 14:41:33.000000000","message":"nit: think we could capitalize this?","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":428,"context_line":""},{"line_number":429,"context_line":"    def sender_failed(self, sender_link, error):"},{"line_number":430,"context_line":"        \"\"\"Protocol error occurred.\"\"\""},{"line_number":431,"context_line":"        LOG.warning(\"sender %(addr)s failed error\u003d%(error)s\","},{"line_number":432,"context_line":"                    {\u0027addr\u0027: self._address, \u0027error\u0027: error})"},{"line_number":433,"context_line":"        self._handle_sender_closed(str(error))"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_25044015","line":431,"range":{"start_line":431,"start_character":21,"end_line":431,"end_character":22},"updated":"2019-04-12 14:41:33.000000000","message":"ditto","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"}],"oslo_messaging/_drivers/amqpdriver.py":[{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"b8454d8ae8cb65bc382c517318e2b13619e010c7","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                    self._obsolete_reply_queues.add(self.reply_q, self.msg_id)"},{"line_number":158,"context_line":"                    msg \u003d \"The reply {msg_id}s cannot be sent  \" \\"},{"line_number":159,"context_line":"                          \"{reply_q}s reply queue don\u0027t exist after \" \\"},{"line_number":160,"context_line":"                          \"{duration}s sec abandoning...\""},{"line_number":161,"context_line":"                    LOG.info(msg.format("},{"line_number":162,"context_line":"                             msg_id\u003dself.msg_id,"},{"line_number":163,"context_line":"                             reply_q\u003dself.reply_q,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_446dd296","line":160,"updated":"2019-04-12 12:42:20.000000000","message":"I think you must remove the s character after each parameter.","commit_id":"b0e595ab56f4d4219635a336a285f811e33d9209"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"b8454d8ae8cb65bc382c517318e2b13619e010c7","unresolved":false,"context_lines":[{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def _no_reply_log(self, reply_q, msg_id):"},{"line_number":252,"context_line":"        LOG.warning(\"{reply_queue}s doesn\u0027t exists, drop reply to \""},{"line_number":253,"context_line":"                    \"{msg_id}s\".format(reply_queue\u003dreply_q, msg_id\u003dmsg_id))"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"class AMQPListener(base.PollStyleListener):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_c40ea2e4","line":253,"updated":"2019-04-12 12:42:20.000000000","message":"I think you must remove the s character after each parameter.","commit_id":"b0e595ab56f4d4219635a336a285f811e33d9209"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"ef3435b7edd6a9b3ee6436345b986c16ddcafb97","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                    self._obsolete_reply_queues.add(self.reply_q, self.msg_id)"},{"line_number":158,"context_line":"                    msg \u003d \"The reply {msg_id} cannot be sent  \" \\"},{"line_number":159,"context_line":"                          \"{reply_q} reply queue don\u0027t exist after \" \\"},{"line_number":160,"context_line":"                          \"{duration} sec abandoning...\""},{"line_number":161,"context_line":"                    LOG.info(msg.format("},{"line_number":162,"context_line":"                             msg_id\u003dself.msg_id,"},{"line_number":163,"context_line":"                             reply_q\u003dself.reply_q,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_a4aef62b","line":160,"updated":"2019-04-12 13:18:55.000000000","message":"I think you can use parentheses here and remove this backslash.","commit_id":"58de883e2646a6d055639f1d4a839659cb8d136a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9feb810e0263ba7c099db3cec10c2573efea854f","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                    msg \u003d \"The reply {msg_id} cannot be sent  \" \\"},{"line_number":159,"context_line":"                          \"{reply_q} reply queue don\u0027t exist after \" \\"},{"line_number":160,"context_line":"                          \"{duration} sec abandoning...\""},{"line_number":161,"context_line":"                    LOG.info(msg.format("},{"line_number":162,"context_line":"                             msg_id\u003dself.msg_id,"},{"line_number":163,"context_line":"                             reply_q\u003dself.reply_q,"},{"line_number":164,"context_line":"                             duration\u003dduration))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_240be68e","line":161,"range":{"start_line":161,"start_character":32,"end_line":161,"end_character":40},"updated":"2019-04-12 13:21:14.000000000","message":"You shouldn\u0027t need to do this, instead passing the kwargs directly. Same comment about line wrapping applies here. Ditto for rest of file(s)","commit_id":"58de883e2646a6d055639f1d4a839659cb8d136a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        if queues_length \u003e self._wrn_threshold:"},{"line_number":409,"context_line":"            LOG.warning(\u0027Number of call queues is %(queues_length)s, \u0027"},{"line_number":410,"context_line":"                        \u0027greater than warning threshold: %(old_threshold)s\u0027"},{"line_number":411,"context_line":"                        \u0027. There could be a leak. Increasing threshold to:\u0027"},{"line_number":412,"context_line":"                        \u0027 %(threshold)s\u0027,"},{"line_number":413,"context_line":"                        {\u0027queues_length\u0027: queues_length,"},{"line_number":414,"context_line":"                         \u0027old_threshold\u0027: self._wrn_threshold,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_4535ccd9","line":411,"range":{"start_line":411,"start_character":25,"end_line":411,"end_character":27},"updated":"2019-04-12 14:41:33.000000000","message":"nit: you could move this up to the previous line now","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":409,"context_line":"            LOG.warning(\u0027Number of call queues is %(queues_length)s, \u0027"},{"line_number":410,"context_line":"                        \u0027greater than warning threshold: %(old_threshold)s\u0027"},{"line_number":411,"context_line":"                        \u0027. There could be a leak. Increasing threshold to:\u0027"},{"line_number":412,"context_line":"                        \u0027 %(threshold)s\u0027,"},{"line_number":413,"context_line":"                        {\u0027queues_length\u0027: queues_length,"},{"line_number":414,"context_line":"                         \u0027old_threshold\u0027: self._wrn_threshold,"},{"line_number":415,"context_line":"                         \u0027threshold\u0027: self._wrn_threshold * 2})"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_653248f4","line":412,"range":{"start_line":412,"start_character":25,"end_line":412,"end_character":26},"updated":"2019-04-12 14:41:33.000000000","message":"ditto","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                                      ACK_REQUEUE_EVERY_SECONDS_MAX)"},{"line_number":452,"context_line":"            except Exception:"},{"line_number":453,"context_line":"                LOG.exception(\"Failed to process incoming message, \""},{"line_number":454,"context_line":"                              \"retrying...\")"},{"line_number":455,"context_line":"            else:"},{"line_number":456,"context_line":"                current_timeout \u003d ACK_REQUEUE_EVERY_SECONDS_MIN"},{"line_number":457,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_c5569c07","line":454,"updated":"2019-04-12 14:41:33.000000000","message":"As noted, could be one line","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":602,"context_line":"            with self._get_connection(rpc_common.PURPOSE_SEND) as conn:"},{"line_number":603,"context_line":"                if notify:"},{"line_number":604,"context_line":"                    exchange \u003d self._get_exchange(target)"},{"line_number":605,"context_line":"                    LOG.debug(\"{log_msg}NOTIFY exchange \u0027{exchange}\u0027\""},{"line_number":606,"context_line":"                              \" topic \u0027{topic}\u0027\".format(log_msg\u003dlog_msg,"},{"line_number":607,"context_line":"                                                        exchange\u003dexchange,"},{"line_number":608,"context_line":"                                                        topic\u003dtarget.topic))"},{"line_number":609,"context_line":"                    conn.notify_send(exchange, target.topic, msg, retry\u003dretry)"},{"line_number":610,"context_line":"                elif target.fanout:"},{"line_number":611,"context_line":"                    log_msg +\u003d \"FANOUT topic \u0027%(topic)s\u0027\" % {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_a53d90bc","line":608,"range":{"start_line":605,"start_character":0,"end_line":608,"end_character":76},"updated":"2019-04-12 14:41:33.000000000","message":"missed one","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":617,"context_line":"                    exchange \u003d self._get_exchange(target)"},{"line_number":618,"context_line":"                    if target.server:"},{"line_number":619,"context_line":"                        topic \u003d \u0027%s.%s\u0027 % (target.topic, target.server)"},{"line_number":620,"context_line":"                    LOG.debug(\"{log_msg}exchange \u0027{exchange}\u0027\""},{"line_number":621,"context_line":"                              \" topic \u0027{topic}\u0027\".format(log_msg\u003dlog_msg,"},{"line_number":622,"context_line":"                                                        exchange\u003dexchange,"},{"line_number":623,"context_line":"                                                        topic\u003dtopic))"},{"line_number":624,"context_line":"                    conn.topic_send(exchange_name\u003dexchange, topic\u003dtopic,"},{"line_number":625,"context_line":"                                    msg\u003dmsg, timeout\u003dtimeout, retry\u003dretry)"},{"line_number":626,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_85409437","line":623,"range":{"start_line":620,"start_character":0,"end_line":623,"end_character":69},"updated":"2019-04-12 14:41:33.000000000","message":"this too","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"b64bffa6977731c022098d33e578cb896718cffa","unresolved":false,"context_lines":[{"line_number":450,"context_line":"                current_timeout \u003d max(current_timeout * 2,"},{"line_number":451,"context_line":"                                      ACK_REQUEUE_EVERY_SECONDS_MAX)"},{"line_number":452,"context_line":"            except Exception:"},{"line_number":453,"context_line":"                msg \u003d \"Failed to process incoming message, retrying...\""},{"line_number":454,"context_line":"                LOG.exception(msg)"},{"line_number":455,"context_line":"            else:"},{"line_number":456,"context_line":"                current_timeout \u003d ACK_REQUEUE_EVERY_SECONDS_MIN"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_56d46fbd","line":453,"updated":"2019-04-16 10:56:11.000000000","message":"I think is not really necessary to store the message in a variable.","commit_id":"72636d5ddc0517d4c0c73e80157f4b17a5bfa1a2"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"b64bffa6977731c022098d33e578cb896718cffa","unresolved":false,"context_lines":[{"line_number":605,"context_line":"                    LOG.debug(\"%(log_msg)NOTIFY exchange \u0027%(exchange)s\u0027\""},{"line_number":606,"context_line":"                              \" topic \u0027%(topic)s\u0027\" % {\u0027log_msg\u0027: log_msg,"},{"line_number":607,"context_line":"                                                      \u0027exchange\u0027: exchange,"},{"line_number":608,"context_line":"                                                      \u0027topic\u0027: target.topic})"},{"line_number":609,"context_line":"                    conn.notify_send(exchange, target.topic, msg, retry\u003dretry)"},{"line_number":610,"context_line":"                elif target.fanout:"},{"line_number":611,"context_line":"                    log_msg +\u003d \"FANOUT topic \u0027%(topic)s\u0027\" % {"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_36ea0375","line":608,"updated":"2019-04-16 10:56:11.000000000","message":"Why don\u0027t continue to use variable concatenation? In this case, I think it\u0027s more readable.","commit_id":"72636d5ddc0517d4c0c73e80157f4b17a5bfa1a2"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"b64bffa6977731c022098d33e578cb896718cffa","unresolved":false,"context_lines":[{"line_number":620,"context_line":"                    LOG.debug(\"{log_msg}exchange \u0027{exchange}\u0027\""},{"line_number":621,"context_line":"                              \" topic \u0027{topic}\u0027\".format(log_msg\u003dlog_msg,"},{"line_number":622,"context_line":"                                                        exchange\u003dexchange,"},{"line_number":623,"context_line":"                                                        topic\u003dtopic))"},{"line_number":624,"context_line":"                    conn.topic_send(exchange_name\u003dexchange, topic\u003dtopic,"},{"line_number":625,"context_line":"                                    msg\u003dmsg, timeout\u003dtimeout, retry\u003dretry)"},{"line_number":626,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_f6031b41","line":623,"updated":"2019-04-16 10:56:11.000000000","message":"Same here.","commit_id":"72636d5ddc0517d4c0c73e80157f4b17a5bfa1a2"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"45b849ddf6fa0c7f100d20e3dff28e30bd90374b","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                    }"},{"line_number":163,"context_line":"                    LOG.info(\"The reply {msg_id} cannot be sent  \""},{"line_number":164,"context_line":"                             \"{reply_q} reply queue don\u0027t exist after \""},{"line_number":165,"context_line":"                             \"{duration} sec abandoning...\".format(infos))"},{"line_number":166,"context_line":"                    return"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def heartbeat(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fce034c_92c71197","line":165,"updated":"2019-04-18 09:33:03.000000000","message":"That can\u0027t works use **infos to fix that.","commit_id":"01ffe37f40ed04d45a683fe1708e7b71dd4fdc19"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"c3efa076f8fec87177b8ca5512a5d43fd74b84aa","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                    }"},{"line_number":163,"context_line":"                    LOG.info(\"The reply {msg_id} cannot be sent  \""},{"line_number":164,"context_line":"                             \"{reply_q} reply queue don\u0027t exist after \""},{"line_number":165,"context_line":"                             \"{duration} sec abandoning...\".format(infos))"},{"line_number":166,"context_line":"                    return"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def heartbeat(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"3fce034c_1230019f","line":165,"updated":"2019-04-18 09:36:45.000000000","message":"Same comment has before here.","commit_id":"43cee045e789b9aa963d57b94c739a6df728eee9"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b09fd60e96e5beb17b8158600cf8bcfef68253fb","unresolved":false,"context_lines":[{"line_number":162,"context_line":"                    }"},{"line_number":163,"context_line":"                    LOG.info(\"The reply %(msg_id)s cannot be sent  \""},{"line_number":164,"context_line":"                             \"%(reply_q)s reply queue don\u0027t exist after \""},{"line_number":165,"context_line":"                             \"%(duration)s sec abandoning...\" % infos)"},{"line_number":166,"context_line":"                    return"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def heartbeat(self):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fce034c_6debaadb","line":165,"range":{"start_line":165,"start_character":61,"end_line":165,"end_character":63},"updated":"2019-04-18 10:50:02.000000000","message":",","commit_id":"bba51a2858deb1805faa722545f2ac04431eb37a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b09fd60e96e5beb17b8158600cf8bcfef68253fb","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def _no_reply_log(self, reply_q, msg_id):"},{"line_number":253,"context_line":"        LOG.warning(\"{reply_queue} doesn\u0027t exists, drop reply to \""},{"line_number":254,"context_line":"                    \"{msg_id}\".format(reply_queue\u003dreply_q, msg_id\u003dmsg_id))"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"class AMQPListener(base.PollStyleListener):"}],"source_content_type":"text/x-python","patch_set":7,"id":"3fce034c_edb8fae5","line":254,"range":{"start_line":254,"start_character":30,"end_line":254,"end_character":38},"updated":"2019-04-18 10:50:02.000000000","message":"You can\u0027t use this. Use:\n\n  \"{msg_id}\", {\u0027reply_queue\u0027: reply_q, ...})\n\nAs below","commit_id":"bba51a2858deb1805faa722545f2ac04431eb37a"}],"oslo_messaging/_drivers/common.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    This exception is raised if the rpc_response_timeout is reached while"},{"line_number":102,"context_line":"    waiting for a response from the remote side."},{"line_number":103,"context_line":"    \"\"\""},{"line_number":104,"context_line":"    msg_fmt \u003d \u0027Timeout while waiting on RPC response - \u0027 \\"},{"line_number":105,"context_line":"              \u0027topic: \"%(topic)s\", RPC method: \"%(method)s\" \u0027 \\"},{"line_number":106,"context_line":"              \u0027info: \"%(info)s\"\u0027"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_454aac55","line":104,"range":{"start_line":104,"start_character":57,"end_line":104,"end_character":58},"updated":"2019-04-12 14:41:33.000000000","message":"and more","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"class UnsupportedRpcVersion(RPCException):"},{"line_number":135,"context_line":"    msg_fmt \u003d \"Specified RPC version, %(version)s, not supported by \" \\"},{"line_number":136,"context_line":"              \"this endpoint.\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"class UnsupportedRpcEnvelopeVersion(RPCException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_e5a958df","line":136,"range":{"start_line":135,"start_character":14,"end_line":136,"end_character":30},"updated":"2019-04-12 14:41:33.000000000","message":"Hmm, we translate all these in nova. Are you sure they shouldn\u0027t be translated here too?\n\nSame comments on using brackets instead of backslashes here","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"105c93da4c8677a3f472e5698027ccc9d01f5f47","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"class UnsupportedRpcVersion(RPCException):"},{"line_number":135,"context_line":"    msg_fmt \u003d \"Specified RPC version, %(version)s, not supported by \" \\"},{"line_number":136,"context_line":"              \"this endpoint.\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"class UnsupportedRpcEnvelopeVersion(RPCException):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_e7994479","line":136,"range":{"start_line":135,"start_character":14,"end_line":136,"end_character":30},"in_reply_to":"3fce034c_e5a958df","updated":"2019-04-15 10:14:18.000000000","message":"Not sure... we can\u0027t wait for another review on this point to be sure about this.","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"b64bffa6977731c022098d33e578cb896718cffa","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    \"\"\""},{"line_number":104,"context_line":"    msg_fmt \u003d \u0027Timeout while waiting on RPC response - \u0027"},{"line_number":105,"context_line":"    msg_fmt +\u003d \u0027topic: \"%(topic)s\", RPC method: \"%(method)s\" \u0027"},{"line_number":106,"context_line":"    msg_fmt +\u003d \u0027info: \"%(info)s\"\u0027"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def __init__(self, info\u003dNone, topic\u003dNone, method\u003dNone):"},{"line_number":109,"context_line":"        \"\"\"Initiates Timeout object."}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_56a22f4d","line":106,"updated":"2019-04-16 10:56:11.000000000","message":"Why don\u0027t use parentheses, same before? In this case, the concatenation is not necessary.","commit_id":"72636d5ddc0517d4c0c73e80157f4b17a5bfa1a2"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"b64bffa6977731c022098d33e578cb896718cffa","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"class UnsupportedRpcVersion(RPCException):"},{"line_number":135,"context_line":"    msg_fmt \u003d \"Specified RPC version, %(version)s, not supported by \""},{"line_number":136,"context_line":"    msg_fmt +\u003d \"this endpoint.\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"class UnsupportedRpcEnvelopeVersion(RPCException):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_1684a7b0","line":136,"updated":"2019-04-16 10:56:11.000000000","message":"Same here.","commit_id":"72636d5ddc0517d4c0c73e80157f4b17a5bfa1a2"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"b64bffa6977731c022098d33e578cb896718cffa","unresolved":false,"context_lines":[{"line_number":138,"context_line":""},{"line_number":139,"context_line":"class UnsupportedRpcEnvelopeVersion(RPCException):"},{"line_number":140,"context_line":"    msg_fmt \u003d \"Specified RPC envelope version, %(version)s, \" \\"},{"line_number":141,"context_line":"              \"not supported by this endpoint.\""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"class RpcVersionCapError(RPCException):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_36b8c374","line":141,"updated":"2019-04-16 10:56:11.000000000","message":"Please use parentheses here.","commit_id":"72636d5ddc0517d4c0c73e80157f4b17a5bfa1a2"}],"oslo_messaging/_drivers/impl_rabbit.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9feb810e0263ba7c099db3cec10c2573efea854f","unresolved":false,"context_lines":[{"line_number":313,"context_line":"        try:"},{"line_number":314,"context_line":"            self.callback(RabbitMessage(message))"},{"line_number":315,"context_line":"        except Exception:"},{"line_number":316,"context_line":"            LOG.exception(\"Failed to process message\""},{"line_number":317,"context_line":"                          \" ... skipping it.\")"},{"line_number":318,"context_line":"            message.reject()"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_84f97a81","line":317,"range":{"start_line":316,"start_character":52,"end_line":317,"end_character":27},"updated":"2019-04-12 13:21:14.000000000","message":"nit: this could be one line","commit_id":"58de883e2646a6d055639f1d4a839659cb8d136a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"9feb810e0263ba7c099db3cec10c2573efea854f","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        try:"},{"line_number":581,"context_line":"            return cls._SSL_PROTOCOLS[key]"},{"line_number":582,"context_line":"        except KeyError:"},{"line_number":583,"context_line":"            raise RuntimeError(\"Invalid SSL version : %s\" % version)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"    def _transform_transport_url(self, url, host, default_username\u003d\u0027\u0027,"},{"line_number":586,"context_line":"                                 default_password\u003d\u0027\u0027, default_hostname\u003d\u0027\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_a43b5636","line":583,"range":{"start_line":583,"start_character":0,"end_line":583,"end_character":68},"updated":"2019-04-12 13:21:14.000000000","message":"Don\u0027t we still translate exceptions?","commit_id":"58de883e2646a6d055639f1d4a839659cb8d136a"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"ed61048776cf3e58830551f77e55f4e59c1fd2e9","unresolved":false,"context_lines":[{"line_number":580,"context_line":"        try:"},{"line_number":581,"context_line":"            return cls._SSL_PROTOCOLS[key]"},{"line_number":582,"context_line":"        except KeyError:"},{"line_number":583,"context_line":"            raise RuntimeError(\"Invalid SSL version : %s\" % version)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"    def _transform_transport_url(self, url, host, default_username\u003d\u0027\u0027,"},{"line_number":586,"context_line":"                                 default_password\u003d\u0027\u0027, default_hostname\u003d\u0027\u0027):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_1f515337","line":583,"range":{"start_line":583,"start_character":0,"end_line":583,"end_character":68},"in_reply_to":"3fce034c_a43b5636","updated":"2019-04-12 13:56:12.000000000","message":"I don\u0027t know I\u0027m not sure if we need to continue to translate exceptions but this is the only one translated exception in the whole project... so I guess we can ignore it.","commit_id":"58de883e2646a6d055639f1d4a839659cb8d136a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":743,"context_line":"            # is still broken"},{"line_number":744,"context_line":"            info \u003d {\u0027err_str\u0027: exc, \u0027retry\u0027: retry}"},{"line_number":745,"context_line":"            info.update(self.connection.info())"},{"line_number":746,"context_line":"            msg \u003d \u0027Unable to connect to AMQP server on \u0027 \\"},{"line_number":747,"context_line":"                  \u0027%(hostname)s:%(port)s after %(retry)s \u0027 \\"},{"line_number":748,"context_line":"                  \u0027tries: %(err_str)s\u0027 % info"},{"line_number":749,"context_line":"            LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_65b56831","line":746,"range":{"start_line":746,"start_character":57,"end_line":746,"end_character":58},"updated":"2019-04-12 14:41:33.000000000","message":"missed this","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"},{"author":{"_account_id":29222,"name":"Natal Ngétal","email":"hobbestigrou@erakis.eu","username":"hobbestigrou"},"change_message_id":"b64bffa6977731c022098d33e578cb896718cffa","unresolved":false,"context_lines":[{"line_number":745,"context_line":"            info.update(self.connection.info())"},{"line_number":746,"context_line":"            msg \u003d \u0027Unable to connect to AMQP server on \u0027"},{"line_number":747,"context_line":"            msg +\u003d \u0027%(hostname)s:%(port)s after %(retry)s \u0027"},{"line_number":748,"context_line":"            msg +\u003d \u0027tries: %(err_str)s\u0027 % info"},{"line_number":749,"context_line":"            LOG.error(msg)"},{"line_number":750,"context_line":"            raise exceptions.MessageDeliveryFailure(msg)"},{"line_number":751,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_f676bbd8","line":748,"updated":"2019-04-16 10:56:11.000000000","message":"Why don\u0027t use parentheses, same before? In this case, the concatenation is not necessary.","commit_id":"72636d5ddc0517d4c0c73e80157f4b17a5bfa1a2"}],"oslo_messaging/notify/messaging.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            except Exception:"},{"line_number":71,"context_line":"                LOG.exception(\"Could not send notification to %(topic)s. \""},{"line_number":72,"context_line":"                              \"Payload\u003d%(message)s\","},{"line_number":73,"context_line":"                              dict(topic\u003dtopic, message\u003dmessage))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class MessagingV2Driver(MessagingDriver):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_e5f718f5","line":73,"range":{"start_line":73,"start_character":30,"end_line":73,"end_character":64},"updated":"2019-04-12 14:41:33.000000000","message":"unrelated nit: might switch this to {} syntax","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"}],"oslo_messaging/notify/middleware.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            return fn(*args, **kwargs)"},{"line_number":38,"context_line":"        except Exception as e:"},{"line_number":39,"context_line":"            LOG.exception(\u0027An exception occurred processing \u0027"},{"line_number":40,"context_line":"                          \u0027the API call: %s \u0027 % e)"},{"line_number":41,"context_line":"    return wrapped"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_05e90419","line":40,"range":{"start_line":40,"start_character":46,"end_line":40,"end_character":49},"updated":"2019-04-12 14:41:33.000000000","message":"whoops","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"105c93da4c8677a3f472e5698027ccc9d01f5f47","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            return fn(*args, **kwargs)"},{"line_number":38,"context_line":"        except Exception as e:"},{"line_number":39,"context_line":"            LOG.exception(\u0027An exception occurred processing \u0027"},{"line_number":40,"context_line":"                          \u0027the API call: %s \u0027 % e)"},{"line_number":41,"context_line":"    return wrapped"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_6a443b1c","line":40,"range":{"start_line":40,"start_character":46,"end_line":40,"end_character":49},"in_reply_to":"3fce034c_05e90419","updated":"2019-04-15 10:14:18.000000000","message":"I guess you speak about i18n","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b09fd60e96e5beb17b8158600cf8bcfef68253fb","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            return fn(*args, **kwargs)"},{"line_number":38,"context_line":"        except Exception as e:"},{"line_number":39,"context_line":"            LOG.exception(\u0027An exception occurred processing \u0027"},{"line_number":40,"context_line":"                          \u0027the API call: %s \u0027 % e)"},{"line_number":41,"context_line":"    return wrapped"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_caf0cfcc","line":40,"range":{"start_line":40,"start_character":46,"end_line":40,"end_character":49},"in_reply_to":"3fce034c_6a443b1c","updated":"2019-04-18 10:50:02.000000000","message":"No, I mean we shouldn\u0027t be using string interpolation here. Sorry I wasn\u0027t clear","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b09fd60e96e5beb17b8158600cf8bcfef68253fb","unresolved":false,"context_lines":[{"line_number":37,"context_line":"            return fn(*args, **kwargs)"},{"line_number":38,"context_line":"        except Exception as e:"},{"line_number":39,"context_line":"            LOG.exception(\u0027An exception occurred processing \u0027"},{"line_number":40,"context_line":"                          \u0027the API call: %s \u0027 % e)"},{"line_number":41,"context_line":"    return wrapped"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3fce034c_eaeb4bd9","line":40,"range":{"start_line":40,"start_character":45,"end_line":40,"end_character":47},"updated":"2019-04-18 10:50:02.000000000","message":"s/ %/, /","commit_id":"72636d5ddc0517d4c0c73e80157f4b17a5bfa1a2"}],"oslo_messaging/notify/notifier.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            except Exception as e:"},{"line_number":313,"context_line":"                _LOG.exception(\"Problem \u0027%(e)s\u0027 attempting to send to \""},{"line_number":314,"context_line":"                               \"notification system. Payload\u003d%(payload)s\","},{"line_number":315,"context_line":"                               dict(e\u003de, payload\u003dpayload))"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        if self._driver_mgr.extensions:"},{"line_number":318,"context_line":"            self._driver_mgr.map(do_notify)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_a5d91084","line":315,"range":{"start_line":315,"start_character":31,"end_line":315,"end_character":57},"updated":"2019-04-12 14:41:33.000000000","message":"unrelated nit: {} style?","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"}],"oslo_messaging/rpc/server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        except Exception:"},{"line_number":182,"context_line":"            LOG.exception(\"Can not send reply for message\")"},{"line_number":183,"context_line":"        finally:"},{"line_number":184,"context_line":"                # NOTE(dhellmann): Remove circular object reference"},{"line_number":185,"context_line":"                # between the current stack frame and the traceback in"},{"line_number":186,"context_line":"                # exc_info."},{"line_number":187,"context_line":"                del failure"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"def get_rpc_server(transport, target, endpoints,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_65e32835","line":187,"range":{"start_line":184,"start_character":0,"end_line":187,"end_character":27},"updated":"2019-04-12 14:41:33.000000000","message":"weird","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"}],"oslo_messaging/server.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6bc4395d83b0634f827675191ddd27526de8c64d","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        \"\"\""},{"line_number":397,"context_line":"        if self._started:"},{"line_number":398,"context_line":"            LOG.warning(\u0027The server has already been started. Ignoring\u0027"},{"line_number":399,"context_line":"                        \u0027 the redundant call to start().\u0027)"},{"line_number":400,"context_line":"            return"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        self._started \u003d True"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fce034c_05d2645d","line":399,"range":{"start_line":399,"start_character":25,"end_line":399,"end_character":26},"updated":"2019-04-12 14:41:33.000000000","message":"nit: this should be on the previous line","commit_id":"1f6cd6bbd0307f8b062ea3f1a613224b55649e57"}]}