)]}'
{"doc/source/admin/kafka.rst":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f5c88a46feeb098480f47d874444f97ffe1a917c","unresolved":false,"context_lines":[{"line_number":183,"context_line":"producer_batch_size"},{"line_number":184,"context_line":"    The maximum number of messages batched into one message set"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"compression_type"},{"line_number":187,"context_line":"    The compression type for all data generated by the producer"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Security Options"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9fb8cfa7_9a7b50f3","line":186,"range":{"start_line":186,"start_character":0,"end_line":186,"end_character":16},"updated":"2019-06-14 11:41:40.000000000","message":"s/compression_type/compression_codec/","commit_id":"f9c61bc533be8c6a6388b72dbde2b0c8f98fa6bd"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"83c051b46d6e3fb6f491ee94b99a4173bdbfc776","unresolved":false,"context_lines":[{"line_number":183,"context_line":"producer_batch_size"},{"line_number":184,"context_line":"    The maximum number of messages batched into one message set"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"compression_codec"},{"line_number":187,"context_line":"    The compression codec for all data generated by the producer"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"Security Options"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9fb8cfa7_47462f24","line":186,"updated":"2019-06-18 11:39:40.000000000","message":"I think we also need to refer the valid choices here (none, gzip, snappy, lz4, zstd) and maybe adding some link to the official documentation too.\n\nThoughts?","commit_id":"64fd4351aadaa10f644956d793e9d488996aa7b9"}],"oslo_messaging/_drivers/impl_kafka.py":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f5c88a46feeb098480f47d874444f97ffe1a917c","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        super(ProducerConnection, self).__init__(conf, url)"},{"line_number":256,"context_line":"        self.batch_size \u003d self.driver_conf.producer_batch_size"},{"line_number":257,"context_line":"        self.linger_ms \u003d self.driver_conf.producer_batch_timeout * 1000"},{"line_number":258,"context_line":"        self.compression_type \u003d self.driver_conf.compression_type"},{"line_number":259,"context_line":"        self.producer \u003d None"},{"line_number":260,"context_line":"        self.producer_lock \u003d threading.Lock()"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_5a0cf892","line":258,"range":{"start_line":258,"start_character":13,"end_line":258,"end_character":29},"updated":"2019-06-14 11:41:40.000000000","message":"Same things, why do not reuse `compression_codec` here too?","commit_id":"f9c61bc533be8c6a6388b72dbde2b0c8f98fa6bd"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f5c88a46feeb098480f47d874444f97ffe1a917c","unresolved":false,"context_lines":[{"line_number":255,"context_line":"        super(ProducerConnection, self).__init__(conf, url)"},{"line_number":256,"context_line":"        self.batch_size \u003d self.driver_conf.producer_batch_size"},{"line_number":257,"context_line":"        self.linger_ms \u003d self.driver_conf.producer_batch_timeout * 1000"},{"line_number":258,"context_line":"        self.compression_type \u003d self.driver_conf.compression_type"},{"line_number":259,"context_line":"        self.producer \u003d None"},{"line_number":260,"context_line":"        self.producer_lock \u003d threading.Lock()"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_1a2a00da","line":258,"range":{"start_line":258,"start_character":49,"end_line":258,"end_character":65},"updated":"2019-06-14 11:41:40.000000000","message":"idem","commit_id":"f9c61bc533be8c6a6388b72dbde2b0c8f98fa6bd"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f5c88a46feeb098480f47d874444f97ffe1a917c","unresolved":false,"context_lines":[{"line_number":318,"context_line":"                \u0027bootstrap.servers\u0027: \",\".join(self.hostaddrs),"},{"line_number":319,"context_line":"                \u0027linger.ms\u0027: self.linger_ms,"},{"line_number":320,"context_line":"                \u0027batch.num.messages\u0027: self.batch_size,"},{"line_number":321,"context_line":"                \u0027compression.codec\u0027: self.compression_type,"},{"line_number":322,"context_line":"                \u0027security.protocol\u0027: self.security_protocol,"},{"line_number":323,"context_line":"                \u0027sasl.mechanism\u0027: self.sasl_mechanism,"},{"line_number":324,"context_line":"                \u0027sasl.username\u0027: self.username,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_3a258409","line":321,"range":{"start_line":321,"start_character":42,"end_line":321,"end_character":58},"updated":"2019-06-14 11:41:40.000000000","message":"idem","commit_id":"f9c61bc533be8c6a6388b72dbde2b0c8f98fa6bd"}],"oslo_messaging/_drivers/kafka_driver/kafka_options.py":[{"author":{"_account_id":29364,"name":"Gabriele Santomaggio","email":"g.santomaggio@gmail.com","username":"gsantomaggio"},"change_message_id":"065d89ef2bc4fc2fbc69a9270b6b68fb5721cd4f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.IntOpt(\u0027producer_batch_size\u0027, default\u003d16384,"},{"line_number":49,"context_line":"               help\u003d\u0027Size of batch for the producer async send\u0027),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027compression_type\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027The compression type for all data generated by the \u0027"},{"line_number":53,"context_line":"                    \u0027producer. Valid values are: gzip, snappy, lz4. If not \u0027"},{"line_number":54,"context_line":"                    \u0027set, compression will not be used.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_ec8e1e2d","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":34},"updated":"2019-06-04 08:18:52.000000000","message":"I am not sure about the default value, I tested the compression using this gist [1].\n\nThe values \"\u0027compression.codec\u0027 \u003d  \u0027\u0027\" and \"\u0027compression.codec\u0027: None\" are not valid values.\n\nUnless I missed something, should the default value \u003d \u0027None\u0027 ?\n\n\n\n1 - https://gist.github.com/Gsantomaggio/b9c1b89ad1685053c3c9cfc472cdedd4","commit_id":"cf51f2a371550c4a9cead79316e5addb08e4deea"},{"author":{"_account_id":29364,"name":"Gabriele Santomaggio","email":"g.santomaggio@gmail.com","username":"gsantomaggio"},"change_message_id":"d9dc78a6741539ae2dad8c00f00b87ded4d8954b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.IntOpt(\u0027producer_batch_size\u0027, default\u003d16384,"},{"line_number":49,"context_line":"               help\u003d\u0027Size of batch for the producer async send\u0027),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027compression_type\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027The compression type for all data generated by the \u0027"},{"line_number":53,"context_line":"                    \u0027producer. Valid values are: gzip, snappy, lz4. If not \u0027"},{"line_number":54,"context_line":"                    \u0027set, compression will not be used.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_4cdacae9","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":34},"in_reply_to":"9fb8cfa7_4c272a14","updated":"2019-06-04 08:29:50.000000000","message":"Ok perfect, I did not test your code but I tested only the values:\n\np \u003d Producer({\u0027bootstrap.servers\u0027: \u0027localhost\u0027, \u0027compression.codec\u0027: None})\n\nraises an exception:\n\n```\n  p \u003d Producer({\u0027bootstrap.servers\u0027: \u0027localhost\u0027, \u0027compression.codec\u0027: None})\ncimpl.KafkaException: KafkaError{code\u003d_INVALID_ARG,val\u003d-186,str\u003d\"Configuration property \"compression.codec\" cannot be set to empty value\"}\n```\n\nbut ok, it was just a doubt.","commit_id":"cf51f2a371550c4a9cead79316e5addb08e4deea"},{"author":{"_account_id":20100,"name":"Shaoman Zhang","email":"zhang.shaoman@zte.com.cn","username":"zhang.shaoman"},"change_message_id":"022259eb70535bf0b820ccfadb54f649a4a8b198","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.IntOpt(\u0027producer_batch_size\u0027, default\u003d16384,"},{"line_number":49,"context_line":"               help\u003d\u0027Size of batch for the producer async send\u0027),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027compression_type\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027The compression type for all data generated by the \u0027"},{"line_number":53,"context_line":"                    \u0027producer. Valid values are: gzip, snappy, lz4. If not \u0027"},{"line_number":54,"context_line":"                    \u0027set, compression will not be used.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_724c33c7","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":34},"in_reply_to":"9fb8cfa7_4cdacae9","updated":"2019-06-05 03:00:39.000000000","message":"Sorry, i make a mistake, \u0027compression.codec\u0027 can not be None, should be \u0027none\u0027 indeed.\nI will fix it immediately, thx.","commit_id":"cf51f2a371550c4a9cead79316e5addb08e4deea"},{"author":{"_account_id":20100,"name":"Shaoman Zhang","email":"zhang.shaoman@zte.com.cn","username":"zhang.shaoman"},"change_message_id":"04c4e089306c267803da0b856bda810ad4fd7a9f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.IntOpt(\u0027producer_batch_size\u0027, default\u003d16384,"},{"line_number":49,"context_line":"               help\u003d\u0027Size of batch for the producer async send\u0027),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027compression_type\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027The compression type for all data generated by the \u0027"},{"line_number":53,"context_line":"                    \u0027producer. Valid values are: gzip, snappy, lz4. If not \u0027"},{"line_number":54,"context_line":"                    \u0027set, compression will not be used.\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fb8cfa7_4c272a14","line":51,"range":{"start_line":51,"start_character":4,"end_line":51,"end_character":34},"in_reply_to":"9fb8cfa7_ec8e1e2d","updated":"2019-06-04 08:25:08.000000000","message":"If not set, the default value is None. That means no compression will be used.\nthx.","commit_id":"cf51f2a371550c4a9cead79316e5addb08e4deea"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f5c88a46feeb098480f47d874444f97ffe1a917c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.IntOpt(\u0027producer_batch_size\u0027, default\u003d16384,"},{"line_number":49,"context_line":"               help\u003d\u0027Size of batch for the producer async send\u0027),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027compression_type\u0027, default\u003d\u0027none\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027The compression type for all data generated by the \u0027"},{"line_number":53,"context_line":"                    \u0027producer. Valid values are: gzip, snappy, lz4. If not \u0027"},{"line_number":54,"context_line":"                    \u0027set, compression will not be used.\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_3a3ca42d","line":51,"range":{"start_line":51,"start_character":16,"end_line":51,"end_character":32},"updated":"2019-06-14 11:41:40.000000000","message":"Why not use `compression_codec` here too?","commit_id":"f9c61bc533be8c6a6388b72dbde2b0c8f98fa6bd"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f5c88a46feeb098480f47d874444f97ffe1a917c","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027compression_type\u0027, default\u003d\u0027none\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027The compression type for all data generated by the \u0027"},{"line_number":53,"context_line":"                    \u0027producer. Valid values are: gzip, snappy, lz4. If not \u0027"},{"line_number":54,"context_line":"                    \u0027set, compression will not be used.\u0027),"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    cfg.BoolOpt(\u0027enable_auto_commit\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fb8cfa7_daf1c896","line":53,"range":{"start_line":53,"start_character":31,"end_line":53,"end_character":48},"updated":"2019-06-14 11:41:40.000000000","message":"So I think you need to introduce choices here to avoid issue with user input:\n```\nchoices\u003d(\"gzip\", \"snappy\", \"lz4\")\n```\n\nOr maybe we can introduce an Enum or something like that to keep the semantic between kafka interpretation and our code [1] (0\u003dnone, 1\u003dgzip, etc...)\n\n[1] https://cwiki.apache.org/confluence/display/KAFKA/Compression","commit_id":"f9c61bc533be8c6a6388b72dbde2b0c8f98fa6bd"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"83c051b46d6e3fb6f491ee94b99a4173bdbfc776","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    cfg.IntOpt(\u0027producer_batch_size\u0027, default\u003d16384,"},{"line_number":49,"context_line":"               help\u003d\u0027Size of batch for the producer async send\u0027),"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    cfg.StrOpt(\u0027compression_codec\u0027, default\u003d\u0027none\u0027,"},{"line_number":52,"context_line":"               help\u003d\u0027The compression codec for all data generated by the \u0027"},{"line_number":53,"context_line":"                    \u0027producer. Valid values are: gzip, snappy, lz4. If not \u0027"},{"line_number":54,"context_line":"                    \u0027set, compression will not be used.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_27c45b92","line":51,"updated":"2019-06-18 11:39:40.000000000","message":"We must check for valid inputs here by adding:\n```\nchoices\u003d[\u0027none\u0027, \u0027gzip\u0027, \u0027snappy\u0027, \u0027lz4\u0027, \u0027zstd\u0027]\n```\n\nPlease add this","commit_id":"64fd4351aadaa10f644956d793e9d488996aa7b9"}]}